Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Marc-André Lureau
- Original Message - > On Mon, 2017-06-19 at 10:06 -0400, Frediano Ziglio wrote: > > Question: can GDK have no X11? > chances are low but there may be a distro shipping gtk without the x11 > backend > > > I suppose only wayland compiled in? > or win32 or quartz (macOS). > > The issue I

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Pavel Grunt
On Mon, 2017-06-19 at 10:06 -0400, Frediano Ziglio wrote: > Question: can GDK have no X11? chances are low but there may be a distro shipping gtk without the x11 backend > I suppose only wayland compiled in? or win32 or quartz (macOS). The issue I noticed was in egl - which can work with wayland

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Pavel Grunt
Hi, On Mon, 2017-06-19 at 10:05 -0400, Marc-André Lureau wrote: > Hi, > > looks fine, how did you reproduce a build issue and make sure it > fixed it? > I noticed an "unguarded" usage of GDK_IS_X11_DISPLAY(), so i built gtk+ enabling only the wayland backend (and add the guards where needed).

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Frediano Ziglio
Question: can GDK have no X11? I suppose only wayland compiled in? > > --- > src/spice-gtk-session.c | 2 +- > src/spice-widget-egl.c | 14 +- > src/spice-widget.c | 2 +- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/src/spice-gtk-session.c

Re: [Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Marc-André Lureau
Hi, looks fine, how did you reproduce a build issue and make sure it fixed it? - Original Message - > --- > src/spice-gtk-session.c | 2 +- > src/spice-widget-egl.c | 14 +- > src/spice-widget.c | 2 +- > 3 files changed, 15 insertions(+), 3 deletions(-) > > diff

[Spice-devel] [PATCH spice-gtk] Allow to build without X11 gdk backend

2017-06-19 Thread Pavel Grunt
--- src/spice-gtk-session.c | 2 +- src/spice-widget-egl.c | 14 +- src/spice-widget.c | 2 +- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c index 33db3c8..e338ce6 100644 --- a/src/spice-gtk-session.c +++