Re: [Spice-devel] [PATCH spice-gtk] Use designated struct initializer

2017-07-26 Thread Daniel P. Berrange
On Fri, Jul 07, 2017 at 04:26:33PM +0200, Pavel Grunt wrote: > Silence -Wmissing-field-initializers warnings. This doesn't make sense for many of these cases you've changed > diff --git a/src/channel-main.c b/src/channel-main.c > index 4edd575..104b18a 100644 > --- a/src/channel-main.c > +++

Re: [Spice-devel] [PATCH spice-gtk] Use designated struct initializer

2017-07-26 Thread Christophe Fergeau
Hey, On Wed, Jul 26, 2017 at 11:12:25AM +0200, Pavel Grunt wrote: > On Fri, 2017-07-07 at 16:26 +0200, Pavel Grunt wrote: > > Silence -Wmissing-field-initializers warnings. > > Forgot to mention, it happens when building tests. My gcc --version: > gcc (GCC) 7.1.1 20170622 (Red Hat 7.1.1-3) I'm

Re: [Spice-devel] [PATCH spice-gtk] Use designated struct initializer

2017-07-26 Thread Pavel Grunt
On Fri, 2017-07-07 at 16:26 +0200, Pavel Grunt wrote: > Silence -Wmissing-field-initializers warnings. Forgot to mention, it happens when building tests. My gcc --version: gcc (GCC) 7.1.1 20170622 (Red Hat 7.1.1-3) But I'm not sure it is specific to gcc version, a similar fix has been replied

[Spice-devel] [PATCH spice-gtk] Use designated struct initializer

2017-07-07 Thread Pavel Grunt
Silence -Wmissing-field-initializers warnings. --- imo it also makes the code more readable (especially tests/session.c) --- src/channel-display-gst.c | 3 +- src/channel-main.c| 4 +- src/channel-record.c | 16 +++-- src/spice-channel.c | 12 ++-- src/spice-gtk-session.c