Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-20 Thread Pavel Grunt
Victor, it is faster to write NACK On Thu, 2017-07-20 at 07:26 +0200, Victor Toso wrote: > A new day, a new thread > > On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > streams. However the check for

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
A new day, a new thread On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > streams. However the check for elements through GstRegistry does not > take into account the possible pipeline of elements (like

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 18:00 +0200, Christophe Fergeau wrote: > On Wed, Jul 19, 2017 at 05:46:51PM +0200, Victor Toso wrote: > > What I'm trying to stress is that we are trying to not check *specific* > > plugins related to decode/parse a stream. We don't know what our users > > will be using and

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 18:13 +0200, Victor Toso wrote: > On Wed, Jul 19, 2017 at 06:01:43PM +0200, Pavel Grunt wrote: > > On Wed, 2017-07-19 at 17:46 +0200, Victor Toso wrote: > > > Hi, > > > > > > On Wed, Jul 19, 2017 at 05:27:43PM +0200, Pavel Grunt wrote: > > > > > Stream decoding will fail,

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
On Wed, Jul 19, 2017 at 06:01:43PM +0200, Pavel Grunt wrote: > On Wed, 2017-07-19 at 17:46 +0200, Victor Toso wrote: > > Hi, > > > > On Wed, Jul 19, 2017 at 05:27:43PM +0200, Pavel Grunt wrote: > > > > Stream decoding will fail, server will know about it and sever should > > > > fallback to image

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 17:46 +0200, Victor Toso wrote: > Hi, > > On Wed, Jul 19, 2017 at 05:27:43PM +0200, Pavel Grunt wrote: > > > Stream decoding will fail, server will know about it and sever should > > > fallback to image compression or a different video codec format for > > > streaming. > >

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Christophe Fergeau
On Wed, Jul 19, 2017 at 05:46:51PM +0200, Victor Toso wrote: > What I'm trying to stress is that we are trying to not check *specific* > plugins related to decode/parse a stream. We don't know what our users > will be using and we should not enforce them to use avdec_h264 for > instance. You are

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
Hi, On Wed, Jul 19, 2017 at 05:27:43PM +0200, Pavel Grunt wrote: > > Stream decoding will fail, server will know about it and sever should > > fallback to image compression or a different video codec format for > > streaming. > > millions of criticals in the debug log and some resources wasted >

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 16:43 +0200, Victor Toso wrote: > Hi, > > On Wed, Jul 19, 2017 at 04:25:19PM +0200, Pavel Grunt wrote: > > On Wed, 2017-07-19 at 16:15 +0200, Victor Toso wrote: > > > Hi, > > > > > > On Wed, Jul 19, 2017 at 04:01:21PM +0200, Pavel Grunt wrote: > > > > On Wed, 2017-07-19 at

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
Hi, On Wed, Jul 19, 2017 at 04:25:19PM +0200, Pavel Grunt wrote: > On Wed, 2017-07-19 at 16:15 +0200, Victor Toso wrote: > > Hi, > > > > On Wed, Jul 19, 2017 at 04:01:21PM +0200, Pavel Grunt wrote: > > > On Wed, 2017-07-19 at 15:52 +0200, Victor Toso wrote: > > > > On Wed, Jul 19, 2017 at

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 16:15 +0200, Victor Toso wrote: > Hi, > > On Wed, Jul 19, 2017 at 04:01:21PM +0200, Pavel Grunt wrote: > > On Wed, 2017-07-19 at 15:52 +0200, Victor Toso wrote: > > > On Wed, Jul 19, 2017 at 03:46:36PM +0200, Pavel Grunt wrote: > > > > On Wed, 2017-07-19 at 15:40 +0200,

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
Hi, On Wed, Jul 19, 2017 at 04:01:21PM +0200, Pavel Grunt wrote: > On Wed, 2017-07-19 at 15:52 +0200, Victor Toso wrote: > > On Wed, Jul 19, 2017 at 03:46:36PM +0200, Pavel Grunt wrote: > > > On Wed, 2017-07-19 at 15:40 +0200, Victor Toso wrote: > > > > On Wed, Jul 19, 2017 at 03:30:49PM +0200,

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 15:52 +0200, Victor Toso wrote: > On Wed, Jul 19, 2017 at 03:46:36PM +0200, Pavel Grunt wrote: > > On Wed, 2017-07-19 at 15:40 +0200, Victor Toso wrote: > > > On Wed, Jul 19, 2017 at 03:30:49PM +0200, Pavel Grunt wrote: > > > > On Wed, 2017-07-19 at 15:23 +0200, Victor Toso

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
On Wed, Jul 19, 2017 at 03:46:36PM +0200, Pavel Grunt wrote: > On Wed, 2017-07-19 at 15:40 +0200, Victor Toso wrote: > > On Wed, Jul 19, 2017 at 03:30:49PM +0200, Pavel Grunt wrote: > > > On Wed, 2017-07-19 at 15:23 +0200, Victor Toso wrote: > > > > Hi, > > > > > > > > On Wed, Jul 19, 2017 at

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 15:40 +0200, Victor Toso wrote: > On Wed, Jul 19, 2017 at 03:30:49PM +0200, Pavel Grunt wrote: > > On Wed, 2017-07-19 at 15:23 +0200, Victor Toso wrote: > > > Hi, > > > > > > On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > > > > GStreamer's avdec_h264 needs

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
On Wed, Jul 19, 2017 at 03:30:49PM +0200, Pavel Grunt wrote: > On Wed, 2017-07-19 at 15:23 +0200, Victor Toso wrote: > > Hi, > > > > On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > > streams. However

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
On Wed, 2017-07-19 at 15:23 +0200, Victor Toso wrote: > Hi, > > On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > streams. However the check for elements through GstRegistry does not > > take into account

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Victor Toso
Hi, On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > streams. However the check for elements through GstRegistry does not > take into account the possible pipeline of elements (like "h264parse ! >

[Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-19 Thread Pavel Grunt
GStreamer's avdec_h264 needs h264parse to be able to process H264 video streams. However the check for elements through GstRegistry does not take into account the possible pipeline of elements (like "h264parse ! avdec_h264"). Fix that by checking for the elements by their name. ---

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Victor Toso
On Thu, Jul 13, 2017 at 01:31:34PM +0200, Pavel Grunt wrote: > On Thu, 2017-07-13 at 13:22 +0200, Victor Toso wrote: > > Hi, > > > > On Thu, Jul 13, 2017 at 01:18:14PM +0200, Pavel Grunt wrote: > > > On Thu, 2017-07-13 at 13:11 +0200, Victor Toso wrote: > > > > On Thu, Jul 13, 2017 at 01:05:31PM

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Pavel Grunt
On Thu, 2017-07-13 at 13:22 +0200, Victor Toso wrote: > Hi, > > On Thu, Jul 13, 2017 at 01:18:14PM +0200, Pavel Grunt wrote: > > On Thu, 2017-07-13 at 13:11 +0200, Victor Toso wrote: > > > On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote: > > > > GStreamer's avdec_h264 needs h264parse

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Victor Toso
Hi, On Thu, Jul 13, 2017 at 01:18:14PM +0200, Pavel Grunt wrote: > On Thu, 2017-07-13 at 13:11 +0200, Victor Toso wrote: > > On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote: > > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > > streams. However the check

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Pavel Grunt
On Thu, 2017-07-13 at 13:11 +0200, Victor Toso wrote: > On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote: > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > streams. However the check for elements through GstRegistry forgot to > > include the parsers, thus

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Victor Toso
Hi, On Thu, Jul 13, 2017 at 01:11:00PM +0200, Victor Toso wrote: > On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote: > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > streams. However the check for elements through GstRegistry forgot to > > include the

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Victor Toso
On Thu, Jul 13, 2017 at 01:05:31PM +0200, Pavel Grunt wrote: > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > streams. However the check for elements through GstRegistry forgot to > include the parsers, thus making spice-gtk to not set the relevant cap > to inform the

[Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-13 Thread Pavel Grunt
GStreamer's avdec_h264 needs h264parse to be able to process H264 video streams. However the check for elements through GstRegistry forgot to include the parsers, thus making spice-gtk to not set the relevant cap to inform the server about H264 decoding capability. --- src/channel-display-gst.c |