Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

Hi, On Tue, Jul 18, 2017 at 06:55:12PM +0200, Christophe de Dinechin wrote: > Interestingly, I just discovered something I did not really expect: a > hot CPU is more than enough to make the spice client lack “oxygen”, > even if nothing else is running. > > If I start under light load and keep

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

> On 18 Jul 2017, at 17:59, Christophe de Dinechin wrote: > >> >> On 18 Jul 2017, at 17:54, Pavel Grunt wrote: >> >> On Tue, 2017-07-18 at 17:04 +0200, Christophe de Dinechin wrote: >>> On 14 Jul 2017, at 14:27, Christophe de Dinechin

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

> On 18 Jul 2017, at 17:54, Pavel Grunt wrote: > > On Tue, 2017-07-18 at 17:04 +0200, Christophe de Dinechin wrote: >> On 14 Jul 2017, at 14:27, Christophe de Dinechin wrote: >>> >>> This looks better than my fix. Can’t ack right now (I did not build

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

On Tue, 2017-07-18 at 17:04 +0200, Christophe de Dinechin wrote: > On 14 Jul 2017, at 14:27, Christophe de Dinechin wrote: > > > > This looks better than my fix. Can’t ack right now (I did not build and test > > it yet), but that looks like a reasonable approach > > > > >

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

> On 18 Jul 2017, at 17:12, Uri Lublin wrote: > > Hi Pavel, > > Some typos below. > > On 07/14/2017 02:19 PM, Pavel Grunt wrote: >> The fake channel has been introduced to get the audio volume by starting >> the gstreamer's audio pipeline and querring its volume info (see

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

Hi Pavel, Some typos below. On 07/14/2017 02:19 PM, Pavel Grunt wrote: The fake channel has been introduced to get the audio volume by starting the gstreamer's audio pipeline and querring its volume info (see commit querring -> querying aa8d044417bbf60685f59163b874ecb4f157c3c9). Hovewer

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

On 14 Jul 2017, at 14:27, Christophe de Dinechin wrote: > > This looks better than my fix. Can’t ack right now (I did not build and test > it yet), but that looks like a reasonable approach > >> On 14 Jul 2017, at 14:24, Pavel Grunt wrote: >> >> This

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

Hi, On Fri, Jul 14, 2017 at 02:24:34PM +0200, Pavel Grunt wrote: > This also fixes the huge memore leak reported by Christophe. > Steps to reproduce: > 1. ./configure --disable-pulse --enable-gstaudio > 2. connect to a vm streaming video with no audio playing > 3. see the memory grow really fast

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

This also fixes the huge memore leak reported by Christophe. Steps to reproduce: 1. ./configure --disable-pulse --enable-gstaudio 2. connect to a vm streaming video with no audio playing 3. see the memory grow really fast It seems to be due to the fact that the "fake audio" channel updates the

Re: [Spice-devel] [PATCH spice-gtk] gst-audio: Do not update mmtime without real audio channel

On Fri, Jul 14, 2017 at 01:19:43PM +0200, Pavel Grunt wrote: > The fake channel has been introduced to get the audio volume by starting > the gstreamer's audio pipeline and querring its volume info (see commit > aa8d044417bbf60685f59163b874ecb4f157c3c9). > > Hovewer starting the pipeline updates