Re: [Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken

2013-05-23 Thread Hans de Goede
ACK. BTW didn't we've a fixme comment for this somewhere, which then can be removed (preferably squashed into this commit), or was that only in a commit msg? Regards, Hans On 05/23/2013 01:56 AM, Marc-André Lureau wrote: This is similar to 8cbd5d745c221f788878c9c713f3b46a25828d3f and can be

[Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken

2013-05-22 Thread Marc-André Lureau
This is similar to 8cbd5d745c221f788878c9c713f3b46a25828d3f and can be reproduced by pressing Win+l while the widget has the keyboard grab (pointer over the display). I have not reproduced implicit grab-broken event, I suppose they could happen if the grab is stolen from within the app. In any cas

Re: [Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken by external applications

2013-05-15 Thread Hans de Goede
Hi, Looks good, ACK. About the FIXME, no we should not always release the keys on ungrab, since an ungrab != focus loss in some cases, ie it can be done by the client through the PROP_KEYBOARD_GRAB property. Regards, Hans On 05/15/2013 08:02 PM, Marc-André Lureau wrote: Fixes l key repeatiti

[Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken by external applications

2013-05-15 Thread Marc-André Lureau
Fixes l key repeatition when pressing Alt+L on Windows when the pointer is over the display. https://bugzilla.redhat.com/show_bug.cgi?id=917986 --- gtk/spice-widget.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index de1cead..2e513a8 100644 -