Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-14 Thread Christophe Fergeau
On Thu, Nov 13, 2014 at 07:26:10PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 6:38 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Thu, Nov 13, 2014 at 05:41:20PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-14 Thread Marc-André Lureau
On Fri, Nov 14, 2014 at 10:59 AM, Christophe Fergeau cferg...@redhat.com wrote: Hmm I only partially understood what your log meant, and tried to improve it, but it's very partial. I think it's better to be explicit about main context/coroutine context here, maybe something like During

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-14 Thread Christophe Fergeau
On Fri, Nov 14, 2014 at 12:06:30PM +0100, Marc-André Lureau wrote: On Fri, Nov 14, 2014 at 10:59 AM, Christophe Fergeau cferg...@redhat.com wrote: Hmm I only partially understood what your log meant, and tried to improve it, but it's very partial. I think it's better to be explicit about

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-13 Thread Christophe Fergeau
On Wed, Nov 12, 2014 at 06:49:50PM +0100, Marc-André Lureau wrote: On Wed, Nov 12, 2014 at 6:35 PM, Christophe Fergeau cferg...@redhat.com wrote: 'git grep spice_channel_disconnect' gives: doc/reference/spice-gtk-sections.txt:spice_channel_disconnect gtk/channel-main.c:

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-13 Thread Christophe Fergeau
On Wed, Nov 12, 2014 at 05:56:26PM +0100, Marc-André Lureau wrote: On Wed, Nov 12, 2014 at 5:08 PM, Christophe Fergeau cferg...@redhat.com wrote: Rereading the commit log, this movement seems unrelated to what you are fixing anyway? It is related, since we change the state to

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-13 Thread Marc-André Lureau
On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com wrote: Ah, this is the bit I was missing thanks! The commit log needs to be much more detailed and accurate, and mention explicitly the various code paths involved to trigger the error, where the looping occurs, ...

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-13 Thread Christophe Fergeau
Hey, On Thu, Nov 13, 2014 at 05:41:20PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com wrote: Ah, this is the bit I was missing thanks! The commit log needs to be much more detailed and accurate, and mention explicitly the various

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-13 Thread Christophe Fergeau
On Thu, Nov 13, 2014 at 04:43:26PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 10:15 AM, Christophe Fergeau cferg...@redhat.com wrote: It seems it could have stayed in the same place, but with the check changed to _CONNECTING instead of != UNCONNECTED? It is not the same

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-13 Thread Marc-André Lureau
On Thu, Nov 13, 2014 at 6:38 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Thu, Nov 13, 2014 at 05:41:20PM +0100, Marc-André Lureau wrote: On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com wrote: Ah, this is the bit I was missing thanks! The commit

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-12 Thread Christophe Fergeau
On Sun, Nov 09, 2014 at 05:31:38PM +0100, Marc-André Lureau wrote: During migration, the main channel initiating the process is waiting on connection completion or error. However, if the migration is cancelled, but the main channel state is still NONE, no error event will be fired, and the

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-12 Thread Marc-André Lureau
- Original Message - On Sun, Nov 09, 2014 at 05:31:38PM +0100, Marc-André Lureau wrote: During migration, the main channel initiating the process is waiting on connection completion or error. However, if the migration is cancelled, but the main channel state is still NONE, no

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-12 Thread Marc-André Lureau
On Wed, Nov 12, 2014 at 5:08 PM, Christophe Fergeau cferg...@redhat.com wrote: Rereading the commit log, this movement seems unrelated to what you are fixing anyway? It is related, since we change the state to connecting before requesting the fd, but we want to keep a warning when calling

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-12 Thread Christophe Fergeau
On Wed, Nov 12, 2014 at 11:27:28AM -0500, Marc-André Lureau wrote: - Original Message - On Sun, Nov 09, 2014 at 05:31:38PM +0100, Marc-André Lureau wrote: During migration, the main channel initiating the process is waiting on connection completion or error. However, if the

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-12 Thread Marc-André Lureau
- Original Message - On Wed, Nov 12, 2014 at 11:27:28AM -0500, Marc-André Lureau wrote: - Original Message - On Sun, Nov 09, 2014 at 05:31:38PM +0100, Marc-André Lureau wrote: During migration, the main channel initiating the process is waiting on connection

Re: [Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-12 Thread Christophe Fergeau
On Wed, Nov 12, 2014 at 12:13:07PM -0500, Marc-André Lureau wrote: - Original Message - On Wed, Nov 12, 2014 at 11:27:28AM -0500, Marc-André Lureau wrote: - Original Message - On Sun, Nov 09, 2014 at 05:31:38PM +0100, Marc-André Lureau wrote: During

[Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

2014-11-09 Thread Marc-André Lureau
During migration, the main channel initiating the process is waiting on connection completion or error. However, if the migration is cancelled, but the main channel state is still NONE, no error event will be fired, and the main channel will remain frozen. Setting connecting state before