[Spice-devel] [PATCH spice-gtk 1/2] audio: use weak references to channel

2014-11-07 Thread Marc-André Lureau
The audio channels are currently referenced and released on channel close events. However, this event may not happen if the channel never was connected. Keeping channels alive also prevent session from finishing. By not holding the ref, the channel can go to dispose when it is no longer needed,

Re: [Spice-devel] [PATCH spice-gtk 1/2] audio: use weak references to channel

2014-11-07 Thread Marc-André Lureau
hi On Fri, Nov 7, 2014 at 8:41 PM, Marc-André Lureau marcandre.lur...@redhat.com wrote: p-rchannel = g_object_ref(channel); oops, fixed by p-rchannel = channel -- Marc-André Lureau ___ Spice-devel mailing list

Re: [Spice-devel] [PATCH spice-gtk 1/2] audio: use weak references to channel

2014-11-07 Thread Fabiano Fidêncio
On Fri, Nov 7, 2014 at 8:41 PM, Marc-André Lureau marcandre.lur...@redhat.com wrote: The audio channels are currently referenced and released on channel close events. However, this event may not happen if the channel never was connected. Keeping channels alive also prevent session from

Re: [Spice-devel] [PATCH spice-gtk 1/2] audio: use weak references to channel

2014-11-07 Thread Fabiano Fidêncio
On Fri, Nov 7, 2014 at 11:59 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: hi On Fri, Nov 7, 2014 at 8:41 PM, Marc-André Lureau marcandre.lur...@redhat.com wrote: p-rchannel = g_object_ref(channel); oops, fixed by p-rchannel = channel -- Marc-André Lureau