Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-08-04 Thread Christophe de Dinechin
> On 4 Aug 2017, at 13:44, Christophe Fergeau wrote: > > On Fri, Aug 04, 2017 at 12:11:44PM +0200, Christophe de Dinechin wrote: >> >>> On 18 Jul 2017, at 16:48, Christophe Fergeau wrote: >>> >>> Hey, >>> >>> On Tue, Jul 18, 2017 at 04:37:29PM

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-08-04 Thread Christophe Fergeau
On Fri, Aug 04, 2017 at 12:11:44PM +0200, Christophe de Dinechin wrote: > > > On 18 Jul 2017, at 16:48, Christophe Fergeau wrote: > > > > Hey, > > > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin wrote: > >> OK. Since you seem to feel more strongly

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-08-04 Thread Christophe de Dinechin
> On 18 Jul 2017, at 16:48, Christophe Fergeau wrote: > > Hey, > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin wrote: >> OK. Since you seem to feel more strongly about this than me, I changed it. >> Pushed to freedesktop.org. Since this is the first

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-21 Thread Marc-André Lureau
Hi - Original Message - > On Tue, 2017-07-18 at 16:50 +0200, Christophe de Dinechin wrote: > > > On 18 Jul 2017, at 16:48, Christophe Fergeau > > > wrote: > > > > > > Hey, > > > > > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin > > > wrote: > >

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-20 Thread Jonathon Jongsma
On Tue, 2017-07-18 at 16:50 +0200, Christophe de Dinechin wrote: > > On 18 Jul 2017, at 16:48, Christophe Fergeau > > wrote: > > > > Hey, > > > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin > > wrote: > > > OK. Since you seem to feel more strongly about

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-18 Thread Christophe Fergeau
On Tue, Jul 18, 2017 at 04:50:23PM +0200, Christophe de Dinechin wrote: > > > On 18 Jul 2017, at 16:48, Christophe Fergeau wrote: > > > > Hey, > > > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin wrote: > >> OK. Since you seem to feel more strongly

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-18 Thread Christophe de Dinechin
> On 18 Jul 2017, at 16:48, Christophe Fergeau wrote: > > Hey, > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin wrote: >> OK. Since you seem to feel more strongly about this than me, I changed it. >> Pushed to freedesktop.org. Since this is the first

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-18 Thread Christophe Fergeau
Hey, On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin wrote: > OK. Since you seem to feel more strongly about this than me, I changed it. > Pushed to freedesktop.org. Since this is the first time I push myself to this > repo, > would you please be kind enough to check that what I

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-18 Thread Christophe de Dinechin
> > On 17 Jul 2017, at 14:20, Christophe Fergeau wrote: > > On Mon, Jul 17, 2017 at 02:00:01PM +0200, Christophe de Dinechin wrote: >> >>> On 17 Jul 2017, at 13:49, Christophe Fergeau >> > wrote: >>> >>> On Mon, Jul 17,

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-17 Thread Christophe Fergeau
On Mon, Jul 17, 2017 at 02:00:01PM +0200, Christophe de Dinechin wrote: > > > On 17 Jul 2017, at 13:49, Christophe Fergeau > > wrote: > > > > On Mon, Jul 17, 2017 at 11:44:04AM +0200, Christophe de Dinechin wrote: > >> From: Christophe de

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-17 Thread Christophe de Dinechin
> On 17 Jul 2017, at 13:49, Christophe Fergeau > wrote: > > On Mon, Jul 17, 2017 at 11:44:04AM +0200, Christophe de Dinechin wrote: >> From: Christophe de Dinechin > > >> >> The mm timer is a

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-17 Thread Christophe Fergeau
On Mon, Jul 17, 2017 at 11:44:04AM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > The mm timer is a millisecond timer that wraps around after ~49 days. > All comparisons that look like a Instead, use signed ((int)(a-b)<0), which may fail if there is

[Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-17 Thread Christophe de Dinechin
From: Christophe de Dinechin The mm timer is a millisecond timer that wraps around after ~49 days. All comparisons that look like a --- src/channel-display-gst.c | 4 ++-- src/channel-display-mjpeg.c | 4 ++-- src/channel-display.c | 2 +- src/channel-playback.c