Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-13 Thread Christophe Fergeau
On Mon, Oct 10, 2016 at 08:37:04AM -0400, Marc-André Lureau wrote: > Imho, it should be fine for the client to send the same monitor > config, the server should however not notify of changes if none > happened. Yup, after quite a lot of digging, this seems to be what is happening, nothing in the

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-13 Thread Christophe Fergeau
On Tue, Oct 11, 2016 at 04:56:42PM +0200, Pavel Grunt wrote: > On Tue, 2016-10-11 at 10:36 -0400, Marc-André Lureau wrote: > > > > > > Flickering is PRIMARY_DESTROY & PRIMARY_CREATE > > > > Is there a way to prevent DESTROY & CREATE of same size on > > server/guest side? why not? > > The

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-11 Thread Pavel Grunt
On Tue, 2016-10-11 at 10:36 -0400, Marc-André Lureau wrote: > > - Original Message - > > Hi, > > > > On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > When the guest receives the monitor configuration message, it > > >

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-11 Thread Marc-André Lureau
- Original Message - > Hi, > > On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > When the guest receives the monitor configuration message, it > > > replies > > > (through spice-server) by destroying the primary surface, which

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-11 Thread Pavel Grunt
Hi, On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > When the guest receives the monitor configuration message, it > > replies > > (through spice-server) by destroying the primary surface, which > > makes > > the SpiceDisplay disabled if its

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-10 Thread Christophe Fergeau
Hey, On Mon, Oct 10, 2016 at 05:12:53PM +0200, Pavel Grunt wrote: > On Mon, 2016-10-10 at 17:03 +0200, Christophe Fergeau wrote: > > Hey, > > > > On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote: > > > The configuration messages are sent only when agent is running. > > > > > > It is

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-10 Thread Pavel Grunt
On Mon, 2016-10-10 at 17:03 +0200, Christophe Fergeau wrote: > Hey, > > On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote: > > The configuration messages are sent only when agent is running. > > > > It is happening all the time that the configuration message was > > technically not

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-10 Thread Christophe Fergeau
Hey, On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote: > The configuration messages are sent only when agent is running. > > It is happening all the time that the configuration message was > technically not successful (linux guest supports only width of > multiple of 8) and in fact it

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-10 Thread Pavel Grunt
Hi Marc-André, On Mon, 2016-10-10 at 08:37 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > When the guest receives the monitor configuration message, it > > replies > > (through spice-server) by destroying the primary surface, which > > makes > > the SpiceDisplay

Re: [Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-10 Thread Marc-André Lureau
Hi - Original Message - > When the guest receives the monitor configuration message, it replies > (through spice-server) by destroying the primary surface, which makes > the SpiceDisplay disabled if its "resize-guest" property is used. > This change of the display state

[Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

2016-10-10 Thread Pavel Grunt
When the guest receives the monitor configuration message, it replies (through spice-server) by destroying the primary surface, which makes the SpiceDisplay disabled if its "resize-guest" property is used. This change of the display state (disabled/enabled) leads to sending a new monitor config