Re: [Spice-devel] [PATCH spice-protocol v4] stats: Avoid holes in SpiceStat structure

2019-01-17 Thread Christophe Fergeau
On Mon, Jan 14, 2019 at 04:17:49PM +, Frediano Ziglio wrote: > The SpiceStat structure can be 20 or 24 bytes depending on alignment. > Being a memory mapped structure potentially used with lockless access, > it is not good to have it unaligned. > The only tool that we know of that reads this

[Spice-devel] [PATCH spice-protocol v4] stats: Avoid holes in SpiceStat structure

2019-01-14 Thread Frediano Ziglio
The SpiceStat structure can be 20 or 24 bytes depending on alignment. Being a memory mapped structure potentially used with lockless access, it is not good to have it unaligned. The only tool that we know of that reads this memory mapped file (reds_stats) is able to detect if the structure is