Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On 19/03/18 06:28, Frediano Ziglio wrote: >> >> On 15/03/18 14:20, Christophe Fergeau wrote: >>> On Tue, Mar 13, 2018 at 10:37:46AM -0300, Eduardo Lima (Etrunko) wrote: On 13/03/18 04:21, Frediano Ziglio wrote: >> >> This patch makes it clear that this is a configure switch and not a

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

> > On 15/03/18 14:20, Christophe Fergeau wrote: > > On Tue, Mar 13, 2018 at 10:37:46AM -0300, Eduardo Lima (Etrunko) wrote: > >> On 13/03/18 04:21, Frediano Ziglio wrote: > > This patch makes it clear that this is a configure switch and not a > variable defined somewhere else in

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On 15/03/18 14:20, Christophe Fergeau wrote: > On Tue, Mar 13, 2018 at 10:37:46AM -0300, Eduardo Lima (Etrunko) wrote: >> On 13/03/18 04:21, Frediano Ziglio wrote: This patch makes it clear that this is a configure switch and not a variable defined somewhere else in the code.

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On 15/03/18 08:19, Uri Lublin wrote: > On 03/13/2018 03:37 PM, Eduardo Lima (Etrunko) wrote: >> On 13/03/18 04:21, Frediano Ziglio wrote: This patch makes it clear that this is a configure switch and not a variable defined somewhere else in the code. >>> >>> The code is

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On Tue, Mar 13, 2018 at 10:37:46AM -0300, Eduardo Lima (Etrunko) wrote: > On 13/03/18 04:21, Frediano Ziglio wrote: > >> > >> This patch makes it clear that this is a configure switch and not a > >> variable defined somewhere else in the code. > >> > > > > The code is intended that way to make

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On 03/15/2018 01:19 PM, Uri Lublin wrote: On 03/13/2018 03:37 PM, Eduardo Lima (Etrunko) wrote: On 13/03/18 04:21, Frediano Ziglio wrote: This patch makes it clear that this is a configure switch and not a variable defined somewhere else in the code. The code is intended that way to make

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On 03/13/2018 03:37 PM, Eduardo Lima (Etrunko) wrote: On 13/03/18 04:21, Frediano Ziglio wrote: This patch makes it clear that this is a configure switch and not a variable defined somewhere else in the code. The code is intended that way to make the compiler always parse these parts. Note

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

On 13/03/18 04:21, Frediano Ziglio wrote: >> >> This patch makes it clear that this is a configure switch and not a >> variable defined somewhere else in the code. >> > > The code is intended that way to make the compiler always parse > these parts. Note that that define is always defined so your

Re: [Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

> > This patch makes it clear that this is a configure switch and not a > variable defined somewhere else in the code. > The code is intended that way to make the compiler always parse these parts. Note that that define is always defined so your code is not doing what you are intending.

[Spice-devel] [PATCH spice-server 1/2] Change ENABLE_EXTRA_CHECKS statements to #ifdef

This patch makes it clear that this is a configure switch and not a variable defined somewhere else in the code. Signed-off-by: Eduardo Lima (Etrunko) --- server/display-channel.c | 4 +++- server/reds.c| 6 +++--- server/stream-device.c | 22