Re: [Spice-devel] [PATCH spice-server 2/2] Fix crash attempting to connect duplicate channels

2017-09-18 Thread Jonathon Jongsma
On Thu, 2017-09-07 at 10:28 +0100, Frediano Ziglio wrote: > You could easily trigger this issue using multiple monitors and a > modified spice-gtk client with this patch: > > --- a/src/channel-main.c > +++ b/src/channel-main.c > @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_

[Spice-devel] [PATCH spice-server 2/2] Fix crash attempting to connect duplicate channels

2017-09-07 Thread Frediano Ziglio
You could easily trigger this issue using multiple monitors and a modified spice-gtk client with this patch: --- a/src/channel-main.c +++ b/src/channel-main.c @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_t *c) { g_return_val_if_fail(c != NULL, FALSE); +if (

Re: [Spice-devel] [PATCH spice-server 2/2] Fix crash attempting to connect duplicate channels

2017-08-30 Thread Christophe de Dinechin
> On 30 Aug 2017, at 10:53, Frediano Ziglio wrote: > >> >>> On 30 Aug 2017, at 10:19, Frediano Ziglio wrote: >>> >>> You could easily trigger this issue using multiple monitors and >>> a modified client with this patch: >>> >>> --- a/src/channel-main.c >>> +++ b/src/channel-main.c >>> @@ -16

Re: [Spice-devel] [PATCH spice-server 2/2] Fix crash attempting to connect duplicate channels

2017-08-30 Thread Frediano Ziglio
> > > On 30 Aug 2017, at 10:19, Frediano Ziglio wrote: > > > > You could easily trigger this issue using multiple monitors and > > a modified client with this patch: > > > > --- a/src/channel-main.c > > +++ b/src/channel-main.c > > @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_

Re: [Spice-devel] [PATCH spice-server 2/2] Fix crash attempting to connect duplicate channels

2017-08-30 Thread Christophe de Dinechin
> On 30 Aug 2017, at 10:19, Frediano Ziglio wrote: > > You could easily trigger this issue using multiple monitors and > a modified client with this patch: > > --- a/src/channel-main.c > +++ b/src/channel-main.c > @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_t *c) > { > g_

[Spice-devel] [PATCH spice-server 2/2] Fix crash attempting to connect duplicate channels

2017-08-30 Thread Frediano Ziglio
You could easily trigger this issue using multiple monitors and a modified client with this patch: --- a/src/channel-main.c +++ b/src/channel-main.c @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_t *c) { g_return_val_if_fail(c != NULL, FALSE); +if (c->type == SPICE_CHANN