Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

On Tue, Sep 12, 2017 at 07:19:32AM -0400, Frediano Ziglio wrote: > About checking for pointer assuming you have to check for NULL > would mean the NULL is not 0 which would mean that > memset(structure_ptr, 0, sizeof(structure)) cannot set pointer > to NULL which would mean that assuming pointer

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

> > On Tue, Sep 12, 2017 at 05:44:23AM -0400, Frediano Ziglio wrote: > > > > > > On Tue, Sep 12, 2017 at 04:11:57AM -0400, Frediano Ziglio wrote: > > > > > > > > > > On Tue, Sep 12, 2017 at 03:41:15AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > On Tue, Sep 12, 2017 at 03:19:12AM

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

On Tue, Sep 12, 2017 at 05:44:23AM -0400, Frediano Ziglio wrote: > > > > On Tue, Sep 12, 2017 at 04:11:57AM -0400, Frediano Ziglio wrote: > > > > > > > > On Tue, Sep 12, 2017 at 03:41:15AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

> > On Tue, Sep 12, 2017 at 04:11:57AM -0400, Frediano Ziglio wrote: > > > > > > On Tue, Sep 12, 2017 at 03:41:15AM -0400, Frediano Ziglio wrote: > > > > > > > > > > On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano Ziglio wrote: > > > > > > > > -const EncoderInfo *encoder = > > > > > > >

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

On Tue, Sep 12, 2017 at 04:11:57AM -0400, Frediano Ziglio wrote: > > > > On Tue, Sep 12, 2017 at 03:41:15AM -0400, Frediano Ziglio wrote: > > > > > > > > On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano Ziglio wrote: > > > > > > > -const EncoderInfo *encoder =

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

> > On Tue, Sep 12, 2017 at 03:41:15AM -0400, Frediano Ziglio wrote: > > > > > > On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano Ziglio wrote: > > > > > > -const EncoderInfo *encoder = get_encoder_info(encoder_name); > > > > > > +const EncoderInfo *encoder =

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

On Tue, Sep 12, 2017 at 03:41:15AM -0400, Frediano Ziglio wrote: > > > > On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano Ziglio wrote: > > > > > -const EncoderInfo *encoder = get_encoder_info(encoder_name); > > > > > +const EncoderInfo *encoder = get_encoder_info(encoder_name ? > > > >

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

> > On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano Ziglio wrote: > > > > -const EncoderInfo *encoder = get_encoder_info(encoder_name); > > > > +const EncoderInfo *encoder = get_encoder_info(encoder_name ? > > > > encoder_name : "mjpeg"); > > > > if (!encoder) { > > > >

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

On Tue, Sep 12, 2017 at 03:19:12AM -0400, Frediano Ziglio wrote: > > > -const EncoderInfo *encoder = get_encoder_info(encoder_name); > > > +const EncoderInfo *encoder = get_encoder_info(encoder_name ? > > > encoder_name : "mjpeg"); > > > if (!encoder) { > > >

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

> > On Mon, Sep 11, 2017 at 09:12:17AM +0100, Frediano Ziglio wrote: > > These leaks are detected for instance by address sanitizer. > > More details about what these leaks are would be welcome... > I can guess what these are, but the commit log is really where this > belongs. > > > > > >

Re: [Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

On Mon, Sep 11, 2017 at 09:12:17AM +0100, Frediano Ziglio wrote: > These leaks are detected for instance by address sanitizer. More details about what these leaks are would be welcome... I can guess what these are, but the commit log is really where this belongs. > > Signed-off-by: Frediano

[Spice-devel] [PATCH spice-server 2/3] test-gst: Remove options parsing leaks

These leaks are detected for instance by address sanitizer. Signed-off-by: Frediano Ziglio --- server/tests/test-gst.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/server/tests/test-gst.c b/server/tests/test-gst.c index