Re: [Spice-devel] [PATCH spice-server 4/6] red-qxl: Avoid to use AsyncCommand for GL_DRAW_ASYNC message

2017-09-08 Thread Frediano Ziglio
> > OK. The invalid cookie value is a bit odd, but looks safe. > Not that odd, CreateFile, open, mmap and iconv for instance return similar values Frediano > Acked-by: Jonathon Jongsma > > > On Thu, 2017-09-07 at 12:40 +0100, Frediano Ziglio wrote: > > AsyncCommand is

Re: [Spice-devel] [PATCH spice-server 4/6] red-qxl: Avoid to use AsyncCommand for GL_DRAW_ASYNC message

2017-09-07 Thread Jonathon Jongsma
OK. The invalid cookie value is a bit odd, but looks safe. Acked-by: Jonathon Jongsma On Thu, 2017-09-07 at 12:40 +0100, Frediano Ziglio wrote: > AsyncCommand is used to handle asynchronous messages from the > dispatcher. > GL_DRAW_ASYNC is mainly using it to store the

[Spice-devel] [PATCH spice-server 4/6] red-qxl: Avoid to use AsyncCommand for GL_DRAW_ASYNC message

2017-09-07 Thread Frediano Ziglio
AsyncCommand is used to handle asynchronous messages from the dispatcher. GL_DRAW_ASYNC is mainly using it to store the cookie. The value of GL_DRAW_COOKIE_INVALID was choosen to allow implementing cookies (which basically are handles) either using indexes (where 0 is valid) or pointers (where 0