Re: [Spice-devel] [PATCH spice-server v2 03/15] test-display-base: Avoid usage after free when the wakeup timer is freed

2017-09-07 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Sep 06, 2017 at 05:26:53PM +0100, Frediano Ziglio wrote: > The wakeup timer is used by the worker thread and by the > main thread. > Destroying the object before destroying the worker thread > can lead to use after free. > Destroying the

[Spice-devel] [PATCH spice-server v2 03/15] test-display-base: Avoid usage after free when the wakeup timer is freed

2017-09-06 Thread Frediano Ziglio
The wakeup timer is used by the worker thread and by the main thread. Destroying the object before destroying the worker thread can lead to use after free. Destroying the worker thread first makes sure we don't race. This is detected easily when compiling the test with address sanitizer.