Re: [Spice-devel] [PATCH spice-server v2 3/3] Fix crash attempting to connect duplicate channels

2017-09-07 Thread Jonathon Jongsma
On Thu, 2017-09-07 at 03:50 -0400, Frediano Ziglio wrote: > > > > On Wed, 2017-08-30 at 10:36 +0100, Frediano Ziglio wrote: > > > You could easily trigger this issue using multiple monitors and > > > a modified spice-gtk client with this patch: > > > > > > --- a/src/channel-main.c > > > +++

Re: [Spice-devel] [PATCH spice-server v2 3/3] Fix crash attempting to connect duplicate channels

2017-09-07 Thread Frediano Ziglio
> > On Wed, 2017-08-30 at 10:36 +0100, Frediano Ziglio wrote: > > You could easily trigger this issue using multiple monitors and > > a modified spice-gtk client with this patch: > > > > --- a/src/channel-main.c > > +++ b/src/channel-main.c > > @@ -1699,6 +1699,7 @@ static gboolean

Re: [Spice-devel] [PATCH spice-server v2 3/3] Fix crash attempting to connect duplicate channels

2017-09-06 Thread Jonathon Jongsma
On Wed, 2017-08-30 at 10:36 +0100, Frediano Ziglio wrote: > You could easily trigger this issue using multiple monitors and > a modified spice-gtk client with this patch: > > --- a/src/channel-main.c > +++ b/src/channel-main.c > @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_t *c)

[Spice-devel] [PATCH spice-server v2 3/3] Fix crash attempting to connect duplicate channels

2017-08-30 Thread Frediano Ziglio
You could easily trigger this issue using multiple monitors and a modified spice-gtk client with this patch: --- a/src/channel-main.c +++ b/src/channel-main.c @@ -1699,6 +1699,7 @@ static gboolean _channel_new(channel_new_t *c) { g_return_val_if_fail(c != NULL, FALSE); +if (c->type ==