Re: [Spice-devel] [PATCH v2] Revert if to make code more readable

2016-09-22 Thread Uri Lublin
On 09/20/2016 10:05 AM, Frediano Ziglio wrote: Keep all code to send SPICE_MSG_LIST together. Signed-off-by: Frediano Ziglio Ack. --- server/dcc-send.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Changed since v1: - moved comment diff --git a/server/dcc-send.c b/server/d

Re: [Spice-devel] [PATCH v2] Revert if to make code more readable

2016-09-21 Thread Frediano Ziglio
> Looks fine to me, but the commit log should say "Invert", not "Revert". > > Aside from that: > Acked-by: Jonathon Jongsma > You are right... unfortunately was already committed Frediano > > On Tue, 2016-09-20 at 08:05 +0100, Frediano Ziglio wrote: > > Keep all code to send SPICE_MSG_LIST

Re: [Spice-devel] [PATCH v2] Revert if to make code more readable

2016-09-21 Thread Jonathon Jongsma
Looks fine to me, but the commit log should say "Invert", not "Revert". Aside from that: Acked-by: Jonathon Jongsma On Tue, 2016-09-20 at 08:05 +0100, Frediano Ziglio wrote: > Keep all code to send SPICE_MSG_LIST together. > > Signed-off-by: Frediano Ziglio > --- >  server/dcc-send.c | 7

[Spice-devel] [PATCH v2] Revert if to make code more readable

2016-09-20 Thread Frediano Ziglio
Keep all code to send SPICE_MSG_LIST together. Signed-off-by: Frediano Ziglio --- server/dcc-send.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) Changed since v1: - moved comment diff --git a/server/dcc-send.c b/server/dcc-send.c index 1d05c68..32c6f17 100644 --- a/server/dcc-s