Re: [Spice-devel] [PATCH v2] server: add async io support

2011-07-07 Thread Alon Levy
On Thu, Jul 07, 2011 at 09:29:47AM +0200, Gerd Hoffmann wrote: > >Hi, > >I find it problematic to decouple the qxl operations upon QXL_IO and the > >worker operations. For example: upon destroy_surfaces, the qxl resets > >the tracked guest commands. However, since destroy_surfaces is asynced, > >th

Re: [Spice-devel] [PATCH v2] server: add async io support

2011-07-07 Thread Alon Levy
On Thu, Jul 07, 2011 at 09:38:01AM +0300, Yonit Halperin wrote: > On 07/06/2011 08:37 PM, Alon Levy wrote: > >The new _ASYNC io's in qxl_dev listed at the end get six new api > >functions, and an additional callback function "async_complete". When > >the async version of a specific io is used, comp

Re: [Spice-devel] [PATCH v2] server: add async io support

2011-07-07 Thread Alon Levy
On Thu, Jul 07, 2011 at 09:16:33AM +0300, Yonit Halperin wrote: > On 07/06/2011 08:37 PM, Alon Levy wrote: > >The new _ASYNC io's in qxl_dev listed at the end get six new api > >functions, and an additional callback function "async_complete". When > >the async version of a specific io is used, comp

Re: [Spice-devel] [PATCH v2] server: add async io support

2011-07-07 Thread Gerd Hoffmann
Hi, I find it problematic to decouple the qxl operations upon QXL_IO and the worker operations. For example: upon destroy_surfaces, the qxl resets the tracked guest commands. However, since destroy_surfaces is asynced, the worker might read commands from the ring before handling destroy surfaces,

Re: [Spice-devel] [PATCH v2] server: add async io support

2011-07-06 Thread Yonit Halperin
On 07/06/2011 08:37 PM, Alon Levy wrote: The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is wri

Re: [Spice-devel] [PATCH v2] server: add async io support

2011-07-06 Thread Yonit Halperin
On 07/06/2011 08:37 PM, Alon Levy wrote: The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is wri

[Spice-devel] [PATCH v2] server: add async io support

2011-07-06 Thread Alon Levy
The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function "async_complete". When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is written or expected by the dispatcher. update