On Fri, May 29, 2020 at 11:22 PM Keiichi Watanabe wrote:
>
> Hi Dmitry,
>
> On Wed, May 27, 2020 at 9:12 PM Dmitry Sepp
> wrote:
> >
> > Hi Keiichi,
> >
> > On Montag, 18. Mai 2020 07:17:53 CEST Keiichi Watanabe wrote:
> > > > +struct virtio_video_stream_create {
> > > > +struct
Hi Dmitry,
On Wed, May 27, 2020 at 9:12 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Montag, 18. Mai 2020 07:17:53 CEST Keiichi Watanabe wrote:
> > > +struct virtio_video_stream_create {
> > > +struct virtio_video_cmd_hdr hdr;
> > > +le32 in_mem_type; /* One of
Hi Keiichi,
On Montag, 18. Mai 2020 07:17:53 CEST Keiichi Watanabe wrote:
> > +struct virtio_video_stream_create {
> > +struct virtio_video_cmd_hdr hdr;
> > +le32 in_mem_type; /* One of VIRTIO_VIDEO_MEM_TYPE_* types */
> > +le32 out_mem_type; /* One of
Hi,
While I'm writing the next version of this proposal, I came up with
some changes on the protocol. Let me share my ideas in advance. I'd
like to hear your idea if you have another thought.
On Thu, Feb 6, 2020 at 7:21 PM Keiichi Watanabe wrote:
>
> From: Dmitry Sepp
>
> The virtio video
Hi Keiichi,
Thanks for the update.
> > Thanks for providing this detailed overview. But again, we have already
> > discussed this in a similar way and it does not answer the questions. Ok,
> > suppose we set bitrate to 0x as I assumed above. Then the decoder
> > code should ideally wait
Hi Keiichi,
One more addition to the comments below. Currently spec does not define units
for bitrate (are units needed for anything else except that?). Let's
explicitly state that bitrate is provided in bits per sec, so whatever
implementation can do proper conversion if needed.
Best
Hi Dmitry,
On Tue, Apr 21, 2020 at 5:39 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Montag, 20. April 2020 11:57:52 CEST Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Fri, Apr 17, 2020 at 5:09 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
> > > On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi
Hi Dmitry,
On Thu, Apr 9, 2020 at 10:23 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Donnerstag, 9. April 2020 12:46:56 CEST Keiichi Watanabe wrote:
> > Hi,
> >
> > On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp
> wrote:
> > > Hi,
> > >
> > > > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a
Hi Keiichi,
On Montag, 20. April 2020 11:57:52 CEST Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Fri, Apr 17, 2020 at 5:09 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi Watanabe wrote:
> > > Currently, we have three options of the design of per-stream
Hi Dmitry,
On Fri, Apr 17, 2020 at 5:09 PM Dmitry Sepp wrote:
>
> Hi,
>
> On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi Watanabe wrote:
> > Currently, we have three options of the design of per-stream properties:
> >
> > 1. Have two structs for image format and bitstream format.
> > Pros:
>
Hi,
On Donnerstag, 9. April 2020 12:46:27 CEST Keiichi Watanabe wrote:
> Currently, we have three options of the design of per-stream properties:
>
> 1. Have two structs for image format and bitstream format.
> Pros:
> Well structured. Easy to support uni-directional stream.
> Cons:
> Not all
Hi,
On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp wrote:
>
> Hi,
>
> > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream
> > + (context) within the device.
> > +
> > +\begin{lstlisting}
> > +struct virtio_video_stream_destroy {
> > +struct virtio_video_cmd_hdr hdr;
> > +};
>
Hi Dmitry,
On Tue, Apr 7, 2020 at 6:21 PM Dmitry Sepp wrote:
>
> Hi Alexandre, Keiichi,
>
> Thanks for the updates,
>
> On Montag, 6. April 2020 13:46:33 CEST Keiichi Watanabe wrote:
> >
> > It seems that you're suggesting a big struct where bitstream params,
> > image params and all controls
Hi Keiichi,
On Donnerstag, 9. April 2020 12:46:56 CEST Keiichi Watanabe wrote:
> Hi,
>
> On Tue, Apr 7, 2020 at 11:49 PM Dmitry Sepp
wrote:
> > Hi,
> >
> > > +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream
> > > + (context) within the device.
> > > +
> > > +\begin{lstlisting}
Hi Alexandre, Keiichi,
Thanks for the updates,
On Montag, 6. April 2020 13:46:33 CEST Keiichi Watanabe wrote:
>
> It seems that you're suggesting a big struct where bitstream params,
> image params and all controls are merged into, right?
> After rethinking, it makes sense to me.
> Originally,
Hi,
> +\item[VIRTIO_VIDEO_CMD_STREAM_DESTROY] Destroy a video stream
> + (context) within the device.
> +
> +\begin{lstlisting}
> +struct virtio_video_stream_destroy {
> +struct virtio_video_cmd_hdr hdr;
> +};
> +\end{lstlisting}
Let's add more strict description to stream_destroy, like
Hi,
Thanks Alex for sharing your idea.
On Mon, Apr 6, 2020 at 6:32 PM Alexandre Courbot wrote:
>
> On Mon, Mar 30, 2020 at 6:54 PM Dmitry Sepp
> wrote:
> >
> > Hi Keiichi,
> >
> > On Freitag, 27. März 2020 04:35:13 CEST Keiichi Watanabe wrote:
> > > Hi Dmitry,
> > >
> > > On Wed, Mar 25, 2020
On Mon, Mar 30, 2020 at 6:54 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Freitag, 27. März 2020 04:35:13 CEST Keiichi Watanabe wrote:
> > Hi Dmitry,
> >
> > On Wed, Mar 25, 2020 at 6:47 PM Dmitry Sepp
> wrote:
> > > Hi Keiichi,
> > >
> > > On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe
Hi Keiichi,
On Freitag, 27. März 2020 04:35:13 CEST Keiichi Watanabe wrote:
> Hi Dmitry,
>
> On Wed, Mar 25, 2020 at 6:47 PM Dmitry Sepp
wrote:
> > Hi Keiichi,
> >
> > On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe wrote:
> > > Hi,
> > >
> > > On Mon, Mar 23, 2020 at 10:28 PM Dmitry
Hi Dmitry,
On Wed, Mar 25, 2020 at 6:47 PM Dmitry Sepp wrote:
>
> Hi Keiichi,
>
> On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe wrote:
> > Hi,
> >
> > On Mon, Mar 23, 2020 at 10:28 PM Dmitry Sepp
> >
> > wrote:
> > > Hi Keiichi,
> > >
> > > On Montag, 23. März 2020 13:07:54 CET Keiichi
Hi Keiichi,
On Montag, 23. März 2020 16:48:14 CET Keiichi Watanabe wrote:
> Hi,
>
> On Mon, Mar 23, 2020 at 10:28 PM Dmitry Sepp
>
> wrote:
> > Hi Keiichi,
> >
> > On Montag, 23. März 2020 13:07:54 CET Keiichi Watanabe wrote:
> > > Hi everyone,
> > >
> > > I have implemented a virtio-video
Hi,
On Mon, Mar 23, 2020 at 10:28 PM Dmitry Sepp
wrote:
>
> Hi Keiichi,
>
> On Montag, 23. März 2020 13:07:54 CET Keiichi Watanabe wrote:
> > Hi everyone,
> >
> > I have implemented a virtio-video device following my v3 spec in
> > crosvm, which worked well together with Dmitry's driver [1].
Hi everyone,
I have implemented a virtio-video device following my v3 spec in
crosvm, which worked well together with Dmitry's driver [1]. I've
started preparing v4 proposal to address problems found while
implementing the driver and the devices.
Regarding v3 protocol, I'm thinking about how we
Hi Keiichi,
On Montag, 23. März 2020 13:07:54 CET Keiichi Watanabe wrote:
> Hi everyone,
>
> I have implemented a virtio-video device following my v3 spec in
> crosvm, which worked well together with Dmitry's driver [1]. I've
> started preparing v4 proposal to address problems found while
>
On Wed, Mar 4, 2020 at 3:43 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > > With a feature flag both driver and device can choose whenever they want
> > > support v1 or v2 or both. With a version config field this is more
> > > limited, the device can't decide to support both. So the bonus points
> >
Hi,
> > With a feature flag both driver and device can choose whenever they want
> > support v1 or v2 or both. With a version config field this is more
> > limited, the device can't decide to support both. So the bonus points
> > for a smooth transition go to the feature flags not the version
On Thu, Feb 27, 2020 at 6:29 PM Gerd Hoffmann wrote:
>
> Hi,
>
> > Dmitry's virtio-video driver
> > https://patchwork.linuxtv.org/patch/61717/.
> > Once it becomes fully functional, I'll post a list of possible
> > improvements of protocol.
>
> Cool. Actually implementing things can find
Hi,
> Dmitry's virtio-video driver
> https://patchwork.linuxtv.org/patch/61717/.
> Once it becomes fully functional, I'll post a list of possible
> improvements of protocol.
Cool. Actually implementing things can find design problems
in the protocol you didn't notice earlier.
> > >
Thanks for the review, Gerd.
Please see my replies inline below.
FYI, I'm implementing virtio-video device for ChromeOS that works with
Dmitry's virtio-video driver
https://patchwork.linuxtv.org/patch/61717/.
Once it becomes fully functional, I'll post a list of possible
improvements of protocol.
On Thu, Feb 06, 2020 at 07:20:57PM +0900, Keiichi Watanabe wrote:
> From: Dmitry Sepp
>
> The virtio video encoder device and decoder device provide functionalities to
> encode and decode video stream respectively.
> Though video encoder and decoder are provided as different devices, they use a
From: Dmitry Sepp
The virtio video encoder device and decoder device provide functionalities to
encode and decode video stream respectively.
Though video encoder and decoder are provided as different devices, they use a
same protocol.
Signed-off-by: Dmitry Sepp
Signed-off-by: Keiichi Watanabe
31 matches
Mail list logo
