Re: [Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-02 Thread Frediano Ziglio
> > On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > > SndWorker has been historically based on RedChannel, initial git > > commit > > has: > > struct SndWorker { > >  Channel base; > >  ... > > }; > > > I'd add a short note to the commit log explaining that this is only >

Re: [Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-01 Thread Jonathon Jongsma
On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > SndWorker has been historically based on RedChannel, initial git > commit > has: > struct SndWorker { >  Channel base; >  ... > }; I'd add a short note to the commit log explaining that this is only possible since we just

Re: [Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-01 Thread Christophe Fergeau
On Thu, Dec 01, 2016 at 11:47:15AM -0500, Frediano Ziglio wrote: > > > > On Thu, Dec 01, 2016 at 11:24:26AM +, Frediano Ziglio wrote: > > > @@ -1506,73 +1506,73 @@ static void remove_worker(SndWorker *worker) > > > > > > void snd_attach_playback(RedsState *reds, SpicePlaybackInstance *sin)

Re: [Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-01 Thread Frediano Ziglio
> > On Thu, Dec 01, 2016 at 11:24:26AM +, Frediano Ziglio wrote: > > @@ -1506,73 +1506,73 @@ static void remove_worker(SndWorker *worker) > > > > void snd_attach_playback(RedsState *reds, SpicePlaybackInstance *sin) > > { > > -SndWorker *playback_worker; > > -RedChannel *channel;

Re: [Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-01 Thread Christophe Fergeau
On Thu, Dec 01, 2016 at 11:24:26AM +, Frediano Ziglio wrote: > @@ -1506,73 +1506,73 @@ static void remove_worker(SndWorker *worker) > > void snd_attach_playback(RedsState *reds, SpicePlaybackInstance *sin) > { > -SndWorker *playback_worker; > -RedChannel *channel; > +SndChannel

[Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-01 Thread Frediano Ziglio
SndWorker has been historically based on RedChannel, initial git commit has: struct SndWorker { Channel base; ... }; Signed-off-by: Frediano Ziglio --- server/sound.c | 312 +- 1 file changed, 156 insertions(+), 156

[Spice-devel] [PATCH v4 04/17] sound: Rename SndWorker to SndChannel

2016-12-01 Thread Frediano Ziglio
SndWorker has been historically based on RedChannel, initial git commit has: struct SndWorker { Channel base; ... }; Signed-off-by: Frediano Ziglio --- server/sound.c | 312 +- 1 file changed, 156 insertions(+), 156