Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-09-08 Thread Frediano Ziglio
> > On Fri, Sep 08, 2017 at 05:10:06AM -0400, Frediano Ziglio wrote: > > > > > > On Fri, Aug 25, 2017 at 12:22:41PM -0400, Frediano Ziglio wrote: > > > > > > > > > > On Fri, 2017-08-25 at 05:39 -0400, Frediano Ziglio wrote: > > > > > > > > > > > > > > I had a similar comment in a different

Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-09-08 Thread Christophe Fergeau
On Fri, Sep 08, 2017 at 05:10:06AM -0400, Frediano Ziglio wrote: > > > > On Fri, Aug 25, 2017 at 12:22:41PM -0400, Frediano Ziglio wrote: > > > > > > > > On Fri, 2017-08-25 at 05:39 -0400, Frediano Ziglio wrote: > > > > > > > > > > > > I had a similar comment in a different patch during the

Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-09-08 Thread Frediano Ziglio
> > On Fri, Aug 25, 2017 at 12:22:41PM -0400, Frediano Ziglio wrote: > > > > > > On Fri, 2017-08-25 at 05:39 -0400, Frediano Ziglio wrote: > > > > > > > > > > I had a similar comment in a different patch during the last > > > > > version of > > > > > the series, but I personally would prefer a

Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-09-07 Thread Christophe Fergeau
On Fri, Aug 25, 2017 at 12:22:41PM -0400, Frediano Ziglio wrote: > > > > On Fri, 2017-08-25 at 05:39 -0400, Frediano Ziglio wrote: > > > > > > > > I had a similar comment in a different patch during the last > > > > version of > > > > the series, but I personally would prefer a signal to handle

Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-08-25 Thread Jonathon Jongsma
On Fri, 2017-08-25 at 05:39 -0400, Frediano Ziglio wrote: > > > > I had a similar comment in a different patch during the last > > version of > > the series, but I personally would prefer a signal to handle this > > situation. For example, StreamChannel could have a "supported- > > codecs" > >

Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-08-25 Thread Frediano Ziglio
> > I had a similar comment in a different patch during the last version of > the series, but I personally would prefer a signal to handle this > situation. For example, StreamChannel could have a "supported-codecs" > property, Then when a new client connected, or a client disconnected, > it

Re: [Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-08-24 Thread Jonathon Jongsma
I had a similar comment in a different patch during the last version of the series, but I personally would prefer a signal to handle this situation. For example, StreamChannel could have a "supported-codecs" property, Then when a new client connected, or a client disconnected, it would update this

[Spice-devel] [RFC PATCH spice-server v3 10/20] stream-channel: Allows to register callback to get new stream request

2017-08-23 Thread Frediano Ziglio
The channel needs to communicate when it receive a new stream request from the guest. Signed-off-by: Frediano Ziglio --- server/stream-channel.c | 12 server/stream-channel.h | 6 ++ 2 files changed, 18 insertions(+) diff --git a/server/stream-channel.c