Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

2018-09-04 Thread Victor Toso
On Tue, Sep 04, 2018 at 02:44:29PM +0200, Jakub Janku wrote: > > > > > +if (err) { > > > > > +g_printerr("Invalid arguments, %s\n", err->message); > > > > > > > > We don't use g_printerr() or any g_log() in this code > > > > yet. > > > > > > I think I copied it from the vdagent.c where

Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

2018-09-04 Thread Jakub Janku
On Tue, Sep 4, 2018 at 7:02 AM Victor Toso wrote: > > Hi, > > On Mon, Sep 03, 2018 at 06:06:01PM +0200, Jakub Janku wrote: > > Hi, > > > > > I think that after "vdagentd: use GMainLoop" patch, we should > > > also include glib's command line options. > > > > Not sure what you are referring to

Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

2018-09-03 Thread Victor Toso
Hi, On Mon, Sep 03, 2018 at 06:06:01PM +0200, Jakub Janku wrote: > Hi, > > > I think that after "vdagentd: use GMainLoop" patch, we should > > also include glib's command line options. > > Not sure what you are referring to here. > GLib uses environment variables instead of command line >

Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

2018-09-03 Thread Jakub Janku
Hi, On Tue, Aug 28, 2018 at 7:16 AM Victor Toso wrote: > > Hi, > > Just for reference, the output of spice-vdagentd -h before was: > > | $ spice-vdagentd -h > | Usage: spice-vdagentd [OPTIONS] > | > | Spice guest agent daemon, version 0.17.0. > | > | Options: > | -h print

Re: [Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

2018-08-27 Thread Victor Toso
Hi, Just for reference, the output of spice-vdagentd -h before was: | $ spice-vdagentd -h | Usage: spice-vdagentd [OPTIONS] | | Spice guest agent daemon, version 0.17.0. | | Options: | -h print this text | -d log debug messages (use twice for extra info) |

[Spice-devel] [RFC spice-vdagent 01/18] vdagentd: parse argv using GLib

2018-08-14 Thread Jakub Janků
All command line options now have long names as they are required by GLib. Change types of some global variables that hold the options: - const char * --> gchar * - int --> gboolean Define DEFAULT_UINPUT_DEVICE as "/dev/uinput", since there's already DEFAULT_VIRTIO_PORT_PATH,