[Spice-devel] [spice-common PATCH] rect.h: rename variable small to sml

2012-05-07 Thread Uri Lublin
Apparently when compiling spice-gtk with mingw, small is defined as char. I found the following in rpcndr.h under mingw/include (not sure what includes it) #define small char This fixes the following compilation errer: In file included from ../spice-common/common/canvas_base.c:36:0,

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable small to sml

2012-05-07 Thread Hans de Goede
Hi, Hmm I don't really like the name sml, but I cannot come up with anything better, so: ACK. Regards, Hans On 05/07/2012 09:41 AM, Uri Lublin wrote: Apparently when compiling spice-gtk with mingw, small is defined as char. I found the following in rpcndr.h under mingw/include (not sure

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable small to sml

2012-05-07 Thread Uri Lublin
On 05/07/2012 11:22 AM, Yaniv Kaul wrote: - Original Message - Hi, Hmm I don't really like the name sml, but I cannot come up with anything better, so: ACK. small_rect and big_rect? Y. Fine, I'll send another patch. thanks, Uri. ___