Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Frediano Ziglio
> > On Wed, May 31, 2017 at 08:24:14AM -0400, Frediano Ziglio wrote: > > I think is the same of using --spice-color-depth=16 option. > > Ah if there is such an option, definitely. > > > However it seems all Linux and Windows from 7 machines do not support 16 > > bit screen that much and I'm not

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Christophe Fergeau
On Wed, May 31, 2017 at 08:24:14AM -0400, Frediano Ziglio wrote: > I think is the same of using --spice-color-depth=16 option. Ah if there is such an option, definitely. > However it seems all Linux and Windows from 7 machines do not support 16 > bit screen that much and I'm not able to configure

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Frediano Ziglio
> > On Wed, May 31, 2017 at 06:13:01AM -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > 'raw' data > > > > > > > typo, thanks > > > > > On Wed, 2017-05-31 at 09:43 +0100, Frediano Ziglio wrote: > > > > data and cursor->data contains the same data (see the memcpy > > > > above) but da

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Frediano Ziglio
> > On Wed, 2017-05-31 at 06:13 -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > 'raw' data > > > > > > > typo, thanks > > > > > On Wed, 2017-05-31 at 09:43 +0100, Frediano Ziglio wrote: > > > > data and cursor->data contains the same data (see the memcpy > > > > above) but data is n

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Christophe Fergeau
On Wed, May 31, 2017 at 06:13:01AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > 'raw' data > > > > typo, thanks > > > On Wed, 2017-05-31 at 09:43 +0100, Frediano Ziglio wrote: > > > data and cursor->data contains the same data (see the memcpy > > > above) but data is not aligned to uint32

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Pavel Grunt
On Wed, 2017-05-31 at 06:13 -0400, Frediano Ziglio wrote: > > > > Hi, > > > > 'raw' data > > > > typo, thanks > > > On Wed, 2017-05-31 at 09:43 +0100, Frediano Ziglio wrote: > > > data and cursor->data contains the same data (see the memcpy > > > above) but data is not aligned to uint32_t and

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Frediano Ziglio
> > Hi, > > 'raw' data > typo, thanks > On Wed, 2017-05-31 at 09:43 +0100, Frediano Ziglio wrote: > > data and cursor->data contains the same data (see the memcpy > > above) but data is not aligned to uint32_t and require also > > additional casts. Using cursor->data avoid these issues. > > >

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Pavel Grunt
Hi, 'raw' data On Wed, 2017-05-31 at 09:43 +0100, Frediano Ziglio wrote: > data and cursor->data contains the same data (see the memcpy > above) but data is not aligned to uint32_t and require also > additional casts. Using cursor->data avoid these issues. > > Signed-off-by: Frediano Ziglio > -

Re: [Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Marc-André Lureau
- Original Message - > data and cursor->data contains the same data (see the memcpy > above) but data is not aligned to uint32_t and require also > additional casts. Using cursor->data avoid these issues. > > Signed-off-by: Frediano Ziglio looks good, ack > --- > src/channel-cursor.c

[Spice-devel] [spice-gtk] Use cursor->data instead of row data

2017-05-31 Thread Frediano Ziglio
data and cursor->data contains the same data (see the memcpy above) but data is not aligned to uint32_t and require also additional casts. Using cursor->data avoid these issues. Signed-off-by: Frediano Ziglio --- src/channel-cursor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --