Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-03-04 Thread Christophe Fergeau
On Mon, Feb 25, 2019 at 04:07:03PM +0200, Yuri Benditovich wrote: > On Fri, Feb 22, 2019 at 2:06 PM Christophe Fergeau > wrote: > > I don't think we should have a hard limit on the number of lines in a > > patch, however there should be a maximum of 1 logical change per commit, > > see > >

Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-26 Thread Frediano Ziglio
> On Fri, Feb 22, 2019 at 2:06 PM Christophe Fergeau > wrote: > > > > Hi, > > > > On Thu, Feb 21, 2019 at 09:37:06AM +0200, Yuri Benditovich wrote: > > > On Wed, Feb 20, 2019 at 6:03 PM Christophe Fergeau > > > wrote: > > > > > static SpiceUsbDevice* > > > > >

Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-25 Thread Yuri Benditovich
On Fri, Feb 22, 2019 at 2:06 PM Christophe Fergeau wrote: > > Hi, > > On Thu, Feb 21, 2019 at 09:37:06AM +0200, Yuri Benditovich wrote: > > On Wed, Feb 20, 2019 at 6:03 PM Christophe Fergeau > > wrote: > > > > static SpiceUsbDevice* > > > >

Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-22 Thread Christophe Fergeau
Hi, On Thu, Feb 21, 2019 at 09:37:06AM +0200, Yuri Benditovich wrote: > On Wed, Feb 20, 2019 at 6:03 PM Christophe Fergeau > wrote: > > > static SpiceUsbDevice* > > > spice_usb_device_manager_find_device(SpiceUsbDeviceManager *self, > > > const int bus,

Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-20 Thread Yuri Benditovich
On Wed, Feb 20, 2019 at 6:03 PM Christophe Fergeau wrote: > > Hey, > > Sorry, it took a bit of time to review, but this patch is sticking a lot > of changes together, splitting such patches in multiple smaller ones > really help to get speedier reviews (and actually, probably improves > these

Re: [Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-20 Thread Christophe Fergeau
Hey, Sorry, it took a bit of time to review, but this patch is sticking a lot of changes together, splitting such patches in multiple smaller ones really help to get speedier reviews (and actually, probably improves these reviews, there are some things I would have missed if I did not split this

[Spice-devel] [spice-gtk] usb-redir: use persistent libusb device on Windows

2019-02-11 Thread Yuri Benditovich
Discard unneeded GUDev simulation and use persistent libusb device pointer in SpiceUsbDevice on Windows as we do on Linux. This removes significant part of differences between Linux and Windows code. GUDevClient in win-usb-dev.c now maintains list of libusb_device pointers and passes new and