Re: [Spice-devel] [spice-gtk PATCH v6 2/2] channel-usbredir: drop isoc packets on low bandwidth

2015-10-30 Thread Victor Toso
Hi, On Fri, Oct 23, 2015 at 03:37:47PM +0200, Hans de Goede wrote: > Ack, I believe the usbredir patch is ready, feel free to push that > with my suggested doc change, then do a follow up patch to bump > the version in usbredirproto.h and configure.ac to 0.7.1 and > update the Changelog file with

Re: [Spice-devel] [spice-gtk PATCH v6 2/2] channel-usbredir: drop isoc packets on low bandwidth

2015-10-23 Thread Hans de Goede
Hi, On 10/23/2015 10:59 AM, Fabiano FidĂȘncio wrote: On Fri, Oct 23, 2015 at 9:53 AM, Victor Toso wrote: When channel wants to send much more data then the wire can handle, the queue grows fast. This patch does not limit the queue growth but introduces an internal API to check if queue size is

Re: [Spice-devel] [spice-gtk PATCH v6 2/2] channel-usbredir: drop isoc packets on low bandwidth

2015-10-23 Thread Victor Toso
Hi, On Fri, Oct 23, 2015 at 10:59:23AM +0200, Fabiano FidĂȘncio wrote: > I didn't go through the code and I will leave it for Hans. > But as you're depending on a new added API on usbredir would be nice > if you could also bump the dep version on configure.ac and then use it > conditionally on spic

Re: [Spice-devel] [spice-gtk PATCH v6 2/2] channel-usbredir: drop isoc packets on low bandwidth

2015-10-23 Thread Fabiano FidĂȘncio
On Fri, Oct 23, 2015 at 9:53 AM, Victor Toso wrote: > When channel wants to send much more data then the wire can handle, the > queue grows fast. This patch does not limit the queue growth but > introduces an internal API to check if queue size is too big. > > This internal API is used in usbredir

[Spice-devel] [spice-gtk PATCH v6 2/2] channel-usbredir: drop isoc packets on low bandwidth

2015-10-23 Thread Victor Toso
When channel wants to send much more data then the wire can handle, the queue grows fast. This patch does not limit the queue growth but introduces an internal API to check if queue size is too big. This internal API is used in usbredir_buffered_output_size_callback which is called before any isoc