Re: [Spice-devel] [spice-gtk PATCHv2] usb: Add info message when USB dialog is empty

2012-09-29 Thread Hans de Goede
Hi, On 09/28/2012 08:48 PM, Christophe Fergeau wrote: On Fri, Sep 28, 2012 at 08:08:19PM +0200, Hans de Goede wrote: Sorry to be a PITA, but I'm not really happy with making it a local variable, that makes the code more complicated (IMHO), for saving just 4 bytes of ram. Likely the extra

Re: [Spice-devel] [spice-gtk PATCHv2] usb: Add info message when USB dialog is empty

2012-09-28 Thread Christophe Fergeau
On Fri, Sep 28, 2012 at 12:56:00PM +0200, Christophe Fergeau wrote: @@ -515,7 +537,6 @@ static void device_removed_cb(SpiceUsbDeviceManager *manager, gtk_container_foreach(GTK_CONTAINER(self), destroy_widget_by_usb_device, device); -

Re: [Spice-devel] [spice-gtk PATCHv2] usb: Add info message when USB dialog is empty

2012-09-28 Thread Hans de Goede
Hi, On 09/28/2012 12:56 PM, Christophe Fergeau wrote: From rh bug #804187: « The redirection dialog can feel a bit strange when there is no device to redirect. It could be useful to provide a help message indicating that there is no device to redirect yet, and that the user can insert a USB

Re: [Spice-devel] [spice-gtk PATCHv2] usb: Add info message when USB dialog is empty

2012-09-28 Thread Christophe Fergeau
On Fri, Sep 28, 2012 at 08:08:19PM +0200, Hans de Goede wrote: On 09/28/2012 12:56 PM, Christophe Fergeau wrote: From rh bug #804187: « The redirection dialog can feel a bit strange when there is no device to redirect. It could be useful to provide a help message indicating that there is