Re: [Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-08 Thread Marc-André Lureau
Hi On Tue, May 8, 2012 at 12:51 PM, Uri Lublin wrote: >>> Perhaps the header doesn't need to be conditionally excluded from the >>> list of files. > > > It is only used for Windows. > Is it simpler to always add it and only use it for Windows compilation ? >>> Also if it's not in the public API,

Re: [Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-08 Thread Uri Lublin
Hi Marc-Andre, Thanks for the quick and helpful review. Some comments/questions (additional to Arnon's) are below. On 05/08/2012 11:55 AM, Arnon Gilboa wrote: Marc-André Lureau wrote: Hi On Mon, May 7, 2012 at 3:15 PM, Uri Lublin wrote: +WIN_USB_HDRS =

Re: [Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-08 Thread Arnon Gilboa
Thanks for the review. Great comments which surely help a GObject/Gtk-dummy like myself ;) See below. Marc-André Lureau wrote: Hi On Mon, May 7, 2012 at 3:15 PM, Uri Lublin wrote: From: Arnon Gilboa With this patch usb-device-manager can work with little change on windows too. -add ueve

Re: [Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-07 Thread Marc-André Lureau
Hi On Mon, May 7, 2012 at 3:15 PM, Uri Lublin wrote: > From: Arnon Gilboa > > With this patch usb-device-manager can work with little change > on windows too. > > -add uevent signal based on WM_DEVICECHANGE > -add spice_usb_device_manager_set_window for setting winproc >   (which is needed for e

[Spice-devel] [spice-gtk Win32 PATCH 3/7] Windows: add win-usb-dev.[ch]: implement GUdevDevice & GUdevClient

2012-05-07 Thread Uri Lublin
From: Arnon Gilboa With this patch usb-device-manager can work with little change on windows too. -add uevent signal based on WM_DEVICECHANGE -add spice_usb_device_manager_set_window for setting winproc (which is needed for event registration) Modified-by: Uri Lublin --- gtk/Makefile.am