Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-24 Thread Marc-André Lureau
Hi - Mensaje original - > What's your point ? This line can be removed from the log message ? > Before gudev was part of USBREDIR, now it has it's own variables. Before it was Linux only. Now the gudev check isn't needed for Windows. > > I guess you could do the check only on non-win32.

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-24 Thread Uri Lublin
On 05/22/2012 01:37 AM, Marc-André Lureau wrote: Hi On Sun, May 20, 2012 at 6:34 PM, Uri Lublin wrote: For windows GUDEV is not required - GUDEV is alwasy checked as part of USBREDIR, and fails if USBREDIR but no GUDEV on non-windows. misc spelling alwasy/always Yes. - Added GUDEV env-va

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-22 Thread Hans de Goede
Hi, What Marc-André said :) Regards, Hans On 05/20/2012 06:34 PM, Uri Lublin wrote: For windows GUDEV is not required - GUDEV is alwasy checked as part of USBREDIR, and fails if USBREDIR but no GUDEV on non-windows. - Added GUDEV env-variables in gtk/Makefile.am --- configure.ac|

Re: [Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-21 Thread Marc-André Lureau
Hi On Sun, May 20, 2012 at 6:34 PM, Uri Lublin wrote: > For windows GUDEV is not required > > - GUDEV is alwasy checked as part of USBREDIR, and fails >  if USBREDIR but no GUDEV on non-windows. misc spelling alwasy/always > - Added GUDEV env-variables in gtk/Makefile.am It's a Makefile variab

[Spice-devel] [spice-gtk Win32 v2 PATCH 2/5] Windows mingw: usb: configure.ac: do not require GUDEV for USBREDIR

2012-05-20 Thread Uri Lublin
For windows GUDEV is not required - GUDEV is alwasy checked as part of USBREDIR, and fails if USBREDIR but no GUDEV on non-windows. - Added GUDEV env-variables in gtk/Makefile.am --- configure.ac| 20 +++- gtk/Makefile.am |2 ++ 2 files changed, 21 insertions(+), 1 del