Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-02-11 Thread Victor Toso
On Mon, Feb 11, 2019 at 11:19:02AM +0100, Jakub Janku wrote: > On Mon, Feb 11, 2019 at 10:30 AM Victor Toso wrote: > > > > Hi, > > > > On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote: > > > ping? > > > > Should be fixed by: > > You can double-check with James to be sure, but I don't

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-02-11 Thread Jakub Janku
On Mon, Feb 11, 2019 at 10:30 AM Victor Toso wrote: > > Hi, > > On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote: > > ping? > > Should be fixed by: You can double-check with James to be sure, but I don't think that's true. If you look at the logs ( https://termbin.com/40un ), there's

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-02-11 Thread Victor Toso
Hi, On Mon, Feb 11, 2019 at 10:12:42AM +0100, Jakub Janku wrote: > ping? Should be fixed by: commit 214f8fd969127c41a7d53def196118ee0549a411 Author: Jakub Janků Date: Sun Jan 27 18:14:20 2019 +0100 clipboard: don't request targets without owner on X11 On X11, if the owner in

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-02-11 Thread Jakub Janku
ping? On Mon, Jan 28, 2019 at 10:29 AM Jakub Janku wrote: > > Hi, > > I tried to fix this bug in a less radical way, but my patch unfortunately did > not cover all the cases. > > I obtained some logs from James Harvey which make the situation clearer - it > can be found here: >

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-28 Thread Jakub Janku
Hi, I tried to fix this bug in a less radical way, but my patch unfortunately did not cover all the cases. I obtained some logs from James Harvey which make the situation clearer - it can be found here: https://termbin.com/40un So I'll try to explain what's happening: James uses KDE which has a

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-15 Thread Victor Toso
Hi, On Tue, Jan 15, 2019 at 01:40:48AM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 15, 2019 at 12:40 AM Jakub Janku wrote: > > > > Hi, > > > > On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote: >

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-14 Thread james harvey
On Mon, Jan 14, 2019 at 3:40 PM Jakub Janku wrote: > > > > > > Related: https://gitlab.freedesktop.org/spice/win32/vd_agent/issues/6 > > > Related: https://gitlab.freedesktop.org/spice/linux/vd_agent/issues/9 > > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1594876 > > > > > > Changed

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-14 Thread Marc-André Lureau
Hi On Tue, Jan 15, 2019 at 12:40 AM Jakub Janku wrote: > > Hi, > > On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau > wrote: > > > > Hi > > > > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote: > > > > > > From: Victor Toso > > > > > > On X11, the release-grab message might end up clearing

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-14 Thread Jakub Janku
Hi, On Mon, Jan 14, 2019 at 1:41 PM Marc-André Lureau wrote: > > Hi > > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote: > > > > From: Victor Toso > > > > On X11, the release-grab message might end up clearing the > > GtkClipboard which triggers the owner-changed callback having the > >

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-14 Thread Victor Toso
Hi, On Mon, Jan 14, 2019 at 04:40:35PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote: > > > > From: Victor Toso > > > > On X11, the release-grab message might end up clearing the > > GtkClipboard which triggers the owner-changed callback having the

Re: [Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-14 Thread Marc-André Lureau
Hi On Mon, Jan 14, 2019 at 4:34 PM Victor Toso wrote: > > From: Victor Toso > > On X11, the release-grab message might end up clearing the > GtkClipboard which triggers the owner-changed callback having the > event owner as NULL. > > We should not be calling gtk_clipboard_request_targets() in

[Spice-devel] [spice-gtk v4 2/2] gtk-session: clipboard: x11: owner-change improvement

2019-01-14 Thread Victor Toso
From: Victor Toso On X11, the release-grab message might end up clearing the GtkClipboard which triggers the owner-changed callback having the event owner as NULL. We should not be calling gtk_clipboard_request_targets() in this situation as is prone to errors as the intention here is request