Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-20 Thread Christophe Fergeau
On Wed, Jan 18, 2017 at 03:25:09AM -0500, Frediano Ziglio wrote: > > > > Hey, > > > > On Fri, Jan 13, 2017 at 05:47:13AM -0500, Frediano Ziglio wrote: > > > You are right. Surprisingly if the network queue was full the old code > > > just ignored the request not sending/setting any command. > >

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-18 Thread Frediano Ziglio
> > Hey, > > On Fri, Jan 13, 2017 at 05:47:13AM -0500, Frediano Ziglio wrote: > > You are right. Surprisingly if the network queue was full the old code > > just ignored the request not sending/setting any command. > > After your code you don't schedule a send any volume/mute changes. > > Maybe

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-16 Thread Christophe Fergeau
Hey, On Fri, Jan 13, 2017 at 05:47:13AM -0500, Frediano Ziglio wrote: > You are right. Surprisingly if the network queue was full the old code > just ignored the request not sending/setting any command. > After your code you don't schedule a send any volume/mute changes. > Maybe nothing change as

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-13 Thread Frediano Ziglio
> > On Wed, Jan 11, 2017 at 09:43:48AM -0500, Frediano Ziglio wrote: > > > > > > snd_set_command()/snd_send() are higher level methods which take care of > > > scheduling calls to the corresponding snd_*_send_*() methods when > > > appropriate. This commit switches a few direct snd_*_send_*()

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-13 Thread Christophe Fergeau
On Wed, Jan 11, 2017 at 09:43:48AM -0500, Frediano Ziglio wrote: > > > > snd_set_command()/snd_send() are higher level methods which take care of > > scheduling calls to the corresponding snd_*_send_*() methods when > > appropriate. This commit switches a few direct snd_*_send_*() calls to > >

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-11 Thread Frediano Ziglio
> > snd_set_command()/snd_send() are higher level methods which take care of > scheduling calls to the corresponding snd_*_send_*() methods when > appropriate. This commit switches a few direct snd_*_send_*() calls to > snd_set_command()/snd_send(). > > Based on a patch from Frediano Ziglio

[Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

2017-01-11 Thread Christophe Fergeau
snd_set_command()/snd_send() are higher level methods which take care of scheduling calls to the corresponding snd_*_send_*() methods when appropriate. This commit switches a few direct snd_*_send_*() calls to snd_set_command()/snd_send(). Based on a patch from Frediano Ziglio