Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-09 Thread Uri Lublin
On 05/09/2012 01:07 PM, Christophe Fergeau wrote: Hey, On Mon, May 07, 2012 at 04:30:22PM +0300, Uri Lublin wrote: On 05/03/2012 07:09 PM, Christophe Fergeau wrote: On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: From: Arnon Gilboa no strtok_r (reentrent) available, so use strtok

Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-09 Thread Christophe Fergeau
Hey, On Mon, May 07, 2012 at 04:30:22PM +0300, Uri Lublin wrote: > On 05/03/2012 07:09 PM, Christophe Fergeau wrote: > >On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: > >>From: Arnon Gilboa > >> > >>no strtok_r (reentrent) available, so use strtok instead. > >Wouldn't it be safer to u

Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-07 Thread Uri Lublin
On 05/03/2012 07:09 PM, Christophe Fergeau wrote: On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: From: Arnon Gilboa no strtok_r (reentrent) available, so use strtok instead. Wouldn't it be safer to use strtok_s? Any application using threads and strtok and libusbredirparser could

Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-03 Thread Hans de Goede
Hi, On 05/03/2012 06:09 PM, Christophe Fergeau wrote: On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: From: Arnon Gilboa no strtok_r (reentrent) available, so use strtok instead. Wouldn't it be safer to use strtok_s? Any application using threads and strtok and libusbredirparser

Re: [Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-03 Thread Christophe Fergeau
On Thu, May 03, 2012 at 06:04:39PM +0300, Uri Lublin wrote: > From: Arnon Gilboa > > no strtok_r (reentrent) available, so use strtok instead. Wouldn't it be safer to use strtok_s? Any application using threads and strtok and libusbredirparser could get issues with this change no? > > Modified

[Spice-devel] [usbredir PATCH 6/6] usbredirfilter: fix filter parsing for windows (mingw)

2012-05-03 Thread Uri Lublin
From: Arnon Gilboa no strtok_r (reentrent) available, so use strtok instead. Modified-by: Uri Lublin --- usbredirparser/usbredirfilter.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/usbredirparser/usbredirfilter.c b/usbredirparser/usbredirfilter.c in