Re: [Spice-devel] Review of the C++ patches

2020-06-15 Thread Frediano Ziglio
> > commit 43c6bf91b7c53ee9f93f7ea1cead5bba94c61f88 > Author: Frediano Ziglio > Date: Thu Mar 5 13:01:27 2020 + > > reds: Remove a weak pointer usage > > RedCharDevice can all be removed just calling unref, beside > the agent that needs special threatment. > > Signed-off-by:

Re: [Spice-devel] Review of the C++ patches

2020-06-15 Thread Frediano Ziglio
> > commit 61affed2a2e36b59e6935e608d7d80242f976c7e > Author: Frediano Ziglio > Date: Mon May 20 16:49:17 2019 +0100 > > red-channel-client: Better private initialisation > > Initialise RedChannelClientPrivate fields from the new > constructor instead from RedChannelClient. > Also

Re: [Spice-devel] Review of the C++ patches

2020-06-15 Thread Frediano Ziglio
> commit 7b3637417062fe657c0bf1fced5ef59a489dbdc3 > Author: Frediano Ziglio > Date: Mon Mar 9 10:04:24 2020 + > > Adjust some warnings > > Remove -Werror and add -fpermissive, this will allow to compile C code with > a GNU C++ compiler. > > Ignore warnings as our code use some

Re: [Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
commit 75679dc95d450173319f462b25f267cb3025778f Author: Frediano Ziglio Date: Wed Apr 1 20:43:04 2020 +0100 dispatcher: Use IS-A relationship for Dispatcher hierarchy Signed-off-by: Frediano Ziglio This patch adds class inheritance to the `Dispatcher` to avoid the usage of the `parent`

Re: [Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
commit 2023bb376713a39c47607f2698ad0f5e43ddf994 Author: Frediano Ziglio Date: Mon May 20 16:23:54 2019 +0100 red-channel-client: Remove "self" It was left unchanged to reduce diff. Signed-off-by: Frediano Ziglio This patch removes the historical usage of `self`, and uses instead the

Re: [Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
commit bea4ad66b9603f4d733da42ea0ad28cb7cf8d1de Author: Frediano Ziglio Date: Thu May 30 06:33:16 2019 +0100 char-device: Remove pool handling Memory pool handling does not give much but make code more complex. Current implementation tends to only increasing buffer sizes leading to

[Spice-devel] Review of the C++ patches

2020-06-08 Thread Kevin Pouget
Hello spice-devel I worked on the review of Frediano's C++ patches during the last weeks, I tried to understand the gist of the commits and summarize it in the review message. It's not an in-depth review, and I only spotted minor details. A few patches are not acked, mostly because they were too