Re: [Spice-devel] SPICE: changing the merge rules - a proposal

Hi On Tue, May 19, 2020 at 11:10 AM Frediano Ziglio wrote: > > > > Hi, > >the community around the SPICE project always tried to follow one > > fundamental, implicit rule for accepting code contributions to the > > project: every merge request (beside trivial patches) should be reviewed > >

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

> > Hi, >the community around the SPICE project always tried to follow one > fundamental, implicit rule for accepting code contributions to the > project: every merge request (beside trivial patches) should be reviewed > and acked at least by one before getting merged. > While everyone agrees

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

Hi, The x11spice project is another example: we have only 4 contributors from the beginning of the year (and a single contributor holding 70% of the commits) and the reviews on the gitlab merge requests have been provided by two people only, each one reviewing the merge

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

Hi, On 18/05/20 12:56, Daniel P. Berrangé wrote: On Fri, May 15, 2020 at 07:05:50PM +0200, Francesco Giudici wrote: Hi, the community around the SPICE project always tried to follow one fundamental, implicit rule for accepting code contributions to the project: every merge request (beside

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

On Fri, May 15, 2020 at 07:05:50PM +0200, Francesco Giudici wrote: > Hi, > the community around the SPICE project always tried to follow one > fundamental, implicit rule for accepting code contributions to the project: > every merge request (beside trivial patches) should be reviewed and acked

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

Hi, On 15/05/20 23:58, Marc-André Lureau wrote: Hi On Fri, May 15, 2020 at 7:06 PM Francesco Giudici > wrote: Hi,    the community around the SPICE project always tried to follow one fundamental, implicit rule for accepting code contributions to the

Re: [Spice-devel] SPICE: changing the merge rules - a proposal

Hi On Fri, May 15, 2020 at 7:06 PM Francesco Giudici wrote: > Hi, >the community around the SPICE project always tried to follow one > fundamental, implicit rule for accepting code contributions to the > project: every merge request (beside trivial patches) should be reviewed > and acked at

[Spice-devel] SPICE: changing the merge rules - a proposal

Hi, the community around the SPICE project always tried to follow one fundamental, implicit rule for accepting code contributions to the project: every merge request (beside trivial patches) should be reviewed and acked at least by one before getting merged. While everyone agrees with this