Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Hans de Goede
Hi, On 08/23/2013 10:25 PM, Marc-André Lureau wrote: Convert line endings from/to LF/CRLF, in utf8. --- gtk/spice-util-priv.h | 2 + gtk/spice-util.c | 122 ++ 2 files changed, 124 insertions(+) diff --git a/gtk/spice-util-priv.h

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Marc-André Lureau
On Sat, Aug 24, 2013 at 12:20 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 08/23/2013 10:25 PM, Marc-André Lureau wrote: Convert line endings from/to LF/CRLF, in utf8. --- gtk/spice-util-priv.h | 2 + gtk/spice-util.c | 122

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Hans de Goede
Hi, On 08/24/2013 02:17 PM, Marc-André Lureau wrote: On Sat, Aug 24, 2013 at 12:20 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 08/23/2013 10:25 PM, Marc-André Lureau wrote: Convert line endings from/to LF/CRLF, in utf8. --- gtk/spice-util-priv.h | 2 + gtk/spice-util.c

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Hans de Goede
Hi, On 08/24/2013 02:17 PM, Marc-André Lureau wrote: snip + +if (!g_utf8_validate(str, len, NULL)) { +g_set_error_literal(error, G_CONVERT_ERROR, +G_CONVERT_ERROR_ILLEGAL_SEQUENCE, +Invalid byte sequence in conversion input);

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Marc-André Lureau
- Mensaje original - Hi, On 08/24/2013 02:17 PM, Marc-André Lureau wrote: snip + +if (!g_utf8_validate(str, len, NULL)) { +g_set_error_literal(error, G_CONVERT_ERROR, +G_CONVERT_ERROR_ILLEGAL_SEQUENCE, +

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Hans de Goede
Hi, On 08/24/2013 02:32 PM, Marc-André Lureau wrote: - Mensaje original - Hi, On 08/24/2013 02:17 PM, Marc-André Lureau wrote: snip + +if (!g_utf8_validate(str, len, NULL)) { +g_set_error_literal(error, G_CONVERT_ERROR, +

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Marc-André Lureau
- Mensaje original - Hi, On 08/24/2013 02:32 PM, Marc-André Lureau wrote: - Mensaje original - Hi, On 08/24/2013 02:17 PM, Marc-André Lureau wrote: snip + +if (!g_utf8_validate(str, len, NULL)) { +g_set_error_literal(error, G_CONVERT_ERROR,

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-24 Thread Marc-André Lureau
- Mensaje original - Hi, On 08/24/2013 02:56 PM, Marc-André Lureau wrote: - Mensaje original - Hi, On 08/24/2013 02:32 PM, Marc-André Lureau wrote: - Mensaje original - Hi, On 08/24/2013 02:17 PM, Marc-André Lureau wrote: snip + +

Re: [Spice-devel] [PATCH spice-gtk 3/4] util: add unix2dos and dos2unix

2013-08-23 Thread Marc-André Lureau
On Fri, Aug 23, 2013 at 10:25 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: else if (str[len] == 0) +len -= 1; + I added len 0 condition here. -- Marc-André Lureau ___ Spice-devel mailing list