Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-22 Thread Christophe de Dinechin
Following the explanations, Acked-by: Christophe de Dinechin (“preparation” patch, uppercase, etc can all be followups) > On 21 Mar 2018, at 18:07, Frediano Ziglio wrote: > >>> >>> On 20 Mar 2018, at 12:28, Frediano Ziglio

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-22 Thread Christophe de Dinechin
> On 21 Mar 2018, at 18:07, Frediano Ziglio wrote: > >>> >>> On 20 Mar 2018, at 12:28, Frediano Ziglio wrote: >>> Looks good, with minor nits. > On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > >

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-21 Thread Frediano Ziglio
> > > On 20 Mar 2018, at 12:28, Frediano Ziglio wrote: > > > >> > >> Looks good, with minor nits. > >> > >>> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > >>> > >>> Handle capabilities from guest device. > >>> Send capability to the guest when

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-21 Thread Christophe de Dinechin
> On 20 Mar 2018, at 12:28, Frediano Ziglio wrote: > >> >> Looks good, with minor nits. >> >>> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: >>> >>> Handle capabilities from guest device. >>> Send capability to the guest when device is opened. >>>

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-21 Thread Frediano Ziglio
> > On 03/19/2018 06:46 PM, Frediano Ziglio wrote: > > Handle capabilities from guest device. > > Send capability to the guest when device is opened. > > Currently there's no capabilities set on the message sent. > > On the tests we need to discard the capability message before > > reading the

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-21 Thread Frediano Ziglio
> > On 03/20/2018 01:28 PM, Frediano Ziglio wrote: > >> > >> Looks good, with minor nits. > >> > >>> On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > >>> > >>> Handle capabilities from guest device. > >>> Send capability to the guest when device is opened. > >>> Currently

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-20 Thread Uri Lublin
On 03/19/2018 06:46 PM, Frediano Ziglio wrote: Handle capabilities from guest device. Send capability to the guest when device is opened. Currently there's no capabilities set on the message sent. On the tests we need to discard the capability message before reading the error. Signed-off-by:

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-20 Thread Uri Lublin
On 03/20/2018 01:28 PM, Frediano Ziglio wrote: Looks good, with minor nits. On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: Handle capabilities from guest device. Send capability to the guest when device is opened. Currently there's no capabilities set on the message

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-20 Thread Frediano Ziglio
> > Looks good, with minor nits. > > > On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > > > > Handle capabilities from guest device. > > Send capability to the guest when device is opened. > > Currently there's no capabilities set on the message sent. > > On the tests we

Re: [Spice-devel] [PATCH spice-server 2/2] stream-device: Handle capabilities

2018-03-20 Thread Christophe de Dinechin
Looks good, with minor nits. > On 19 Mar 2018, at 17:46, Frediano Ziglio wrote: > > Handle capabilities from guest device. > Send capability to the guest when device is opened. > Currently there's no capabilities set on the message sent. > On the tests we need to discard