Re: [Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

2018-02-23 Thread Christophe de Dinechin
> On 23 Feb 2018, at 11:47, Christophe Fergeau wrote: > > On Fri, Feb 23, 2018 at 11:42:42AM +0100, Christophe de Dinechin wrote: >> The suggestion about nacking commits that don’t have a long log seems a bit >> extreme for one-line cleanups. > > This patch is not a

Re: [Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

2018-02-23 Thread Christophe Fergeau
On Fri, Feb 23, 2018 at 11:42:42AM +0100, Christophe de Dinechin wrote: > The suggestion about nacking commits that don’t have a long log seems a bit > extreme for one-line cleanups. This patch is not a one-line cleanup, of course I would not blindly nack trivial/self explanatory patches, but I

Re: [Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

2018-02-23 Thread Christophe de Dinechin
> On 23 Feb 2018, at 10:58, Christophe Fergeau wrote: > > On Fri, Feb 23, 2018 at 08:18:52AM +0100, Christophe de Dinechin wrote: >> >>> On Feb 23, 2018, at 8:07 AM, Frediano Ziglio wrote: >>> >>> From: Christophe de Dinechin

Re: [Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

2018-02-23 Thread Christophe Fergeau
On Fri, Feb 23, 2018 at 08:18:52AM +0100, Christophe de Dinechin wrote: > > > On Feb 23, 2018, at 8:07 AM, Frediano Ziglio wrote: > > > > From: Christophe de Dinechin > > > > Signed-off-by: Christophe de Dinechin > > --- > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3] log_binary is really a boolean

2018-02-22 Thread Christophe de Dinechin
> On Feb 23, 2018, at 8:07 AM, Frediano Ziglio wrote: > > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > Change since v3: > - change enum syntax. > > Change since v2: > - rebased. > > Change since