Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

> > Hi, > > On Tue, Feb 20, 2018 at 10:00:41AM +0100, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > > > On 02/14/2018 06:37 PM, Christophe Fergeau

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Tue, Feb 20, 2018 at 12:22:52PM +0100, Lukáš Hrázký wrote: > On Tue, 2018-02-20 at 11:59 +0100, Victor Toso wrote: > > On Tue, Feb 20, 2018 at 11:45:33AM +0100, Lukáš Hrázký wrote: > > > > That tests are not enabled by default. If we enable it by default > > > > here I would expect to do the

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Tue, 2018-02-20 at 11:59 +0100, Victor Toso wrote: > On Tue, Feb 20, 2018 at 11:45:33AM +0100, Lukáš Hrázký wrote: > > > That tests are not enabled by default. If we enable it by default > > > here I would expect to do the same for other Spice components. > > > > Ok, but I'm somewhat confused

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Tue, Feb 20, 2018 at 11:45:33AM +0100, Lukáš Hrázký wrote: > > That tests are not enabled by default. If we enable it by default > > here I would expect to do the same for other Spice components. > > Ok, but I'm somewhat confused here. Enabling the tests is during > packaging - you run `make

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Tue, 2018-02-20 at 11:34 +0100, Victor Toso wrote: > On Tue, Feb 20, 2018 at 11:21:47AM +0100, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote: > > > IMHO, tests are a must for development and should be optional > > > on tarballs from releases. That means that

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote: > Hi, > > On Tue, Feb 20, 2018 at 10:00:41AM +0100, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

Hi, On Tue, Feb 20, 2018 at 10:00:41AM +0100, Lukáš Hrázký wrote: > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > > On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > > > > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Tue, 2018-02-20 at 10:31 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 10:00, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 18:29 +0200, Uri

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Mon, Feb 19, 2018 at 09:19:18PM +0200, Uri Lublin wrote: > If users prefer to not run autogen.sh that's ok. > It provides defaults options for developers. > For example, I do not expect users to run configure with > --enable-maintainer-mode too. NB: My understanding of

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

> On 20 Feb 2018, at 10:00, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: >> On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: >>> On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > On

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > > > > On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote: > > > > > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: On 02/14/2018 06:37 PM, Christophe Fergeau wrote: On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote: On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: Introduce a

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > > On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote: > > > > > > > > > On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: > > > > > > > > > > Introduce a unit

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On 02/14/2018 06:37 PM, Christophe Fergeau wrote: On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote: On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: Introduce a unit test framework (Catch) to the codebase and a simple unit test for parsing the options of the

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote: > > > > > On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: > > > > > > Introduce a unit test framework (Catch) to the codebase and a simple > > > unit test for parsing the options of the mjpeg plugin. > > > > > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

> > > On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: > > > > Introduce a unit test framework (Catch) to the codebase and a simple > > unit test for parsing the options of the mjpeg plugin. > > > > Signed-off-by: Lukáš Hrázký > > --- > > configure.ac

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Wed, 2018-02-14 at 16:08 +0100, Christophe de Dinechin wrote: > > On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: > > > > Introduce a unit test framework (Catch) to the codebase and a simple > > unit test for parsing the options of the mjpeg plugin. > > > > Signed-off-by:

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

On Wed, 2018-02-14 at 09:22 -0500, Frediano Ziglio wrote: > > > > Introduce a unit test framework (Catch) to the codebase and a simple > > unit test for parsing the options of the mjpeg plugin. > > > > Signed-off-by: Lukáš Hrázký > > --- > > configure.ac

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

> On 14 Feb 2018, at 13:34, Lukáš Hrázký wrote: > > Introduce a unit test framework (Catch) to the codebase and a simple > unit test for parsing the options of the mjpeg plugin. > > Signed-off-by: Lukáš Hrázký > --- > configure.ac

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

> > Introduce a unit test framework (Catch) to the codebase and a simple > unit test for parsing the options of the mjpeg plugin. > > Signed-off-by: Lukáš Hrázký > --- > configure.ac | 3 ++ > src/mjpeg-fallback.cpp| 5 +++ >