Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

2013-08-12 Thread Yonit Halperin
Hi, red_time.h is missing. On 08/12/2013 11:32 AM, Alon Levy wrote: Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

2013-08-12 Thread Yonit Halperin
Hi, I think red_channel_client_wait_pipe_item_sent should ref and unref the pipe item by itself (using the hold/release-item callbacks). Then, you don't need dcc_wait_pipe_item_sent. Also, I'm not sure why PUSH_TIMEOUT is bigger than DETACH timeout. It would have been logical if the bigger

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

2013-08-12 Thread Alon Levy
Hi, I think red_channel_client_wait_pipe_item_sent should ref and unref the pipe item by itself (using the hold/release-item callbacks). Then, you don't need dcc_wait_pipe_item_sent. This is a bit scarier then my mechanical change. Since there are two versions of the release function, for

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

2013-08-12 Thread Yonit Halperin
On 08/12/2013 12:32 PM, Alon Levy wrote: Hi, I think red_channel_client_wait_pipe_item_sent should ref and unref the pipe item by itself (using the hold/release-item callbacks). Then, you don't need dcc_wait_pipe_item_sent. This is a bit scarier then my mechanical change. Since there are two