Re: [Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

2016-12-06 Thread Frediano Ziglio
> > On Mon, Dec 05, 2016 at 09:16:45AM -0500, Frediano Ziglio wrote: > > > > > > On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote: > > > > On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > > > > > This code is the same inside __new_channel but will set the > > > > >

Re: [Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

2016-12-05 Thread Frediano Ziglio
> > On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote: > > On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > > > This code is the same inside __new_channel but will set the > > > RedsStream from RedChannel. > > > > Shouldn't this code be removed from __new_channel()

Re: [Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

2016-12-05 Thread Christophe Fergeau
On Thu, Dec 01, 2016 at 03:43:01PM -0600, Jonathon Jongsma wrote: > On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > > This code is the same inside __new_channel but will set the > > RedsStream from RedChannel. > > Shouldn't this code be removed from __new_channel() then? I agree that

Re: [Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

2016-12-02 Thread Frediano Ziglio
> > On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > > This code is the same inside __new_channel but will set the > > RedsStream from RedChannel. > > Shouldn't this code be removed from __new_channel() then? > I'd prefer to keep the functionality and remove when the feature is

Re: [Spice-devel] [PATCH v4 06/17] sound: Implements config_socket RedChannel callback

2016-12-01 Thread Jonathon Jongsma
On Thu, 2016-12-01 at 11:24 +, Frediano Ziglio wrote: > This code is the same inside __new_channel but will set the > RedsStream from RedChannel. Shouldn't this code be removed from __new_channel() then? > > Signed-off-by: Frediano Ziglio > --- >  server/sound.c | 46