Spice protocol

2025-07-09 Thread Сергей Корнилов
Hi, I have a few questions about the protocol's performance related to the refresh rate of the 2k image. If your support is still available, please contact me.

Re: Unexpected spice-protocol release

2025-05-01 Thread Marc-André Lureau
me time for the reviewers. > Can you finish the steps mentioned at > https://gitlab.freedesktop.org/spice/spice-protocol/-/blob/master/docs/how_to_release.md?ref_type=heads? > Can you add some notes to > https://gitlab.freedesktop.org/spice/spice-protocol/-/releases? > Done, thanks Victor

Unexpected spice-protocol release

2025-04-30 Thread Frediano Ziglio
/spice/spice-protocol/-/blob/master/docs/how_to_release.md?ref_type=heads ? Can you add some notes to https://gitlab.freedesktop.org/spice/spice-protocol/-/releases? Regards, Frediano

Re: [Spice-devel] Does spice protocol (client/server) support serial port redirection

2023-05-12 Thread Frediano Ziglio
On Fri, 12 May 2023, 10:47 171548156, wrote: > Hello: > > Does spice protocol (client/server) support serial port redirection? > > if supported, can you give me a example? > > > Look forward to your reply. Thank you. > No, it does not support serial port redirectio

[Spice-devel] Does spice protocol (client/server) support serial port redirection

2023-05-12 Thread 171548156
Hello: Does spice protocol (client/server) support serial port redirection? if supported, can you give me a example? Look forward to your reply. Thank you.

Re: [Spice-devel] spice protocol 11.5 encrypted password

2021-09-19 Thread Frediano Ziglio
gards, Frediano Il giorno ven 10 set 2021 alle ore 12:30 Andrey Af ha scritto: > Hi, > About 11.5 - it is a section in the documentation (spice protocol). > I am trying to implement the server part on my project > (LinuxTerminalService ), > https://github.com/AndreyBarmaley/linux-term

Re: [Spice-devel] spice protocol 11.5 encrypted password

2021-09-10 Thread Andrey Af
Hi, About 11.5 - it is a section in the documentation (spice protocol). I am trying to implement the server part on my project (LinuxTerminalService ), https://github.com/AndreyBarmaley/linux-terminal-service-manager I already have a working vnc and rdp protocols implemented, and I'm going t

Re: [Spice-devel] spice protocol 11.5 encrypted password

2021-09-10 Thread Frediano Ziglio
Hi, there's no protocol 11.5. There's no data length markeR, password is zero terminated and encrypted, if you refer to the default password schema (no SASL). Can you explain what you are trying to do? Regards, Frediano Il giorno ven 10 set 2021 alle ore 06:51 Andrey Af ha scritto: > Hi, >

[Spice-devel] spice protocol 11.5 encrypted password

2021-09-09 Thread Andrey Af
Hi, For encrypted password, there is definitely no data length market? For example, I don't need a password, authentication is verified by another part of the code, how can I skip this?

Re: [Spice-devel] ANNOUNCE spice-protocol 0.14.3 release

2020-10-01 Thread Frediano Ziglio
Thanks to Victor Toso for the support for this release. Frediano > > Hey everyone, > > I just cut a new small release. > If you find any bugs or regressions, please report them in our issue > tracker: https://gitlab.freedesktop.org/spice/spice-protocol/-/issues

[Spice-devel] ANNOUNCE spice-protocol 0.14.3 release

2020-10-01 Thread Frediano Ziglio
Hey everyone, I just cut a new small release. If you find any bugs or regressions, please report them in our issue tracker: https://gitlab.freedesktop.org/spice/spice-protocol/-/issues. See also https://gitlab.freedesktop.org/spice/spice-protocol/-/tags/v0.14.3. Major changes in 0.14.3

[Spice-devel] Spice protocol performance

2020-08-12 Thread Jure Erznožnik
Hello (very fearfully, because I found no list that could be helpful and this one seems to be for developers...), I have been trying for a long while now to get my VM machines to perform well, but I can't seem to get it right. I seem to be suffering from two issues: 1. remote-viewer / libvir

[Spice-devel] ANNOUNCE spice-protocol 0.14.1 release

2020-03-09 Thread Victor Toso
Hi all, Spice-protocol 0.14.1 was released this last Saturday and updating it would allow new features and fixes to arrive in other components. In case of bugs or requests, please file them at our issue tracker: https://gitlab.freedesktop.org/groups/spice/-/issues Release: https

Re: [Spice-devel] Spice-protocol pre-compialtion configuration error

2020-01-15 Thread Frediano Ziglio
> Gents , could you please advise - in case of precompiling meson activation > warning - Build targets in project: 0 is a normal situation? Unusual but correct, the project consists of headers to be installed, so nothing to build. Frediano ___ Spice-

[Spice-devel] Spice-protocol pre-compialtion configuration error

2020-01-14 Thread Андрей Фокин
Gents , could you please advise - in case of precompiling meson activation warning -   Build targets in project: 0 is a normal situation? -- Андрей Фокин___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailm

Re: [Spice-devel] [PATCH spice-protocol v4 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-23 Thread Frediano Ziglio
file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/spice-protocol.spec.in b/spice-protocol.spec.in > > index 54aacfd..2fe940b 100644 > > --- a/spice-protocol.spec.in > > +++ b/spice-protocol.spec.in > > @@ -19,7 +19,7 @@ and the para-virtual graphics card QXL.

Re: [Spice-devel] [PATCH spice-protocol v4 4/5] build-sys: Allows spec file to build MingW packages

2019-10-23 Thread Victor Toso
Hi, On Wed, Oct 23, 2019 at 11:06:31AM +0100, Frediano Ziglio wrote: > Add MingW support. This allows to build MingW packages easily with a > > $ rpmbuild -ta spice-protocol-.tar.bz2 > > This is base on some work by Eduardo Lima adding MingW support to SPEC > files. >

Re: [Spice-devel] [PATCH spice-protocol v4 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-23 Thread Eduardo Lima (Etrunko)
/spice-protocol.spec.in @@ -19,7 +19,7 @@ and the para-virtual graphics card QXL. %define mingw_files() \ %package -n %{1}-spice-protocol \ Summary:Spice protocol header files \ -Requires: pkgconfig \ +Requires: %{1}-pkg-config \ \ %description -n %{1}-spice-protocol

Re: [Spice-devel] [PATCH spice-protocol v4 3/5] build-sys: Provide spec file during build

2019-10-23 Thread Eduardo Lima (Etrunko)
like $ rpmbuild -ta spice-protocol-.tar.bz2 Signed-off-by: Frediano Ziglio Signed-off-by: Victor Toso -- Changes since v3: - add gitlab ci from Victor --- .gitlab-ci.yml | 4 +++- Makefile.am| 1 + configure.ac | 1 + spice-protocol.spec.in | 3 ++- 4

Re: [Spice-devel] [PATCH spice-protocol v4 2/5] build-sys: Update URL in SPEC file

2019-10-23 Thread Eduardo Lima (Etrunko)
a/spice-protocol.spec.in b/spice-protocol.spec.in index a13ae99..e240637 100644 --- a/spice-protocol.spec.in +++ b/spice-protocol.spec.in @@ -4,8 +4,8 @@ Release:1%{?dist} Summary:Spice protocol header files # Main headers are BSD, controller / foreign menu are LGPL License

Re: [Spice-devel] [PATCH spice-protocol v4 1/5] build-sys: Import spec file from Fedora

2019-10-23 Thread Eduardo Lima (Etrunko)
spice-protocol.spec.in diff --git a/spice-protocol.spec.in b/spice-protocol.spec.in new file mode 100644 index 000..a13ae99 --- /dev/null +++ b/spice-protocol.spec.in @@ -0,0 +1,173 @@ +Name: spice-protocol +Version:0.14.0 +Release:1%{?dist} +Summary:Spice

[Spice-devel] [PATCH spice-protocol v4 2/5] build-sys: Update URL in SPEC file

2019-10-23 Thread Frediano Ziglio
index a13ae99..e240637 100644 --- a/spice-protocol.spec.in +++ b/spice-protocol.spec.in @@ -4,8 +4,8 @@ Release:1%{?dist} Summary:Spice protocol header files # Main headers are BSD, controller / foreign menu are LGPL License:BSD and LGPLv2+ -URL:http

[Spice-devel] [PATCH spice-protocol v4 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-23 Thread Frediano Ziglio
-protocol.spec.in @@ -19,7 +19,7 @@ and the para-virtual graphics card QXL. %define mingw_files() \ %package -n %{1}-spice-protocol \ Summary:Spice protocol header files \ -Requires: pkgconfig \ +Requires: %{1}-pkg-config \ \ %description -n %{1}-spice-protocol \ Header

[Spice-devel] [PATCH spice-protocol v4 3/5] build-sys: Provide spec file during build

2019-10-23 Thread Frediano Ziglio
Having the RPM spec file produced by the build is helpful in different situation. Different tools like mock or code scanners accept source RPMs as input. Providing this file allows easily build of the source RPM (and binaries) using a simple command like $ rpmbuild -ta spice-protocol

[Spice-devel] [PATCH spice-protocol v4 4/5] build-sys: Allows spec file to build MingW packages

2019-10-23 Thread Frediano Ziglio
Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 This is base on some work by Eduardo Lima adding MingW support to SPEC files. Part of dependencies, description and names came from Fedora SPEC file for mingw-spice-protocol package

[Spice-devel] [PATCH spice-protocol v4 1/5] build-sys: Import spec file from Fedora

2019-10-23 Thread Frediano Ziglio
-protocol.spec.in b/spice-protocol.spec.in new file mode 100644 index 000..a13ae99 --- /dev/null +++ b/spice-protocol.spec.in @@ -0,0 +1,173 @@ +Name: spice-protocol +Version:0.14.0 +Release:1%{?dist} +Summary:Spice protocol header files +# Main headers are BSD

Re: [Spice-devel] [spice-protocol 2/2] fixup: gitlab-ci: to fix after mingw

2019-10-23 Thread Victor Toso
On Wed, Oct 23, 2019 at 05:52:09AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > --- > > .gitlab-ci.yml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index da4f512..c7028dd 100644 > > --- a/.gitlab-ci.yml

Re: [Spice-devel] [spice-protocol 2/2] fixup: gitlab-ci: to fix after mingw

2019-10-23 Thread Frediano Ziglio
> > From: Victor Toso > > --- > .gitlab-ci.yml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index da4f512..c7028dd 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -4,9 +4,10 @@ variables: >DEPS_COMMON: git libtool ma

[Spice-devel] [spice-protocol 0/2] add gitlabci check

2019-10-23 Thread Victor Toso
From: Victor Toso Hi, two patches to be squashed if you agree. Both for fedora-autotools stage in gitlab-ci. Victor Toso (2): fixup: gitlab-ci: to be added fixup: gitlab-ci: to fix after mingw .gitlab-ci.yml | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.21.0

[Spice-devel] [spice-protocol 2/2] fixup: gitlab-ci: to fix after mingw

2019-10-23 Thread Victor Toso
From: Victor Toso --- .gitlab-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index da4f512..c7028dd 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4,9 +4,10 @@ variables: DEPS_COMMON: git libtool make python3 python3-six redh

[Spice-devel] [spice-protocol 1/2] fixup: gitlab-ci: to be added

2019-10-23 Thread Victor Toso
@@ -14,6 +14,8 @@ fedora-autotools: - ./autogen.sh - make - make distcheck +- rpmlint spice-protocol.spec +- rpmbuild -ta spice-protocol-*.tar.bz2 fedora-meson: script: -- 2.21.0 ___ Spice-devel mailing list Spice-devel

[Spice-devel] [PATCH spice-protocol v3 3/5] build-sys: Provide spec file during build

2019-10-22 Thread Frediano Ziglio
Having the RPM spec file produced by the build is helpful in different situation. Different tools like mock or code scanners accept source RPMs as input. Providing this file allows easily build of the source RPM (and binaries) using a simple command like $ rpmbuild -ta spice-protocol

[Spice-devel] [PATCH spice-protocol v3 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-22 Thread Frediano Ziglio
-protocol.spec.in @@ -19,7 +19,7 @@ and the para-virtual graphics card QXL. %define mingw_files() \ %package -n %{1}-spice-protocol \ Summary:Spice protocol header files \ -Requires: pkgconfig \ +Requires: %{1}-pkg-config \ \ %description -n %{1}-spice-protocol \ Header

[Spice-devel] [PATCH spice-protocol v3 4/5] build-sys: Allows spec file to build MingW packages

2019-10-22 Thread Frediano Ziglio
Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 This is base on some work by Eduardo Lima adding MingW support to SPEC files. Part of dependencies, description and names came from Fedora SPEC file for mingw-spice-protocol package

[Spice-devel] [PATCH spice-protocol v3 2/5] build-sys: Update URL in SPEC file

2019-10-22 Thread Frediano Ziglio
index a13ae99..e240637 100644 --- a/spice-protocol.spec.in +++ b/spice-protocol.spec.in @@ -4,8 +4,8 @@ Release:1%{?dist} Summary:Spice protocol header files # Main headers are BSD, controller / foreign menu are LGPL License:BSD and LGPLv2+ -URL:http

[Spice-devel] [PATCH spice-protocol v3 1/5] build-sys: Import spec file from Fedora

2019-10-22 Thread Frediano Ziglio
-protocol.spec.in b/spice-protocol.spec.in new file mode 100644 index 000..a13ae99 --- /dev/null +++ b/spice-protocol.spec.in @@ -0,0 +1,173 @@ +Name: spice-protocol +Version:0.14.0 +Release:1%{?dist} +Summary:Spice protocol header files +# Main headers are BSD

Re: [Spice-devel] [PATCH spice-protocol v2 1/5] build-sys: Import spec file from Fedora

2019-10-22 Thread Eduardo Lima (Etrunko)
+ 1 file changed, 173 insertions(+) create mode 100644 spice-protocol.spec.in diff --git a/spice-protocol.spec.in b/spice-protocol.spec.in new file mode 100644 index 000..a13ae99 --- /dev/null +++ b/spice-protocol.spec.in @@ -0,0 +1,173 @@ +Name: spice-protocol

Re: [Spice-devel] [PATCH spice-protocol v2 4/5] build-sys: Update URL in SPEC file

2019-10-22 Thread Frediano Ziglio
2 deletions(-) > > > > diff --git a/spice-protocol.spec.in b/spice-protocol.spec.in > > index 71ab91a..54aacfd 100644 > > --- a/spice-protocol.spec.in > > +++ b/spice-protocol.spec.in > > @@ -5,8 +5,8 @@ Summary:Spice protocol header files >

Re: [Spice-devel] [PATCH spice-protocol v2 4/5] build-sys: Update URL in SPEC file

2019-10-22 Thread Eduardo Lima (Etrunko)
| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice-protocol.spec.in b/spice-protocol.spec.in index 71ab91a..54aacfd 100644 --- a/spice-protocol.spec.in +++ b/spice-protocol.spec.in @@ -5,8 +5,8 @@ Summary:Spice protocol header files Group: Development

[Spice-devel] [PATCH spice-protocol v2 2/5] build-sys: Provide spec file during build

2019-10-21 Thread Frediano Ziglio
Having the RPM spec file produced by the build is helpful in different situation. Different tools like mock or code scanners accept source RPMs as input. Providing this file allows easily build of the source RPM (and binaries) using a simple command like $ rpmbuild -ta spice-protocol

[Spice-devel] [PATCH spice-protocol v2 4/5] build-sys: Update URL in SPEC file

2019-10-21 Thread Frediano Ziglio
index 71ab91a..54aacfd 100644 --- a/spice-protocol.spec.in +++ b/spice-protocol.spec.in @@ -5,8 +5,8 @@ Summary:Spice protocol header files Group: Development/Libraries # Main headers are BSD, controller / foreign menu are LGPL License:BSD and LGPLv2+ -URL

[Spice-devel] [PATCH spice-protocol v2 3/5] build-sys: Allows spec file to build MingW packages

2019-10-21 Thread Frediano Ziglio
Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 This is base on some work by Eduardo Lima adding MingW support to SPEC files. Part of dependencies, description and names came from Fedora SPEC file for mingw-spice-protocol package

[Spice-devel] [PATCH spice-protocol v2 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-21 Thread Frediano Ziglio
-protocol.spec.in @@ -19,7 +19,7 @@ and the para-virtual graphics card QXL. %define mingw_files() \ %package -n %{1}-spice-protocol \ Summary:Spice protocol header files \ -Requires: pkgconfig \ +Requires: %{1}-pkg-config \ \ %description -n %{1}-spice-protocol \ Header

[Spice-devel] [PATCH spice-protocol v2 1/5] build-sys: Import spec file from Fedora

2019-10-21 Thread Frediano Ziglio
100644 index 000..a13ae99 --- /dev/null +++ b/spice-protocol.spec.in @@ -0,0 +1,173 @@ +Name: spice-protocol +Version:0.14.0 +Release:1%{?dist} +Summary:Spice protocol header files +# Main headers are BSD, controller / foreign menu are LGPL +License:BSD and

Re: [Spice-devel] [PATCH spice-protocol 3/5] build-sys: Allows spec file to build MingW packages

2019-10-21 Thread Frediano Ziglio
> > On 10/11/19 6:56 AM, Frediano Ziglio wrote: > > Add MingW support. This allows to build MingW packages easily with a > > > > $ rpmbuild -ta spice-protocol-.tar.bz2 > > > > It's possible to disable MingW build using > > >

Re: [Spice-devel] [PATCH spice-protocol 3/5] build-sys: Allows spec file to build MingW packages

2019-10-21 Thread Eduardo Lima (Etrunko)
On 10/11/19 6:56 AM, Frediano Ziglio wrote: Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 It's possible to disable MingW build using $ rpmbuild --without mingw -ta spice-protocol-.tar.bz2 This is base on some wo

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-16 Thread Frediano Ziglio
ing this opportunity and dropping the autotools support in > favor of meson, at least for protocol? Spice-gtk already did it, and it > is much more complex than this one. > More than the opportunity to me it seems adding pression and stopovers. The initial SPEC f

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-16 Thread Eduardo Lima (Etrunko)
On 10/14/19 10:18 AM, Frediano Ziglio wrote: Hi, On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: This series is part from a former series. There's an initial import commit to better understand the changes. It contains some work from Eduardo for MingW packaging. Final patches a

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-14 Thread Victor Toso
Hi, On Mon, Oct 14, 2019 at 09:18:51AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: > > > This series is part from a former series. > > > There's an initial import commit to better understand the changes. > > > It contains som

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-14 Thread Frediano Ziglio
> > Hi, > > On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: > > This series is part from a former series. > > There's an initial import commit to better understand the changes. > > It contains some work from Eduardo for MingW packaging. > > Final patches are really minor. > > Sh

Re: [Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-14 Thread Victor Toso
Hi, On Fri, Oct 11, 2019 at 10:56:24AM +0100, Frediano Ziglio wrote: > This series is part from a former series. > There's an initial import commit to better understand the changes. > It contains some work from Eduardo for MingW packaging. > Final patches are really minor. Should I/we wait for Ed

[Spice-devel] [PATCH spice-protocol 0/5] SPEC integration

2019-10-11 Thread Frediano Ziglio
This series is part from a former series. There's an initial import commit to better understand the changes. It contains some work from Eduardo for MingW packaging. Final patches are really minor. Frediano Ziglio (5): build-sys: Import spec file from Fedora build-sys: Provide spec file during

[Spice-devel] [PATCH spice-protocol 2/5] build-sys: Provide spec file during build

2019-10-11 Thread Frediano Ziglio
Having the RPM spec file produced by the build is helpful in different situation. Different tools like mock or code scanners accept source RPMs as input. Providing this file allows easily build of the source RPM (and binaries) using a simple command like $ rpmbuild -ta spice-protocol

[Spice-devel] [PATCH spice-protocol 1/5] build-sys: Import spec file from Fedora

2019-10-11 Thread Frediano Ziglio
100644 index 000..a13ae99 --- /dev/null +++ b/spice-protocol.spec.in @@ -0,0 +1,173 @@ +Name: spice-protocol +Version:0.14.0 +Release:1%{?dist} +Summary:Spice protocol header files +# Main headers are BSD, controller / foreign menu are LGPL +License:BSD and

[Spice-devel] [PATCH spice-protocol 5/5] build-sys: Requires proper pkg-config for MingW

2019-10-11 Thread Frediano Ziglio
-protocol.spec.in @@ -31,7 +31,7 @@ and the para-virtual graphics card QXL. %define mingw_files() \ %package -n %{1}-spice-protocol \ Summary:Spice protocol header files \ -Requires: pkgconfig \ +Requires: %{1}-pkg-config \ \ %description -n %{1}-spice-protocol \ Header

[Spice-devel] [PATCH spice-protocol 3/5] build-sys: Allows spec file to build MingW packages

2019-10-11 Thread Frediano Ziglio
Add MingW support. This allows to build MingW packages easily with a $ rpmbuild -ta spice-protocol-.tar.bz2 It's possible to disable MingW build using $ rpmbuild --without mingw -ta spice-protocol-.tar.bz2 This is base on some work by Eduardo Lima adding MingW support to SPEC

[Spice-devel] [PATCH spice-protocol 4/5] build-sys: Update URL in SPEC file

2019-10-11 Thread Frediano Ziglio
index a6a570d..375291c 100644 --- a/spice-protocol.spec.in +++ b/spice-protocol.spec.in @@ -13,8 +13,8 @@ Summary:Spice protocol header files Group: Development/Libraries # Main headers are BSD, controller / foreign menu are LGPL License:BSD and LGPLv2+ -URL

Re: [Spice-devel] [PATCH spice-protocol] qxl_dev: Add comment to QXLQUICData->data field

2019-08-22 Thread Victor Toso
Hi, On Thu, Aug 22, 2019 at 08:14:24AM -0400, Frediano Ziglio wrote: > ping > > > > > Recently a bug using this structure was fixed. > > The bug involved understand the usage of this field so add some > > note on the field for future reference. > > > > Signed-off-by: Frediano Ziglio Sure, Ack

Re: [Spice-devel] [PATCH spice-protocol] qxl_dev: Add comment to QXLQUICData->data field

2019-08-22 Thread Frediano Ziglio
ping > > Recently a bug using this structure was fixed. > The bug involved understand the usage of this field so add some > note on the field for future reference. > > Signed-off-by: Frediano Ziglio > --- > spice/qxl_dev.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/spice/qxl_

[Spice-devel] [PATCH spice-protocol] qxl_dev: Add comment to QXLQUICData->data field

2019-08-13 Thread Frediano Ziglio
Recently a bug using this structure was fixed. The bug involved understand the usage of this field so add some note on the field for future reference. Signed-off-by: Frediano Ziglio --- spice/qxl_dev.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index

[Spice-devel] [PATCH spice-protocol v2] protocol: Add some comments to vd_agentd.h

2019-08-07 Thread Frediano Ziglio
e messages are sent through the virtio port "com.redhat.spice.0" + * (agent <-> server) or embedded in "agent_data" SPICE protocol message in + * the "MainChannel" (server <-> client) + */ enum { +/* server -> agent */ VD_AGENT_MOUSE_STATE = 1,

Re: [Spice-devel] [PATCH spice-protocol] start-packet: Correct misleading comment

2019-07-21 Thread Snir Sheriber
Acked-by: Snir Sheriber Oh, got it, makes sense! Thanks On 7/18/19 6:50 PM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- spice/start-packed.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice/start-packed.h b/spice/start-packed.h index de0c595..d1

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-21 Thread Snir Sheriber
On 7/18/19 6:37 PM, Frediano Ziglio wrote: On 7/18/19 5:51 PM, Frediano Ziglio wrote: Hi, IIRC this was related to some compiler warning, no? Yes, recent compilers are reporting it, see below. If it is I'd mentioning it , otherwise, ack. Just this patch or the entire series? No, actua

Re: [Spice-devel] [PATCH spice-protocol 2/2] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-07-18 Thread Frediano Ziglio
ping > > This structure is not declares as SPICE_ATTR_PACKED resulting it > as aligned and no packed using GCC (no MingW). > This structure is only packed under MingW or Microsoft compilers. > This structure is not technically a definition for QXL device but > is used only for spice-server QXL in

[Spice-devel] [PATCH spice-protocol] start-packet: Correct misleading comment

2019-07-18 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- spice/start-packed.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spice/start-packed.h b/spice/start-packed.h index de0c595..d1d090e 100644 --- a/spice/start-packed.h +++ b/spice/start-packed.h @@ -30,8 +30,8 @@ */ /* Ideally this

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-18 Thread Frediano Ziglio
> > > On 7/18/19 5:51 PM, Frediano Ziglio wrote: > >> Hi, > >> > >> > >> IIRC this was related to some compiler warning, no? > > Yes, recent compilers are reporting it, see below. > > > >> If it is I'd mentioning it , otherwise, ack. > >> > > Just this patch or the entire series? > > > No, actu

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-18 Thread Snir Sheriber
On 7/18/19 5:51 PM, Frediano Ziglio wrote: Hi, IIRC this was related to some compiler warning, no? Yes, recent compilers are reporting it, see below. If it is I'd mentioning it , otherwise, ack. Just this patch or the entire series? No, actually i started looking at the second one and

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-18 Thread Frediano Ziglio
> > Hi, > > > IIRC this was related to some compiler warning, no? Yes, recent compilers are reporting it, see below. > If it is I'd mentioning it , otherwise, ack. > Just this patch or the entire series? > Snir. > > > On 7/4/19 4:56 PM, Frediano Ziglio wrote: > > Do not declare the struct

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-18 Thread Snir Sheriber
Hi, IIRC this was related to some compiler warning, no? If it is I'd mentioning it , otherwise, ack. Snir. On 7/4/19 4:56 PM, Frediano Ziglio wrote: Do not declare the structure as aligned. The start/end-packed.h headers affects structures without specification only using MingW or Microsoft

Re: [Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-16 Thread Frediano Ziglio
ping series > > Do not declare the structure as aligned. > The start/end-packed.h headers affects structures without > specification only using MingW or Microsoft compilers. For other > platform SPICE_ATTR_PACKED macro should be used. This way the > definition are the same for all compiler. > Th

[Spice-devel] [PATCH spice-protocol 2/2] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-07-04 Thread Frediano Ziglio
This structure is not declares as SPICE_ATTR_PACKED resulting it as aligned and no packed using GCC (no MingW). This structure is only packed under MingW or Microsoft compilers. This structure is not technically a definition for QXL device but is used only for spice-server QXL interface. As said ab

[Spice-devel] [PATCH spice-protocol 1/2 v2] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-04 Thread Frediano Ziglio
Do not declare the structure as aligned. The start/end-packed.h headers affects structures without specification only using MingW or Microsoft compilers. For other platform SPICE_ATTR_PACKED macro should be used. This way the definition are the same for all compiler. This structure is used in a lo

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-07-01 Thread Frediano Ziglio
> > On 5/13/19 12:45 PM, Frediano Ziglio wrote: > > Do not declare the structure as aligned. > > The start/end-packed.h headers affects only MingW or Microsoft > > compilers. > > They also define/undef SPICE_ATTR_PACKED which affects Linux. > May be: The start/end-packed.h headers affects struc

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-06-30 Thread Uri Lublin
On 5/13/19 12:45 PM, Frediano Ziglio wrote: Do not declare the structure as aligned. The start/end-packed.h headers affects only MingW or Microsoft compilers. They also define/undef SPICE_ATTR_PACKED which affects Linux. BTW, if we define PACKED as ALIGNED(1) does that work for Windows too (I

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-06-28 Thread Frediano Ziglio
ping 5 > > ping 4 > > > > > ping 3 > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > This structure is not declares as SPICE_ATTR_PACKED resulting it > > > > > as aligned and no packed using GCC (no MingW). > > > > > This structure is only packed under MingW or M

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-06-28 Thread Frediano Ziglio
ping 5 > > ping 4 > > > > > ping 3 > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > Do not declare the structure as aligned. > > > > > The start/end-packed.h headers affects only MingW or Microsoft > > > > > compilers. To have unaligned structure with GCC compil

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-06-19 Thread Frediano Ziglio
ping 4 > > ping 3 > > > > > ping > > > > > > > > ping > > > > > > > > > > > This structure is not declares as SPICE_ATTR_PACKED resulting it > > > > as aligned and no packed using GCC (no MingW). > > > > This structure is only packed under MingW or Microsoft compilers. > > > > This structur

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-06-19 Thread Frediano Ziglio
ping 4 > > ping 3 > > > > > ping > > > > > > > > ping > > > > > > > > > > > Do not declare the structure as aligned. > > > > The start/end-packed.h headers affects only MingW or Microsoft > > > > compilers. To have unaligned structure with GCC compiler you have > > > > to use SPICE_ATTR_PAC

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-06-11 Thread Frediano Ziglio
ping 3 > > ping > > > > > ping > > > > > > > > This structure is not declares as SPICE_ATTR_PACKED resulting it > > > as aligned and no packed using GCC (no MingW). > > > This structure is only packed under MingW or Microsoft compilers. > > > This structure is not technically a definition for

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-06-11 Thread Frediano Ziglio
ping 3 > > ping > > > > > ping > > > > > > > > Do not declare the structure as aligned. > > > The start/end-packed.h headers affects only MingW or Microsoft > > > compilers. To have unaligned structure with GCC compiler you have > > > to use SPICE_ATTR_PACKED. This way the definition are the

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-05-29 Thread Frediano Ziglio
ping > > ping > > > > > Do not declare the structure as aligned. > > The start/end-packed.h headers affects only MingW or Microsoft > > compilers. To have unaligned structure with GCC compiler you have > > to use SPICE_ATTR_PACKED. This way the definition are the same for > > all compiler. > >

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-05-29 Thread Frediano Ziglio
ping > > ping > > > > > This structure is not declares as SPICE_ATTR_PACKED resulting it > > as aligned and no packed using GCC (no MingW). > > This structure is only packed under MingW or Microsoft compilers. > > This structure is not technically a definition for QXL device but > > is used onl

Re: [Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-05-20 Thread Frediano Ziglio
ping > > Do not declare the structure as aligned. > The start/end-packed.h headers affects only MingW or Microsoft > compilers. To have unaligned structure with GCC compiler you have > to use SPICE_ATTR_PACKED. This way the definition are the same for > all compiler. > This structure is used in a

Re: [Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-05-20 Thread Frediano Ziglio
ping > > This structure is not declares as SPICE_ATTR_PACKED resulting it > as aligned and no packed using GCC (no MingW). > This structure is only packed under MingW or Microsoft compilers. > This structure is not technically a definition for QXL device but > is used only for spice-server QXL in

Re: [Spice-devel] [PATCH spice-protocol 1/3] build-sys: post-release version bump 0.14.1

2019-05-13 Thread Victor Toso
/configure.ac > index b56f414..bc3e33f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -2,7 +2,7 @@ AC_PREREQ([2.57]) > > m4_define([SPICE_MAJOR], 0) > m4_define([SPICE_MINOR], 14) > -m4_define([SPICE_MICRO], 0) > +m4_define([SPICE_MICRO], 1) > > AC_INI

[Spice-devel] [PATCH spice-protocol 1/3] build-sys: post-release version bump 0.14.1

2019-05-13 Thread Frediano Ziglio
], 0) m4_define([SPICE_MINOR], 14) -m4_define([SPICE_MICRO], 0) +m4_define([SPICE_MICRO], 1) AC_INIT(spice-protocol, [SPICE_MAJOR.SPICE_MINOR.SPICE_MICRO], [], spice-protocol) diff --git a/meson.build b/meson.build index f9da4ac..75e64c4 100644 --- a/meson.build +++ b/meson.build @@ -2,7 +2,7

[Spice-devel] [PATCH spice-protocol 2/3] qxl_dev: Fix alignment for QXLReleaseInfo

2019-05-13 Thread Frediano Ziglio
Do not declare the structure as aligned. The start/end-packed.h headers affects only MingW or Microsoft compilers. To have unaligned structure with GCC compiler you have to use SPICE_ATTR_PACKED. This way the definition are the same for all compiler. This structure is used in a lot of QXL structure

[Spice-devel] [PATCH spice-protocol 3/3] qxl_dev: Move QXLReleaseInfoExt out of start/end-packed.h

2019-05-13 Thread Frediano Ziglio
This structure is not declares as SPICE_ATTR_PACKED resulting it as aligned and no packed using GCC (no MingW). This structure is only packed under MingW or Microsoft compilers. This structure is not technically a definition for QXL device but is used only for spice-server QXL interface. As said ab

[Spice-devel] [PATCH spice-server v2 2/3] Update spice-protocol version

2019-04-26 Thread Frediano Ziglio
deletions(-) diff --git a/README b/README index 8ce949a28..59d23672f 100644 --- a/README +++ b/README @@ -27,7 +27,7 @@ Or to install into a private user specific location The following mandatory dependencies are required in order to build SPICE -Spice protocol >= 0.12.14 + Sp

Re: [Spice-devel] [PATCH spice-server 2/3] Update spice-protocol version

2019-04-26 Thread Victor Toso
d, 3 insertions(+), 3 deletions(-) > > diff --git a/README b/README > index 0905fe5b4..73286a537 100644 > --- a/README > +++ b/README > @@ -27,7 +27,7 @@ Or to install into a private user specific location > The following mandatory dependencies are required in order to > build

[Spice-devel] [PATCH spice-server 2/3] Update spice-protocol version

2019-04-26 Thread Frediano Ziglio
+++ b/README @@ -27,7 +27,7 @@ Or to install into a private user specific location The following mandatory dependencies are required in order to build SPICE -Spice protocol >= 0.12.14 + Spice protocol >= 0.14.0 Pixman >= 0.17.7 OpenSSL libjpeg diff --git a/con

Re: [Spice-devel] [spice-protocol] build-sys: add README.md and CHANGELOG.md to tarball

2019-04-12 Thread Eduardo Lima (Etrunko)
On 4/12/19 10:47 AM, Victor Toso wrote: > From: Victor Toso > > Before renaming README to README.md and NEWS to CHANGELOG.md, we were > shipping those files in the tarball. > > I'm fixing this in autotools because it is a 'regression' while > meson.build never had those included. > > Acked-by:

[Spice-devel] [spice-protocol] build-sys: add README.md and CHANGELOG.md to tarball

2019-04-12 Thread Victor Toso
From: Victor Toso Before renaming README to README.md and NEWS to CHANGELOG.md, we were shipping those files in the tarball. I'm fixing this in autotools because it is a 'regression' while meson.build never had those included. Acked-by: Victor Toso --- Makefile.am | 5 - 1 file changed, 4

Re: [Spice-devel] [spice-protocol v2 6/6] NEWS: prepare for 0.14.0 release

2019-04-12 Thread Victor Toso
Hi, On Fri, Apr 12, 2019 at 09:51:08AM -0300, Eduardo Lima (Etrunko) wrote: > On 4/10/19 7:20 AM, Victor Toso wrote: > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > > CHANGELOG.md | 12 > > 1 file changed, 12 insertions(+) > > > > diff --git a/CHANGELOG.md b/CH

Re: [Spice-devel] [spice-protocol v2 6/6] NEWS: prepare for 0.14.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
On 4/10/19 7:20 AM, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- > CHANGELOG.md | 12 > 1 file changed, 12 insertions(+) > > diff --git a/CHANGELOG.md b/CHANGELOG.md > index c78a58b..67888fd 100644 > --- a/CHANGELOG.md > +++ b/CHANGELOG.md > @@ -1,3

Re: [Spice-devel] [spice-protocol v2 5/6] README: Add basic info and .md prefix

2019-04-12 Thread Eduardo Lima (Etrunko)
> diff --git a/README b/README > deleted file mode 100644 > index e69de29..000 > diff --git a/README.md b/README.md > new file mode 100644 > index 000..244712f > --- /dev/null > +++ b/README.md > @@ -0,0 +1,27 @@ > +spice-protocol > +== > + &

Re: [Spice-devel] [spice-protocol v2 3/6] ChangeLog: remove old one

2019-04-12 Thread Eduardo Lima (Etrunko)
On 4/10/19 7:20 AM, Victor Toso wrote: > From: Victor Toso > > Added 193c54c in 2010-02-04 by Alexander Larsson > Signed-off-by: Victor Toso > --- > ChangeLog | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > delete mode 100644 ChangeLog > > diff --git a/ChangeLog b/ChangeLog > delete

Re: [Spice-devel] [spice-protocol v2 4/6] Rename NEWS to CHANGELOG.md

2019-04-12 Thread Eduardo Lima (Etrunko)
On 4/10/19 7:20 AM, Victor Toso wrote: > From: Victor Toso > > Uppercase + prefix to make Gitlab happy and format it properly. > This should also be the case for all other spice components in Gitlab. > > Signed-off-by: Victor Toso > --- > NEWS => CHANGELOG.md | 0 > 1 file changed, 0 insertion

Re: [Spice-devel] [spice-protocol v2 1/6] build-sys: automake: do not require NEWS and ChangeLog

2019-04-12 Thread Eduardo Lima (Etrunko)
1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 22c6008..b56f414 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -9,7 +9,7 @@ AC_INIT(spice-protocol, > [SPICE_MAJOR.SPICE_MINOR.SPICE_MICRO], [], spice-protoco > AC_C

Re: [Spice-devel] [spice-protocol v2 0/6] Prepare for 0.14.0 release

2019-04-12 Thread Eduardo Lima (Etrunko)
On 4/10/19 7:20 AM, Victor Toso wrote: > From: Victor Toso > > Changes from v1: > - Added gitlab-ci integration, you can see pipeline for this v2 > here: https://gitlab.freedesktop.org/victortoso/spice-protocol/-/jobs/227059 > - Relaxed automake in regards to NEWS, Change

  1   2   3   4   5   6   7   8   9   10   >