Re: [Spice-devel] OSX spice-gtk and pyparsing

2011-04-29 Thread Kai Mosebach
Hey, I am running spicy under OSX. If I press the 'a' key, nothing happens (within the guest). Can you please try if this is the same for you? Thanks Kai From: Cliff Sharp csh...@vbridges.com Date: Wed, 27 Apr 2011 17:10:33 -0500 To: Kai Mosebach kai.moseb...@bsse.ethz.ch Cc: Kai Mosebach

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Kai Mosebach
The slim barebone one :) Without all the gtk overhead... I think if the audio-interface was more portable it would make a pretty good starting point for porting. On 4/29/11 11:05 AM, Christophe Fergeau cferg...@redhat.com wrote: On Fri, Apr 29, 2011 at 10:56:11AM +0200, Kai Mosebach wrote: I

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Christophe Fergeau
On Fri, Apr 29, 2011 at 11:10:02AM +0200, Kai Mosebach wrote: The slim barebone one :) Without all the gtk overhead... What overhead? I think if the audio-interface was more portable it would make a pretty good starting point for porting. it? Something requiring X11 osx support isn't good

[Spice-devel] [PATCH 0/9] cleanup and warning fixes

2011-04-29 Thread Alon Levy
Split from the xspice rfc patches. Alon Levy (9): qxl.h: double include protection qxl_mem.c: fix pointer arithmatic warning (-Wpointer-arith) qxl_image.c: fix defined but unused warning qxl.h: move spice include right after system includes use spice-protocol defines for ring sizes

[Spice-devel] [PATCH 4/9] qxl.h: move spice include right after system includes

2011-04-29 Thread Alon Levy
--- src/qxl.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index 9451d05..d086ac7 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -27,6 +27,7 @@ #include stdint.h +#include spice/qxl_dev.h #include compiler.h #include xf86.h #if

[Spice-devel] [PATCH 9/9] cleanup (add eol between system and non system includes)

2011-04-29 Thread Alon Levy
--- src/qxl.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index d086ac7..a2daa8b 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -28,6 +28,7 @@ #include stdint.h #include spice/qxl_dev.h + #include compiler.h #include xf86.h #if

[Spice-devel] [RFCv2 01/21] qxl_ring: keep qxl pointer

2011-04-29 Thread Alon Levy
Add a qxl_screen_t* member to qxl_ring to make generelizing outb to ioport_write easier in the next patch. This means we do an extra deref and addition for every outb, but it means the code becomes simpler for doing outb in qxl_drv.so and a function call for spiceqxl_drv.so --- src/qxl.h|

[Spice-devel] [RFCv2 02/21] partially replace outb with ioport_write

2011-04-29 Thread Alon Levy
replace everywhere it is needed for xspice - places left out are ifdefed out later based on the same define mentioned in qxl.h, XSPICE. note: leave spaces between function name and open paren? --- src/qxl.h |2 ++ src/qxl_driver.c | 10 +- src/qxl_ring.c|5 +++--

[Spice-devel] [RFCv2 03/21] add config options (empty for now)

2011-04-29 Thread Alon Levy
--- src/qxl.h| 10 ++ src/qxl_driver.c |6 ++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/qxl.h b/src/qxl.h index de3bed7..8f16261 100644 --- a/src/qxl.h +++ b/src/qxl.h @@ -83,6 +83,14 @@ typedef struct typedef struct qxl_surface_t

[Spice-devel] [RFCv2 04/21] qxl_driver: add setup_slot helper

2011-04-29 Thread Alon Levy
used in qxl_reset. Later ifdefed with XSPICE, which only uses a single slot covering all memory (really it should just avoid calling the translation mechanism, but for now this is simple enough). --- src/qxl_driver.c | 87 ++ 1 files changed,

[Spice-devel] [RFCv2 06/21] xspice: add configure option and make target

2011-04-29 Thread Alon Levy
adds --enable-xspice, which builds an spiceqxl_drv.so target, and defines SUPPORT_XSPICE. Fails build if spice-server not found. --- configure.ac| 13 + src/Makefile.am | 23 +++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/configure.ac

[Spice-devel] [RFCv2 08/21] xspice: add spiceqxl_io_port, empty implementation

2011-04-29 Thread Alon Levy
--- src/Makefile.am|1 + src/qxl.h |8 src/spiceqxl_io_port.c | 12 src/spiceqxl_io_port.h |6 ++ 4 files changed, 27 insertions(+), 0 deletions(-) create mode 100644 src/spiceqxl_io_port.c create mode 100644 src/spiceqxl_io_port.h

[Spice-devel] [RFCv2 09/21] xspice: stop using pci and vga

2011-04-29 Thread Alon Levy
This ifdefs out all the parts in qxl_driver.c that are pci device specific and are not required by xspice. No functional change. The resulting spiceqxl_drv.so doesn't run. --- src/qxl.h|9 - src/qxl_driver.c | 89 +- 2 files

[Spice-devel] [RFCv2 13/21] xspice: implement map_helper, unmap_helper, add init_qxl_rom

2011-04-29 Thread Alon Levy
Memory is taken from malloc instead of from the pci bar. Adds shadow_rom to qxl_screen_t. Introduces init_qxl_rom, which is directly taken from the qxl device in qemu. Plenty of TODO's added in this commit about various constants and about factoring out the code to not do this copy paste from

[Spice-devel] [RFCv2 17/21] xspice: add init_qxl_ram

2011-04-29 Thread Alon Levy
--- src/qxl_driver.c |2 + src/spiceqxl_io_port.c | 49 src/spiceqxl_io_port.h |4 +++ 3 files changed, 55 insertions(+), 0 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index fe2f532..ef3139b 100644 ---

[Spice-devel] [RFCv2 20/21] xspice: README, config, launcher script

2011-04-29 Thread Alon Levy
--- README.xspice | 109 TODO.xspice| 27 + spiceqxl.xorg.conf | 15 +++ xspice | 21 ++ 4 files changed, 172 insertions(+), 0 deletions(-) create mode 100644 README.xspice create mode

[Spice-devel] [RFCv2 21/21] xspice/qxl_ring: yield when ring is full

2011-04-29 Thread Alon Levy
--- src/qxl_ring.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/qxl_ring.c b/src/qxl_ring.c index 0870ef1..02c4c35 100644 --- a/src/qxl_ring.c +++ b/src/qxl_ring.c @@ -75,7 +75,11 @@ qxl_ring_push (struct qxl_ring *ring, while (header-prod - header-cons

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Cliff Sharp
There are companies that only use spicec that don't want to make changes right now. On Fri, 2011-04-29 at 10:54 +0200, Christophe Fergeau wrote: On Thu, Apr 28, 2011 at 03:57:50PM -0500, Cliff Sharp wrote: I have spice-gtk built and running on OSX. It has some issues but it does connect. I

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Christophe Fergeau
On Fri, Apr 29, 2011 at 07:49:14AM -0400, Cliff Sharp wrote: There are companies that only use spicec that don't want to make changes right now. Not on OSX, do they? I'm really not understanding why using spice-gtk seems to be so bad for you :( Christophe pgpByFrLpGmPB.pgp Description: PGP

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Cliff Sharp
I never said that spice-gtk is bad for me. There are companies that need and use spicec. On Fri, 2011-04-29 at 14:06 +0200, Christophe Fergeau wrote: On Fri, Apr 29, 2011 at 07:49:14AM -0400, Cliff Sharp wrote: There are companies that only use spicec that don't want to make changes right

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Christophe Fergeau
On Fri, Apr 29, 2011 at 07:22:12AM -0500, Cliff Sharp wrote: I never said that spice-gtk is bad for me. There are companies that need and use spicec. Once again, why do they *need* it as opposed to they need a spice client, they don't really care if it's C, python, raw X, Qt, ... Saying these

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Cliff Sharp
Good question... Here are some recommendations -- There are a number of companies that interface to spicec programmatically. These companies right now do a fork exec or whatever to run spicec from within their software products. There are a number of reasons why they do not implement the spice

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Marc-André Lureau
Hi, - Original Message - There are a number of companies that interface to spicec programmatically. These companies right now do a fork exec or whatever to run spicec from within their software products. There are a number of reasons why they do not implement the spice protocol

Re: [Spice-devel] spicec and spice-gtk

2011-04-29 Thread Cliff Sharp
This is great - thank you On Apr 29, 2011, at 10:01 AM, Marc-André Lureau wrote: Hi, - Original Message - There are a number of companies that interface to spicec programmatically. These companies right now do a fork exec or whatever to run spicec from within their software

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-04-29 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: Code adapter from RedPeer::ssl_verify_callback() and used by spice-gtk. I looked at this one, and was quickly concerned about the amount of security checks we're trying to do on our own. Basically, we let openssl do the

Re: [Spice-devel] [PATCH 8/9] common: add ssl_verify.c common code

2011-04-29 Thread Christophe Fergeau
On Tue, Jan 25, 2011 at 07:17:27PM +0100, Marc-André Lureau wrote: diff --git a/common/ssl_verify.c b/common/ssl_verify.c new file mode 100644 index 000..f7d9482 --- /dev/null +++ b/common/ssl_verify.c @@ -0,0 +1,458 @@ +/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */