[Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-19 Thread Alon Levy
Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 in 0.8 branch - the syms file is updated to contain 0.8.3 and 0.8.4. Add an asynchronous version of update_area that updates the dirty rectangles, similarily to the sync one. The existing async version doesn't pass the dirty list

Re: [Spice-devel] [PATCH] server: spice_qxl_update_area_dirty_async

2012-02-19 Thread Alon Levy
On Sun, Feb 19, 2012 at 02:37:16PM +0200, Alon Levy wrote: > Bumps spice to 0.9.2, since it adds a new symbol. This will be 0.8.4 > in 0.8 branch - the syms file is updated to contain 0.8.3 and 0.8.4. Forgot to change this comment. I'll drop the 0.10.1->0.10.2 change since Marc Andre sent a patch

Re: [Spice-devel] [PATCH spice-gtk 6/7] usbredir: Add device rejected errors

2012-02-19 Thread Marc-André Lureau
On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > +                     G_OBJECT_CLASS_TYPE(gobject_class), Fails to build if usbredir is disabled: channel-usbredir.c: In function 'spice_usbredir_channel_class_init': channel-usbredir.c:151:40: error: 'gobject_class' undeclared (first use

Re: [Spice-devel] [PATCH spice-gtk 1/7] usb: Move various helper functions into usbutil.[c, h]

2012-02-19 Thread Marc-André Lureau
On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > +        return "Success"; did we disussed before that those strings should be translatable if they are shown to the user? the rest of the patch looks fine to me (given that we agree that some day, it should go in a usb library) -- Marc-

Re: [Spice-devel] [PATCH spice-gtk 2/7] usbutil: Add a spice_usb_util_get_device_strings helper function

2012-02-19 Thread Marc-André Lureau
ack On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > Signed-off-by: Hans de Goede > --- >  gtk/usb-device-manager.c |   32 >  gtk/usbutil.c            |   38 +- >  gtk/usbutil.h            |    8 +--- >  3 files cha

Re: [Spice-devel] [PATCH spice-gtk 3/7] usbutil: Add support for getting strings from usb.ids

2012-02-19 Thread Marc-André Lureau
ack On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > Unfortunately not all device makers go to the "trouble" of adding device > identification strings to a device's descriptors. This patch makes spice-gtk > translate vid/pid into strings if the device lacks the strings. > > Signed-off-by:

Re: [Spice-devel] [PATCH spice-gtk 4/7] usbredir: make channel lifetime equal to session lifetime

2012-02-19 Thread Marc-André Lureau
On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > +    if (!priv->host) > +        g_error("Out of memory allocating usbredirhost"); spice-gtk is a library, and should not abort a program using it. However, if it's for memory allocation reasons, then it does that already and it's the only

Re: [Spice-devel] [PATCH spice-gtk 5/7] usbredir: Shrink the usb device selection dialog when devices are unplugged

2012-02-19 Thread Marc-André Lureau
ack On Sun, Feb 19, 2012 at 12:50 AM, Hans de Goede wrote: > Signed-off-by: Hans de Goede > --- >  gtk/spicy.c |    9 + >  1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/gtk/spicy.c b/gtk/spicy.c > index cbc702e..2757bd7 100644 > --- a/gtk/spicy.c > +++ b/gtk/spicy.c >