Re: [Spice-devel] [PATCH 2/7] red_worker: rename epoll_timeout to event_timeout

2012-02-21 Thread Alon Levy
On Mon, Feb 20, 2012 at 06:11:26PM -0600, Dan McGee wrote: > On Mon, Feb 20, 2012 at 6:07 PM, Dan McGee wrote: > > On Fri, Feb 17, 2012 at 2:52 AM, Alon Levy wrote: > >> On Thu, Feb 16, 2012 at 11:30:08PM -0600, Dan McGee wrote: > >>> With future patches in mind that will allow for some other > >

Re: [Spice-devel] [PATCH 0/7] Series of patches to add non-Linux server support

2012-02-21 Thread Alon Levy
On Thu, Feb 16, 2012 at 11:30:06PM -0600, Dan McGee wrote: > This is a set of patches to enable building the server library on a non-Linux, > non-pure-GNU toolchain platform. The patches range from build system tweaks to > code changes. > I don't have any further problems with this patch series,

[Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-21 Thread Hans de Goede
Hi, I'm working on some better / prettier error reporting for the usb device widget, and I was wondering should we auto-redirect newly plugged in USB devices when auto-redir is enabled and they get plugged on while showing the USB device selection menu? Currently we do not do this since when w

Re: [Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 11:09:49AM +0100, Hans de Goede wrote: > Hi, > > I'm working on some better / prettier error reporting for the usb device > widget, and I > was wondering should we auto-redirect newly plugged in USB devices when > auto-redir > is enabled and they get plugged on while show

[Spice-devel] [PATCH] qxl: add 64bit pci bar

2012-02-21 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- spice/qxl_dev.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index 5e6ce06..a2af017 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -61,6 +61,12 @@ enum { QXL_VRAM_RANGE_INDEX, QXL_

Re: [Spice-devel] [PATCH] qxl: add 64bit pci bar

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:05:33PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann ACK. > --- > spice/qxl_dev.h |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h > index 5e6ce06..a2af017 100644 > --- a/spice/qxl_dev.

[Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
Spice protocol contains only headers. We would like to be able to use a protocol update without having to wait for the release, a git submodule works well for this purpose. --- .gitmodules|3 +++ autogen.sh |3 +++ configure.ac | 12 +++- spice-protocol |1 + 4 file

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 12:22 PM, Marc-André Lureau wrote: > Spice protocol contains only headers. We would like to be able to use > a protocol update without having to wait for the release, a git > submodule works well for this purpose. > --- >  .gitmodules    |    3 +++ >  autogen.sh     |    3

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: > Spice protocol contains only headers. We would like to be able to use > a protocol update without having to wait for the release, a git > submodule works well for this purpose. Looks good to me. I can revert my attempts to get jh

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 12:25 PM, Marc-André Lureau wrote: > -SUBDIRS = common gtk po python_modules doc data > +SUBDIRS = spice-protocol common gtk po python_modules doc data even better is DIST_SUBDIRS = spice-protocol $(SUBDIRS) So it doesn't get installed. (If needed, we can add "all-local"

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Gerd Hoffmann
> diff --git a/.gitmodules b/.gitmodules > new file mode 100644 > index 000..b628a96 > --- /dev/null > +++ b/.gitmodules > @@ -0,0 +1,3 @@ > +[submodule "spice-protocol"] > + path = spice-protocol > + url = git://anongit.freedesktop.org/spice/spice-protocol IIRC relative paths work the

[Spice-devel] setting up multihead virtual Win7 guest

2012-02-21 Thread Magnus Hagdorn
Hi all, I am struggling setting up a multi-headed (2) Win7 64bit guest using libvirt + kvm + spice on a SL 6.1 64bit host. I have the following versions: qemu-kvm-0.15.1-3.el6.x86_64 spice-protocol-0.9.1-1.el6.noarch spice-server-0.10.0-1.el6.x86_64 spice-client-0.10.0-1.el6.x86_64 libvirt-0.9.7-1

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
Hi On Tue, Feb 21, 2012 at 2:03 PM, Gerd Hoffmann wrote: >> +     url = git://anongit.freedesktop.org/spice/spice-protocol > > IIRC relative paths work there too and 'git submodule init' picks up the > path from the parent then.  So committers automagically get a > "ssh://..." url for the submodu

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Christophe Fergeau
On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: > Spice protocol contains only headers. We would like to be able to use > a protocol update without having to wait for the release, a git > submodule works well for this purpose. Do we still make spice-protocol releases after that?

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 2:28 PM, Christophe Fergeau wrote: > Do we still make spice-protocol releases after that? If not, which package > should distribute the spice-protocol headers? spice-gtk headers still depends on spice-protocol, although we should be able to fix that. I haven't investigated

[Spice-devel] [PATCH spice-gtk 1/6] usbredir: Add device rejected errors

2012-02-21 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/channel-usbredir.c | 84 -- gtk/channel-usbredir.h |4 ++ gtk/spicy.c |2 + gtk/usb-device-manager.c | 37 gtk/usb-device-manager.h |4 ++- gtk/usb-device-widget.

[Spice-devel] [PATCH spice-gtk 2/6] usbredir: Treat the user cancelling the policykit dialog as a cancel

2012-02-21 Thread Hans de Goede
Rather then treating it as any other error. This avoids showing an error dialog after the user pressed cancel in the policykit dialog. Signed-off-by: Hans de Goede --- gtk/spice-client-glib-usb-acl-helper.c |5 + gtk/usb-acl-helper.c | 13 ++--- 2 files change

[Spice-devel] [PATCH spice-gtk 3/6] configure: Fix "USB redirection support" summary on --disable-usbredir

2012-02-21 Thread Hans de Goede
When running "./configure --disable-usbredir" the "USB redirection support" line in the summary at the end of ./configure would be empty after "support" instead of ending with yes or no. Signed-off-by: Hans de Goede --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[Spice-devel] [PATCH spice-gtk 4/6] usb-device-widget: Use an info_bar for error messages

2012-02-21 Thread Hans de Goede
And in general gnome-hig-ify usb-device-widget: * Use spacing instead of padding so that there is no padding at the outside/border of the widget, allowing the user to control the border size. * Use multiple of 6 as spacing / indentation values * Show the label left justified and bold, show the ch

[Spice-devel] [PATCH spice-gtk 5/6] usbredir: Add a spice_usb_device_manager_can_redirect_device function

2012-02-21 Thread Hans de Goede
Add a spice_usb_device_manager_can_redirect_device function and use this in SpiceUsbDeviceWidget to check if redirection is available. Signed-off-by: Hans de Goede --- gtk/map-file |1 + gtk/usb-device-manager.c | 71 +--- gtk/usb-device-manager.h |

[Spice-devel] [PATCH spice-gtk 6/6] usbredir: Add awareness of host/guest side filtering

2012-02-21 Thread Hans de Goede
Signed-off-by: Hans de Goede --- gtk/channel-usbredir-priv.h |6 ++ gtk/channel-usbredir.c | 19 --- gtk/usb-device-manager.c| 18 +- 3 files changed, 39 insertions(+), 4 deletions(-) diff --git a/gtk/channel-usbredir-priv.h b/gtk/channel-usbr

Re: [Spice-devel] Should we auto-redirect USB devices when we show the USB device selection menu?

2012-02-21 Thread Hans de Goede
Hi, On 02/21/2012 11:35 AM, Alon Levy wrote: On Tue, Feb 21, 2012 at 11:09:49AM +0100, Hans de Goede wrote: Hi, I'm working on some better / prettier error reporting for the usb device widget, and I was wondering should we auto-redirect newly plugged in USB devices when auto-redir is enabled

Re: [Spice-devel] [PATCH 5/7] red_worker: reimplement event loop using poll()

2012-02-21 Thread Dan McGee
On Fri, Feb 17, 2012 at 7:34 AM, Paolo Bonzini wrote: > On 02/17/2012 02:18 PM, Alon Levy wrote: >>> > - guaranteed bitrot in the poll() path :) >>> > >> Yeah, I guess you are right. I'm worried since I don't know the >> difference in performance between epoll and poll > > You can assume it to be

Re: [Spice-devel] [PATCH 0/7] Series of patches to add non-Linux server support

2012-02-21 Thread Dan McGee
On Fri, Feb 17, 2012 at 3:06 AM, Alon Levy wrote: > On Thu, Feb 16, 2012 at 11:30:06PM -0600, Dan McGee wrote: > > The title says non-linux, when in fact it's obvious from the rest of > what you write that the use case is Solaris. Why not say that? Because these patches should help just as much t

Re: [Spice-devel] [PATCH 1/7] Add configure-time check for -Wl, --version-script option

2012-02-21 Thread Dan McGee
On Fri, Feb 17, 2012 at 4:21 AM, Daniel P. Berrange wrote: > The Solaris linker does actually support version scripts using the > exact same file syntax as the GNU linker. The only thing that is different > is the linker command line arg. Yes, using the -M option, I did see that much. > Mingw32 s

Re: [Spice-devel] Windows guest hangs while doing shutdown with dual monitors.

2012-02-21 Thread Naga Mohan Pothula
Hi Christophe/Aon, Debugging is not possible for this scenario and hence stack trace could not be retrieved. Please find the attached spicec_mf.log(Failure case - dual monitor with Full-screen+Auto-conf), spicec_sf.log(Success case - single monitor with Full-screen+Auto-conf) files. These log f

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Kai Meyer
On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice from inside a VM on my local machine to vie

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Yonit Halperin
On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expectations straight. Should I be able to use spice fr

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 10:49:04AM -0700, Kai Meyer wrote: > > > On 02/20/2012 05:19 AM, Yonit Halperin wrote: > >Hi, > >On 02/15/2012 06:22 PM, Kai Meyer wrote: > >> > >> > >>On 02/15/2012 05:19 AM, Yonit Halperin wrote: > >>>On 02/15/2012 01:16 AM, Kai Meyer wrote: > Help me set my expectat

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 02:28:06PM +0100, Christophe Fergeau wrote: > On Tue, Feb 21, 2012 at 12:22:43PM +0100, Marc-André Lureau wrote: > > Spice protocol contains only headers. We would like to be able to use > > a protocol update without having to wait for the release, a git > > submodule works

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Kai Meyer
On 02/21/2012 12:34 PM, Yonit Halperin wrote: On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me set my expect

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Kai Meyer
On 02/21/2012 10:57 AM, Alon Levy wrote: On Tue, Feb 21, 2012 at 10:49:04AM -0700, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 AM, Kai Meyer wrote: Help me se

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Yonit Halperin
On 02/21/2012 09:56 PM, Kai Meyer wrote: On 02/21/2012 12:34 PM, Yonit Halperin wrote: On 02/21/2012 07:49 PM, Kai Meyer wrote: On 02/20/2012 05:19 AM, Yonit Halperin wrote: Hi, On 02/15/2012 06:22 PM, Kai Meyer wrote: On 02/15/2012 05:19 AM, Yonit Halperin wrote: On 02/15/2012 01:16 A

[Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
This is the second attempt to fix this issue, as a lesson from the last time it doesn't try to use an async monitor command. So with this patchset, in qxl mode, a screendump monitor command will complete before the file is written to disk. This is much better then a hang. To fix it does require

[Spice-devel] [RFC v4 1/9] console: don't call console_select unnecessarily

2012-02-21 Thread Alon Levy
From: Gerd Hoffman Tested-by: Alon Levy --- console.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/console.c b/console.c index 135394f..cfcc2f7 100644 --- a/console.c +++ b/console.c @@ -181,12 +181,14 @@ void vga_hw_screen_dump(const char *filename) /* T

[Spice-devel] [RFC v4 2/9] sdl: remove NULL check, g_malloc0 can't fail

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy --- ui/sdl.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 6f8091c..f6f711c 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -167,10 +167,6 @@ static PixelFormat sdl_to_qemu_pixelformat(SDL_PixelFormat *sdl_pf) static Displ

[Spice-devel] [RFC v4 3/9] qxl: drop qxl_spice_update_area_async definition

2012-02-21 Thread Alon Levy
It was never used. Introduced in 5ff4e36c804157bd84af43c139f8cd3a59722db9 qxl: async io support using new spice api But not used even then. Signed-off-by: Alon Levy --- hw/qxl.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/hw/qxl.h b/hw/qxl.h index 766aa6d..6399

[Spice-devel] [RFC v4 4/9] qxl: screen_dump in vga: do a single ppm_save

2012-02-21 Thread Alon Levy
Using vga->screen_dump results in a number of calls to ppm_save, instead of a single one. Lacking time to test all the possible users of vga->screen_dump, avoid the redundant calls by doing the vga_hw_update+ ppm_save in qxl_hw_screen_dump. Signed-off-by: Alon Levy --- hw/qxl.c | 10 --

[Spice-devel] [RFC v4 6/9] qxl: remove flipped

2012-02-21 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl-render.c | 58 ++- hw/qxl.h|2 +- 2 files changed, 20 insertions(+), 40 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 133d093..4518a56 100644 --- a/hw/qxl-render.c +++ b/hw/q

[Spice-devel] [RFC v4 5/9] qxl: require spice >= 0.8.2

2012-02-21 Thread Alon Levy
drop all ifdefs on SPICE_INTERFACE_QXL_MINOR >= 1 as a result, 0.8.2 has SPICE_INTERFACE_QXL_MINOR == 1. Signed-off-by: Alon Levy --- configure |2 +- hw/qxl.c | 40 hw/qxl.h |4 ui/spice-display.c | 12 --

[Spice-devel] [RFC v4 7/9] qxl: introduce QXLCookie

2012-02-21 Thread Alon Levy
Will be used in the next patch. Signed-off-by: Alon Levy --- hw/qxl-render.c|2 +- hw/qxl.c | 58 --- hw/qxl.h |2 +- ui/spice-display.c | 22 +-- ui/spice-display.h | 14 5 files c

[Spice-devel] [RFC v4 8/9] qxl: make qxl_render_update async

2012-02-21 Thread Alon Levy
RHBZ# 747011 Removes the last user of QXL_SYNC when using update drivers that use the _ASYNC io ports. The last user is qxl_render_update, it is called both by qxl_hw_update which is the vga_hw_update_ptr passed to graphic_console_init, and by qxl_hw_screen_dump. At the same time the QXLRect are

[Spice-devel] [RFC v4 9/9] qxl-render: call ppm_save on bh

2012-02-21 Thread Alon Levy
This changes the behavior of the monitor command. After the previous patch, there is no longer an option of deadlock with virt-manager, but ppm_save is called too early, before the update has completed. With this patch it is called at the correct moment, but that means there is a race between the m

Re: [Spice-devel] Performance expectations

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 12:58:55PM -0700, Kai Meyer wrote: > > > On 02/21/2012 10:57 AM, Alon Levy wrote: > >On Tue, Feb 21, 2012 at 10:49:04AM -0700, Kai Meyer wrote: > >> > >>On 02/20/2012 05:19 AM, Yonit Halperin wrote: > >>>Hi, > >>>On 02/15/2012 06:22 PM, Kai Meyer wrote: > > On 02/

Re: [Spice-devel] [RFC v4 0/9] qxl: fix hangs caused by qxl_render_update

2012-02-21 Thread Alon Levy
On Tue, Feb 21, 2012 at 11:39:28PM +0200, Alon Levy wrote: > This is the second attempt to fix this issue, as a lesson from the last time > it doesn't try to use an async monitor command. So with this patchset, in qxl > mode, a screendump monitor command will complete before the file is written

Re: [Spice-devel] [PATCH spice-gtk] RFC: Use spice protocol as a submodule

2012-02-21 Thread Marc-André Lureau
On Tue, Feb 21, 2012 at 6:48 PM, Alon Levy wrote: > We will still need releases for anyone building from tarballs, which > includes all distribution built packages. Not with the submodule & autofoo solution I proposed for spice-gtk. -- Marc-André Lureau _

[Spice-devel] Problem to render cursor in SDL/VNC using QXL driver

2012-02-21 Thread Fabiano Fidêncio
Howdy! I found out the problem. It was a regression introduced by commit 075360945860ad9bdd491921954b383bf762b0e5, in QEMU (almost had a birthday). There's one attached patch, that reverts the problematic commit and fixes the conflicts. So, could you take a look and apply? Best Regards, -- Fabian