On Wed, Sep 12, 2012 at 04:52:40AM +0100, Peter Robinson wrote:
> >> From: Peter Robinson
>
> Can I have this committed as pbrobin...@redhat.com if its not too late?
Ah sorry, I've already pushed it :-/ I'll try to remember next time...
Christophe
pgpt7oG43rV0G.pgp
Description: PGP signature
> On 09/11/12 17:32, Alon Levy wrote:
> >> Hi,
> >>
> >> On 09/11/2012 04:35 PM, Alon Levy wrote:
> >>> So far we have used the agent to notify the guest of a request to
> >>> change
> >>> the monitors configurations (heads) on the qxl device. This patch
> >>> introduces
> >>> a new interrupt and n
Hi,
On 09/12/2012 10:24 AM, Alon Levy wrote:
On 09/11/12 17:32, Alon Levy wrote:
Hi,
On 09/11/2012 04:35 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to
change
the monitors configurations (heads) on the qxl device. This patch
introduces
a new interrupt a
On Mon, Sep 10, 2012 at 10:58:20AM +0100, Peter Robinson wrote:
> On Mon, Sep 10, 2012 at 9:59 AM, Alon Levy wrote:
> >> Hi,
> >>
> >> FYI: spice reportly works just fine on arm, see:
> >>
> >> https://bugzilla.redhat.com/show_bug.cgi?id=613529
> >>
> >> Just a little configure patch is required.
Hey,
On Wed, Sep 12, 2012 at 05:06:44AM +0200, Søren Sandmann wrote:
> Jeremy White writes:
>
> > The following patch series remove nearly all warnings from
> > xf86-video-qxl.
>
> Some general comments:
>
> - You have this pattern where you assign a string to a global variable
> and then yo
> Jeremy White writes:
>
> > Hey Alon (and all),
> >
> > Could this patch be done instead with an #ifdef on
> > XORG_VERSION_CURRENT?
> >
> > It'd be nice if the tip of spice could continue to be useful with
> > older
> > Xorgs (said a guy who's focused on RHEL development... :-/).
> >
> > If tha
v3:
- no addition of guest capabilities, use interrupt mask instead, ignore
0 or ~0 that are set by current windows driver.
- use crc to solve possible write while read.
- limit heads to 64, statically allocated on rom by host.
- some misc trace fixes.
QEMU:
Alon Levy (3):
hw/qxl: tracin
Add two new trace events:
qxl_send_events(int qid, uint32_t events) "%d %d"
qxl_set_guest_bug(int qid) "%d"
Change qxl_io_unexpected_vga_mode parameters to be equivalent to those
of qxl_io_write for easier grouping under a single systemtap probe.
Change d to qxl in one place.
Signed-off-by: Alon
Signed-off-by: Alon Levy
---
hw/qxl.c | 1 +
trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/qxl.c b/hw/qxl.c
index 94eb3c8..12dfc79 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1503,6 +1503,7 @@ async_common:
qxl_set_mode(d, val, 0);
break;
case QXL_I
Until now we used only the agent to change the monitor count and each
monitor resolution. This patch introduces the qemu part of using the
device as the mediator instead of the agent via virtio-serial.
Spice (>=0.11.5) calls the new QXLInterface::client_monitors_config,
which returns wether the in
So far we have used the agent to notify the guest of a request to change
the monitors configurations (heads) on the qxl device. This patch introduces
a new interrupt and new fields in the qxl rom to notify the guest about
a new request, similarly to how physical hardware notifies the driver.
To av
New in this release:
display channel: A8 surface capability
qxl: client present, client capabilities and client monitors configuration.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index b4a9cca..d80c360 100644
--- a/configure.a
Add support for client monitors config in qxl device.
---
spice-protocol | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-protocol b/spice-protocol
index 361fd16..9170263 16
--- a/spice-protocol
+++ b/spice-protocol
@@ -1 +1 @@
-Subproject commit 361fd166b26b4450617b1f
---
server/red_dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index 69d4f0a..3a4229e 100644
--- a/server/red_dispatcher.c
+++ b/server/red_dispatcher.c
@@ -91,7 +91,7 @@ static void red_dispatcher_set_display_peer(
For qxl client_monitors_config support.
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index f67bcd0..31c5fc1 16
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit f67bcd03e92c2d04f987135ad9b467c93fd47908
+Subp
Used to implement guest monitor configuration change similarly to real
hardware in conjunction with the new qemu interrupt
QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. client_monitors_config is also
used to probe the support by the interface. If it is not supported we
send the message to the guest agent.
Adds two functions:
- red_dispatcher_use_client_monitors_config:
check that QXLInterface supports client_monitors_config and that it's
functional.
- red_dispatcher_client_monitors_config:
send the client monitors configuration to the guest.
---
server/red_dispatcher.c | 49 +
If the guest supports client monitors config we pass it the
VDAgentMonitorsConfig message via the
QXLInterface::client_monitors_config api instead of via the vdagent.
---
server/agent-msg-filter.c | 8 ++
server/agent-msg-filter.h | 1 +
server/reds.c | 65 +++
---
server/tests/basic_event_loop.c| 2 +-
server/tests/test_display_base.c | 46 ++
server/tests/test_display_base.h | 1 +
server/tests/test_display_no_ssl.c | 1 +
4 files changed, 49 insertions(+), 1 deletion(-)
diff --git a/server/tests/basic_ev
Added api:
QXL interface (3.2)
client_monitors_config
---
configure.ac | 6 +++---
server/spice.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1c57110..0545af6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12,10 +12,10 @@ AC_PRERE
Hi,
On 09/12/2012 03:13 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to change
the monitors configurations (heads) on the qxl device. This patch introduces
a new interrupt and new fields in the qxl rom to notify the guest about
a new request, similarly to h
> Hi,
>
> On 09/12/2012 03:13 PM, Alon Levy wrote:
> > So far we have used the agent to notify the guest of a request to
> > change
> > the monitors configurations (heads) on the qxl device. This patch
> > introduces
> > a new interrupt and new fields in the qxl rom to notify the guest
> > about
>
Hi,
On 09/12/2012 03:13 PM, Alon Levy wrote:
So far we have used the agent to notify the guest of a request to change
the monitors configurations (heads) on the qxl device. This patch introduces
a new interrupt and new fields in the qxl rom to notify the guest about
a new request, similarly to h
> Some general comments:
>
> - You have this pattern where you assign a string to a global variable
> and then you assign that variable to a field instead of the string
> itself. If this really is necessary, I think the string should just be
> cast instead. I haven't been able to make gcc ge
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
---
server/red_dispatcher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c
index 69d4f0a..3a4229e 100644
--- a/server/red_dispatcher.c
+++ b/server/red_dispatcher.c
@@ -91,7 +9
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
For qxl client_monitors_config support.
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index f67bcd0..31c5fc1 16
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject co
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
Used to implement guest monitor configuration change similarly to real
hardware in conjunction with the new qemu interrupt
QXL_INTERRUPT_CLIENT_MONITORS_CONFIG. client_monitors_config is also
used to probe the support by the interface. If it is not s
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
Adds two functions:
- red_dispatcher_use_client_monitors_config:
check that QXLInterface supports client_monitors_config and that it's
functional.
- red_dispatcher_client_monitors_config:
send the client monitors configuration to the
Hi,
On 09/12/2012 03:13 PM, Alon Levy wrote:
If the guest supports client monitors config we pass it the
VDAgentMonitorsConfig message via the
QXLInterface::client_monitors_config api instead of via the vdagent.
---
server/agent-msg-filter.c | 8 ++
server/agent-msg-filter.h | 1 +
ser
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
---
server/tests/basic_event_loop.c| 2 +-
server/tests/test_display_base.c | 46 ++
server/tests/test_display_base.h | 1 +
server/tests/test_display_no_ssl.c | 1 +
4 files changed, 49 insertions
ACK.
On 09/12/2012 03:13 PM, Alon Levy wrote:
Added api:
QXL interface (3.2)
client_monitors_config
---
configure.ac | 6 +++---
server/spice.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1c57110..0545af6 100644
--- a/config
BN_new returns NULL on allocation failures. Given that we abort
on malloc allocation failures, we should also abort here. The
current code will segfault when BN_new fails as it immediatly tries
to use the NULL pointer.
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
We used to be aborting in such situations, but this was changed
during the big spice_error/printerr cleanup. We are currently
outputting a warning but not reporting the error with the caller
when reds_init_net fails to register listening watches with the
mainloop. As it's unlikely that things will
Errors occurring in reds_init_ssl used to be fatal through the use
of spice_error, but this was downgraded to non-fatal spice_warning
calls recently. This means we no longer error out when invalid SSL
(certificates, ...) parameters are passed by the user.
This commit changes reds_init_ssl return va
Now that this function can fail, propagate any error up to the
caller. This allows qemu to fail when an SSL initialization error
occurred.
---
server/reds.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 0cd3f40..983ca0f 100644
--- a/serv
---
server/reds.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 2d312e9..3ed8c67 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3301,7 +3301,9 @@ static int reds_init_ssl(void)
SSL_CTX_set_session_id_context(reds->ctx, (const
---
server/reds.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 983ca0f..2d312e9 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3160,25 +3160,30 @@ static int reds_init_net(void)
return 0;
}
-static void load_dh_p
This used to abort with spice_error. The caller currently does
not check spice_server_char_device_add_interface return value, but
it's still cleaner to report an error in this case.
---
server/reds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.c b/server/reds.c
index 3ed8c67..d
Hi,
I have a quick question regarding SPICE resolution support.
On many documents I can read that the max is 2560x1600 = 4,096,000 pixels.
At the same time, I saw several pieces of code with highres modes such as
QXL_MODE_EX(2560, 2048).
Is it possible to drive a 2048x2048 square monitor under L
Guillaume Sabouraud píše v St 12. 09. 2012 v 11:46 +0200:
> Hi,
>
> I have a quick question regarding SPICE resolution support.
>
> On many documents I can read that the max is 2560x1600 = 4,096,000
> pixels. At the same time, I saw several pieces of code with highres
> modes such as QXL_MODE_EX(
David Jaša píše v St 12. 09. 2012 v 17:17 +0200:
> Guillaume Sabouraud píše v St 12. 09. 2012 v 11:46 +0200:
> > Hi,
> >
> > I have a quick question regarding SPICE resolution support.
> >
> > On many documents I can read that the max is 2560x1600 = 4,096,000
> > pixels. At the same time, I saw s
This lets us continue to support older Xorg releases.
This reverts 4f37cd85 and partially reverts 4a43bd4.
---
configure.ac |2 +-
src/qxl_driver.c |6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index b8a4b35..11ef73c 100644
--- a/
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 98b316d..57ce88b 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1208,7 +1208,7 @@ void reds_on_main_agent_data(MainChannelClient *mcc, void
*message, size_t size)
hea
If the guest supports client monitors config we pass it the
VDAgentMonitorsConfig message via the
QXLInterface::client_monitors_config api instead of via the vdagent.
---
server/agent-msg-filter.c | 8 +++
server/agent-msg-filter.h | 1 +
server/reds.c | 55 ++
On 09/12/2012 07:32 PM, Mohsen Saeedi wrote:
Hi
I want to know, we are force to install one windows per user? does spice
can provide a multi remote connection to a single windows XP machine?
I want to install one windows XP as virtual desktop and then share it
with more than one users.is it possi
45 matches
Mail list logo
