Re: [Spice-devel] [spice-gtk PATCH] Ability to release the cursor with a keyboard shortcut

2014-10-06 Thread Pavel Grunt
NACK, it's causing problems on vm shutdown - Original Message - From: Pavel Grunt pgr...@redhat.com To: spice-devel@lists.freedesktop.org Cc: Pavel Grunt pgr...@redhat.com Sent: Thursday, October 2, 2014 8:12:49 AM Subject: [Spice-devel][spice-gtk PATCH] Ability to release the cursor

[Spice-devel] [v2: PATCH 3/3] Add support to handle username when connecting with SASL

2014-10-06 Thread Fabiano Fidêncio
Based on a patch from Dietmar Maurer diet...@proxmox.com http://lists.freedesktop.org/archives/spice-devel/2013-October/015138.html --- Changes since v1: - Change the commit author - Add spice-channel.c to POTFILES.in - Keeping looking for SASL_CB_USER|SASL_CB_AUTHNAME even after SASL_CB_PASS is

[Spice-devel] [v2: PATCH 2/3] Add username property to SpiceSession

2014-10-06 Thread Fabiano Fidêncio
From: Dietmar Maurer diet...@proxmox.com --- Changes since v1: - Add a description for the new 'username' property --- gtk/spice-session-priv.h | 2 ++ gtk/spice-session.c | 43 +-- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git

[Spice-devel] [v2: PATCH 1/3] Add SpiceChannelError

2014-10-06 Thread Fabiano Fidêncio
SpiceChannelError, for now, will be used to set more detailed errors with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. --- Changes since v1: - Change the SpiceChannelAuthError comments to match with the enum values - Add more details related to SPICE_CHANNEL_ERROR_AUTH ---

Re: [Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

2014-10-06 Thread Fabiano Fidêncio
On Thu, Sep 18, 2014 at 4:31 PM, Pavel Grunt pgr...@redhat.com wrote: When a file transfer starts / finishes an information message is printed (in INFO log level). Also INFO messages about the transfer progress are periodically printed. --- changes since v4: - logging is enabled when

Re: [Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

2014-10-06 Thread Marc-André Lureau
- Original Message - When a file transfer starts / finishes an information message is printed (in INFO log level). Also INFO messages about the transfer progress are periodically printed. Why info level and not debug? I am not fond adding more code to the Xfer code limited by

Re: [Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

2014-10-06 Thread Pavel Grunt
Thanks for the review. I used info level because it was requested in https://bugzilla.redhat.com/show_bug.cgi?id=1140512#c0 - Original Message - When a file transfer starts / finishes an information message is printed (in INFO log level). Also INFO messages about the transfer

Re: [Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

2014-10-06 Thread Marc-André Lureau
- Original Message - Thanks for the review. I used info level because it was requested in https://bugzilla.redhat.com/show_bug.cgi?id=1140512#c0 thanks, I left a comment in the bug. . ___ Spice-devel mailing list

Re: [Spice-devel] [v2: PATCH 2/3] Add username property to SpiceSession

2014-10-06 Thread Christophe Fergeau
On Mon, Oct 06, 2014 at 01:52:44PM +0200, Fabiano Fidêncio wrote: From: Dietmar Maurer diet...@proxmox.com --- Changes since v1: - Add a description for the new 'username' property --- gtk/spice-session-priv.h | 2 ++ gtk/spice-session.c | 43

Re: [Spice-devel] [v2: PATCH 1/3] Add SpiceChannelError

2014-10-06 Thread Christophe Fergeau
ACK On Mon, Oct 06, 2014 at 01:52:43PM +0200, Fabiano Fidêncio wrote: SpiceChannelError, for now, will be used to set more detailed errors with respect to the main channel event SPICE_CHANNEL_ERROR_AUTH. --- Changes since v1: - Change the SpiceChannelAuthError comments to match with the enum

Re: [Spice-devel] [v2: PATCH 3/3] Add support to handle username when connecting with SASL

2014-10-06 Thread Christophe Fergeau
ACK On Mon, Oct 06, 2014 at 01:52:45PM +0200, Fabiano Fidêncio wrote: Based on a patch from Dietmar Maurer diet...@proxmox.com http://lists.freedesktop.org/archives/spice-devel/2013-October/015138.html --- Changes since v1: - Change the commit author - Add spice-channel.c to POTFILES.in

Re: [Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

2014-10-06 Thread Christophe Fergeau
On Mon, Oct 06, 2014 at 08:35:05AM -0400, Marc-André Lureau wrote: - Original Message - When a file transfer starts / finishes an information message is printed (in INFO log level). Also INFO messages about the transfer progress are periodically printed. Why info level and

Re: [Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

2014-10-06 Thread Christophe Fergeau
On Mon, Oct 06, 2014 at 02:06:29PM +0200, Fabiano Fidêncio wrote: On Thu, Sep 18, 2014 at 4:31 PM, Pavel Grunt pgr...@redhat.com wrote: When a file transfer starts / finishes an information message is printed (in INFO log level). Also INFO messages about the transfer progress are