[Spice-devel] master build for windows

2015-06-08 Thread Kirill Moizik
Hi, I can't build spice-gtk for windows, i got next error: channel-webdav.c: In function 'demux_to_client_cb': channel-webdav.c:321:5: error: implicit declaration of function 'g_output_stream_write_all_finish' [-Werror=implicit-function-declaration] It seem the cause of this problem is this

Re: [Spice-devel] [PATCH] Allow Qemu to pass maximum head to guest

2015-06-08 Thread Marc-André Lureau
On Mon, Jun 8, 2015 at 7:24 PM, Frediano Ziglio fzig...@redhat.com wrote: Hi, the idea behind this is to be able from libvirt to set the number of heads. Other cards (like vmware) support this heads setting. Actually is expected to work with QXL using Windows guest as in this

Re: [Spice-devel] [PATCH] Allow Qemu to pass maximum head to guest

2015-06-08 Thread Frediano Ziglio
Hi Frediano - Original Message - Add a max_head field to QXLRom so Qemu can specify the maximum heads it wants. This to support heads argument in libvirt properly. Padding fields are added to make the structure multiple of 8 bytes. This as Qemu append to this structure some

Re: [Spice-devel] master build for windows

2015-06-08 Thread Fabiano Fidêncio
On Mon, Jun 8, 2015 at 8:10 PM, Kirill Moizik kir...@daynix.com wrote: Hi, I can't build spice-gtk for windows, i got next error: channel-webdav.c: In function 'demux_to_client_cb': channel-webdav.c:321:5: error: implicit declaration of function 'g_output_stream_write_all_finish'

[Spice-devel] [PATCH spice] server: Round the framerate estimate to the nearest integer.

2015-06-08 Thread Francois Gouget
This is more accurate for typical values like 23.976 fps. --- server/red_worker.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index cc0a116..0207977 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -3159,15

[Spice-devel] [PATCH spice-gtk] RFC: prepare for 0.29 release

2015-06-08 Thread Marc-André Lureau
--- NEWS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS b/NEWS index ad6b7a3..1a6f7a3 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,13 @@ +v0.29 += + +- sync guest audio volume with client volume +- use stream volume for PulseAudio source +- on Windows, fail early during

Re: [Spice-devel] [spice-gtk PATCH 0/3] spicy: Rewrite of connect dialog

2015-06-08 Thread Marc-André Lureau
Hi - Original Message - Connect dialog was hardcoded, and didn't have a parent window. Changed dialog to a window, because spicy creates no window prior to creating the dialog. No parent can be supplied. Moved UI definition from code to XML. Moved the dialog code to its own

[Spice-devel] [spice-gtk PATCH 1/3] spicy-connect: Connect dialog changed to window

2015-06-08 Thread Lukas Venhoda
Connect dialog in spicy had no transinient parent. It didn't make much sense for it to be a dialog. Changed the dialog to window. Moved UI definition from code to XML. Moved dialog to its own module. --- gtk/spicy-connect.c | 197 ++

[Spice-devel] [spice-gtk PATCH 2/3] spicy-connect: Added new source files to Makefile

2015-06-08 Thread Lukas Venhoda
--- gtk/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk/Makefile.am b/gtk/Makefile.am index 25e2255..55ea0db 100644 --- a/gtk/Makefile.am +++ b/gtk/Makefile.am @@ -379,6 +379,8 @@ endif spicy_SOURCES =\ spicy.c

[Spice-devel] [spice-gtk PATCH 3/3] spicy: Removed connect dialog from spicy.c

2015-06-08 Thread Lukas Venhoda
Removed original connect dialog code from spicy.c --- gtk/spicy.c | 125 +--- 1 file changed, 2 insertions(+), 123 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 9cd6ee5..364215a 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@

[Spice-devel] [spice-gtk PATCH 0/3] spicy: Rewrite of connect dialog

2015-06-08 Thread Lukas Venhoda
Connect dialog was hardcoded, and didn't have a parent window. Changed dialog to a window, because spicy creates no window prior to creating the dialog. No parent can be supplied. Moved UI definition from code to XML. Moved the dialog code to its own module. Lukas Venhoda (3): spicy-connect:

Re: [Spice-devel] When will next version of SPICE Server be released?

2015-06-08 Thread Fabio Fantoni
Il 08/06/2015 16:24, Christophe Fergeau ha scritto: Hi, On Fri, Jun 05, 2015 at 06:13:09PM +0300, Kalyanov Dmitry wrote: Hello, spice-devel, I've noticed that SPICE Server is still at 0.12.5 for quite some time. I wonder when next version will be tagged and released? I'm asking because I

Re: [Spice-devel] [spice-gtk PATCH 1/3] spicy-connect: Connect dialog changed to window

2015-06-08 Thread Pavel Grunt
Hi Lukas, I know it is acked and that spicy is just a test tool, but I have some comments... The dialog looks different in gkt2 than in gtk3 (also different from the hardcoded dialog - the text is centered, smaller margins). Few comments inline Pavel On Mon, 2015-06-08 at 11:36 +0200, Lukas

Re: [Spice-devel] When will next version of SPICE Server be released?

2015-06-08 Thread Christophe Fergeau
Hi, On Fri, Jun 05, 2015 at 06:13:09PM +0300, Kalyanov Dmitry wrote: Hello, spice-devel, I've noticed that SPICE Server is still at 0.12.5 for quite some time. I wonder when next version will be tagged and released? I'm asking because I want to use QEMU's support for UNIX domain socket

Re: [Spice-devel] [PATCH spice-gtk] usb-device-manager: Avoid error when compiling with --disable-usbredir

2015-06-08 Thread Marc-André Lureau
ack - Original Message - --- gtk/usb-device-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index d700dcd..12ad4ba 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -230,9

[Spice-devel] [PATCH] Allow Qemu to pass maximum head to guest

2015-06-08 Thread Frediano Ziglio
Add a max_head field to QXLRom so Qemu can specify the maximum heads it wants. This to support heads argument in libvirt properly. Padding fields are added to make the structure multiple of 8 bytes. This as Qemu append to this structure some fields for mode settings. As this structure is packed

[Spice-devel] [PATCH spice-gtk] usb-device-manager: Avoid error when compiling with --disable-usbredir

2015-06-08 Thread Pavel Grunt
--- gtk/usb-device-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c index d700dcd..12ad4ba 100644 --- a/gtk/usb-device-manager.c +++ b/gtk/usb-device-manager.c @@ -230,9 +230,9 @@ static gboolean

Re: [Spice-devel] [spice-gtk PATCH 1/3] spicy-connect: Connect dialog changed to window

2015-06-08 Thread Christophe Fergeau
On Mon, Jun 08, 2015 at 11:36:36AM +0200, Lukas Venhoda wrote: Connect dialog in spicy had no transinient parent. It didn't make much sense for it to be a dialog. Changed the dialog to window. Moved UI definition from code to XML. Moved dialog to its own module. --- gtk/spicy-connect.c

Re: [Spice-devel] When will next version of SPICE Server be released?

2015-06-08 Thread Javier Celaya
El Lunes, 8 de junio de 2015 16:35:24 Fabio Fantoni escribió: Il 08/06/2015 16:24, Christophe Fergeau ha scritto: Hi, On Fri, Jun 05, 2015 at 06:13:09PM +0300, Kalyanov Dmitry wrote: Hello, spice-devel, I've noticed that SPICE Server is still at 0.12.5 for quite some time. I

Re: [Spice-devel] [PATCH spice-gtk 3/3] RFC: channel: use class private handlers field

2015-06-08 Thread Fabiano Fidencio
- Original Message - From: Marc-André Lureau marcandre.lur...@redhat.com To: spice-devel@lists.freedesktop.org Sent: Friday, June 5, 2015 6:29:44 PM Subject: [Spice-devel] [PATCH spice-gtk 3/3] RFC: channel: use class private handlers field Since spice-gtk requires glib 2.28,

Re: [Spice-devel] When will next version of SPICE Server be released?

2015-06-08 Thread Javier Celaya
El Lunes, 8 de junio de 2015 17:12:21 Christophe Fergeau escribió: On Mon, Jun 08, 2015 at 05:02:29PM +0200, Javier Celaya wrote: Good feature indeed In fact, my patch to the qemu list to include lz4 in the -spice command line option has not prospered yet. Maybe, with a numbered version

Re: [Spice-devel] When will next version of SPICE Server be released?

2015-06-08 Thread Christophe Fergeau
On Mon, Jun 08, 2015 at 05:02:29PM +0200, Javier Celaya wrote: Good feature indeed ;) In fact, my patch to the qemu list to include lz4 in the -spice command line option has not prospered yet. Maybe, with a numbered version that supports the SPICE_IMAGE_COMPRESS_LZ4 constant, they will

Re: [Spice-devel] [PATCH spice-gtk 1/3] TODO: update

2015-06-08 Thread Fabiano Fidencio
- Original Message - From: Marc-André Lureau marcandre.lur...@redhat.com To: spice-devel@lists.freedesktop.org Sent: Friday, June 5, 2015 6:29:42 PM Subject: [Spice-devel] [PATCH spice-gtk 1/3] TODO: update Remove outdated items: - ChannelBaseAudio?, - GDI backend wouldn't work

Re: [Spice-devel] [PATCH spice-server v2 2/2] Handle preferred image compression messages

2015-06-08 Thread Javier Celaya
El Miércoles, 3 de junio de 2015 15:29:34 Christophe Fergeau escribió: On Tue, Jun 02, 2015 at 06:26:09PM +0200, Javier Celaya wrote: El Martes, 2 de junio de 2015 14:33:35 Christophe Fergeau escribió: My last remaining comment about this patch is that now the client can force the server

[Spice-devel] [PATCH qxl] spiceqxl: Recognize the same set of boolean values as in xorg.conf.

2015-06-08 Thread Francois Gouget
Report an error if an invalid boolean value is used, just like for other options. --- This seems simple enough and may avoid confusion. src/qxl_option_helpers.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/src/qxl_option_helpers.c

[Spice-devel] [PATCH qxl] Xspice: Don't set defaults for the options.

2015-06-08 Thread Francois Gouget
Otherwise they override Spice server's real builtin defaults, the Xorg configuration file settings, and even the XSPICE_XXX environment variables. --- Without this patch, calling Xspice _without_ the '--streaming-video' option forces this setting to 'filter', overriding the

Re: [Spice-devel] [PATCH spice] server: Remove an unused structure.

2015-06-08 Thread Francois Gouget
On Wed, 27 May 2015, Francois Gouget wrote: --- This struct was introduced in the first commit, c1b79eb0, about 6 years ago, but has never been used. So I think it's safe to remove. Is something holding up this patch? Does it need modifications for inclusion? -- Francois Gouget

Re: [Spice-devel] [PATCH] Allow Qemu to pass maximum head to guest

2015-06-08 Thread Marc-André Lureau
Hi Frediano - Original Message - Add a max_head field to QXLRom so Qemu can specify the maximum heads it wants. This to support heads argument in libvirt properly. Padding fields are added to make the structure multiple of 8 bytes. This as Qemu append to this structure some fields for