Hi Frediano,
On Fri, 2016-05-20 at 15:03 +0100, Frediano Ziglio wrote:
> Limit the virtual keystrokes sent to the remote machine.
> The modifiers are synced only when the application receive or lose
> the focus. This reduce a lot the possible virtual keystrokes sent
> to the guest to synchronize t
Acked-by: Pavel Grunt
On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> Since 8943d2329, the channel may be disconnected from the session
> before it's destroyed. In this case, session is NULL.
>
> Fixes some critical with virt-manager when closing a display:
>
> (virt-manager:20451
Hi Marc-André,
On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> The egl context is from Gtk on Wayland. Destroy it only on X11.
>
It deserves a comment in the code (like reference to spice_egl_init where the
context is initialized).
Pavel
> Signed-off-by: Marc-André Lureau
> ---
>
Hi,
On Fri, May 20, 2016 at 05:16:42PM +0200, Marc-André Lureau wrote:
> This is global to the display connection: all egl resources will be
> released, including those from other widgets or from the application.
This reverts 181ec2511902483df5c02ecf12db437d9975a53b
> Fix spice/virgl display bei
On Thu, 2016-05-19 at 13:21 +0200, Victor Toso wrote:
> This make possible to rename the function to
> spice_file_transfer_task_handle_status as a handler for
> VDAgentFileXferStatusMessage for a specific task.
>
> This change is related to split SpiceFileTransferTask from
> channel-main.
Acked-b
On Fri, May 20, 2016 at 03:35:50PM -0500, Jonathon Jongsma wrote:
> ok, I'll take some added typesafety over a having to pass the ->parent
> occasionally
Explicitly passing ->parent does not scale well though if you start
adding intermediate classes in the inheritance tree.
Christophe
signature
On Fri, May 20, 2016 at 02:01:43PM +0100, Frediano Ziglio wrote:
> Use a proper type for free callback
>
> Signed-off-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 10 ++
> server/dcc.c| 8 +---
> server/main-channel.c | 10 ++
> server/red-channel.c
>
> Hi Frediano,
>
> On Fri, 2016-05-20 at 15:03 +0100, Frediano Ziglio wrote:
> > Limit the virtual keystrokes sent to the remote machine.
> > The modifiers are synced only when the application receive or lose
> > the focus. This reduce a lot the possible virtual keystrokes sent
> > to the guest
Hi
On Mon, May 23, 2016 at 10:21 AM, Victor Toso wrote:
> Could you also include a fix that calls eglTerminate ?
Since this is global resources, spice-gtk (a library) can't do that by
itself without risking to break somebody else code.
--
Marc-André Lureau
>
> On Fri, May 20, 2016 at 03:35:50PM -0500, Jonathon Jongsma wrote:
> > ok, I'll take some added typesafety over a having to pass the ->parent
> > occasionally
>
> Explicitly passing ->parent does not scale well though if you start
> adding intermediate classes in the inheritance tree.
>
> Chr
Hi
On Mon, May 23, 2016 at 10:13 AM, Pavel Grunt wrote:
> Hi Marc-André,
>
> On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
>> The egl context is from Gtk on Wayland. Destroy it only on X11.
>>
> It deserves a comment in the code (like reference to spice_egl_init where the
> context
>
> On Fri, May 20, 2016 at 02:01:43PM +0100, Frediano Ziglio wrote:
> > Use a proper type for free callback
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/cursor-channel.c | 10 ++
> > server/dcc.c| 8 +---
> > server/main-channel.c | 10 ++
> > se
On Mon, 2016-05-23 at 11:36 +0200, Marc-André Lureau wrote:
> Hi
>
> On Mon, May 23, 2016 at 10:13 AM, Pavel Grunt wrote:
> > Hi Marc-André,
> >
> > On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> > > The egl context is from Gtk on Wayland. Destroy it only on X11.
> > >
> > It des
Hi,
On Mon, May 23, 2016 at 11:31:52AM +0200, Marc-André Lureau wrote:
> Hi
>
> On Mon, May 23, 2016 at 10:21 AM, Victor Toso wrote:
> > Could you also include a fix that calls eglTerminate ?
>
> Since this is global resources, spice-gtk (a library) can't do that by
> itself without risking to br
> > I don't find this very readable, and imo there is not a huge gain in
> > doing this over a cast... I'd just go with a cast + a static
> > compile-time assert that RedCursorPipeItem has a 'base' RedPipeItem
> > field at offset 0.
> >
>
> static void cursor_pipe_item_free(RedPipeItem *base)
> {
Hi
- Original Message -
> Hi,
>
> On Mon, May 23, 2016 at 11:31:52AM +0200, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, May 23, 2016 at 10:21 AM, Victor Toso wrote:
> > > Could you also include a fix that calls eglTerminate ?
> >
> > Since this is global resources, spice-gtk (a libra
>
> > > I don't find this very readable, and imo there is not a huge gain in
> > > doing this over a cast... I'd just go with a cast + a static
> > > compile-time assert that RedCursorPipeItem has a 'base' RedPipeItem
> > > field at offset 0.
> > >
> >
> > static void cursor_pipe_item_free(RedPi
>
> In general, this is a good idea, but I question why you're doing it now.
> There
> are patches already in the refactory branch which change the PipeItem ring
> into
> a GList (although perhaps GQueue might be more appropriate). That patch would
> also fix the underlying issue you're solving he
On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> Gtk does it for us already with GtkGlArea.
>
Can be commented in the code as well
Acked-by: Pavel Grunt
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-widget-egl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
On Mon, May 23, 2016 at 05:57:52AM -0400, Frediano Ziglio wrote:
> You didn't understand the problem, this is not enough
> as a refactory of this would require a complete code scan
> as currently is (was?) needed, you have to check for every
> cast.
You did not explicitly state the problem either
Hi,
On Mon, May 23, 2016 at 05:53:35AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > Hi,
> >
> > On Mon, May 23, 2016 at 11:31:52AM +0200, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Mon, May 23, 2016 at 10:21 AM, Victor Toso
> > > wrote:
> > > > Could you also i
Hi,
On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> On X11, each widget has its own context. Make sure we are using the
> widget associated context when using gl.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1337721
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spi
On Mon, May 23, 2016 at 05:35:29AM -0400, Frediano Ziglio wrote:
> >
> > On Fri, May 20, 2016 at 03:35:50PM -0500, Jonathon Jongsma wrote:
> > > ok, I'll take some added typesafety over a having to pass the ->parent
> > > occasionally
> >
> > Explicitly passing ->parent does not scale well though
- Original Message -
> Hi,
>
> On Mon, May 23, 2016 at 05:53:35AM -0400, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > Hi,
> > >
> > > On Mon, May 23, 2016 at 11:31:52AM +0200, Marc-André Lureau wrote:
> > > > Hi
> > > >
> > > > On Mon, May 23, 2016 at 10:21
- Original Message -
> Hi,
>
> On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> > On X11, each widget has its own context. Make sure we are using the
> > widget associated context when using gl.
> >
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1337721
> >
> >
From: Jonathon Jongsma
Preparation for converting to GObject
Acked-by: Frediano Ziglio
---
server/Makefile.am | 2 +
server/inputs-channel-client.c | 87 ++
server/inputs-channel-client.h | 48 +++
server/inputs-channel.c
From: Jonathon Jongsma
Instead of using a Ring, use a GList to store the list of channel
clients. This allows us to iterate the clients without poking inside of
the client struct to get the channel_link. This is required in order to
make the RedChannelClient struct private.
---
server/display-ch
Dear all,
I am trying to install Spice-0.13.1 with LZ4 enabled on my Ubuntu 14.04LTS.
However, I am getting the blow error during ./configure,
checking for LZ4... no
configure: error: lz4 support requested but liblz4 could not be found
But I confirmed that I installed liblz4, liblz4-dev & liblz4-
From: Jonathon Jongsma
Add a few more methods and accessors so that other files don't need to
manipulate the struct members directly. Move the struct definition to a
private header which only the dcc-* files will include.
---
server/Makefile.am | 1 +
server/dcc-encoders.c| 5 +--
se
The egl context is from Gtk on Wayland. Destroy it only on X11.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-egl.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
index 961dcfa..a3db856 10
This is global to the display connection: all egl resources will be
released, including those from other widgets or from the application.
Fix spice/virgl display being rendered black after another widget
display is destroyed.
Signed-off-by: Marc-André Lureau
---
src/spice-widget-egl.c | 4 +++-
On X11, each widget has its own context. Make sure we are using the
widget associated context when using gl.
With gtk 3.16, glEGLImageTargetTexture2DOES() can be called during
update scanout, since we can call gtk_gl_area_make_current(). On < 3.16,
do it before drawing.
Fixes:
https://bugzilla.re
Hi,
On Mon, May 23, 2016 at 06:39:25AM -0400, Marc-André Lureau wrote:
>
>
> - Original Message -
> > Hi,
> >
> > On Mon, May 23, 2016 at 05:53:35AM -0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > - Original Message -
> > > > Hi,
> > > >
> > > > On Mon, May 23, 2016 at 11:3
On Mon, May 23, 2016 at 06:40:40AM -0400, Marc-André Lureau wrote:
>
>
> - Original Message -
> > Hi,
> >
> > On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> > > On X11, each widget has its own context. Make sure we are using the
> > > widget associated context when using g
First patch just replaces a g_list_append with g_list_prepend to
avoid order change.
Second introduced some macros I proposed. If agreed could be
merged to first one.
Frediano Ziglio (1):
RedChannel: Add FOREACH_CHANNELL and use it to iterate
Jonathon Jongsma (1):
Replace RedClient::channels
From: Jonathon Jongsma
Allows us to not expose the client_link in RedChannelClient.
Acked-by: Pavel Grunt
---
server/red-channel.c | 51 ---
server/red-channel.h | 5 +
2 files changed, 29 insertions(+), 27 deletions(-)
diff --git a/server/
Signed-off-by: Frediano Ziglio
---
server/red-channel.c | 44
1 file changed, 24 insertions(+), 20 deletions(-)
diff --git a/server/red-channel.c b/server/red-channel.c
index 2b37fed..9ec9a26 100644
--- a/server/red-channel.c
+++ b/server/red-channel.
The idea is mainly to have a design improvement over the current file-transfer
logic by trying to detach it from channel-main and the agent logic plus a few
simple tests.
One interesting change is about creating a FileTransfereOperation per
drag-and-drop operation in channel-main, which removes th
---
src/spice-channel.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index c555f75..8b159f4 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -1891,7 +1891,10 @@ error:
G_GNUC_INTERNAL
void spice_channel_wakeup(Spic
In file included from
../spice-common/common/client_marshallers.h:29:0,
from ../src/spice-channel-priv.h:35,
from ../src/spice-file-transfer-task-priv.h:28,
from file-transfer.c:3:
../spice-common/common/messages.h:45:23: fatal error: libcacard.h: No such file
or directory
compilation terminated.
Each call to spice_main_file_copy_async will now create a
FileTransferOperation which groups all SpiceFileTransferTasks of the
copy operation and also the progress_callback passed from Application.
As pointed in the fix 113093dd00a1cf10f6d3c3589b7589a184cec081, the
progress_callback should provide
By introducing a flush_callback such as SpiceFileTransferTaskFlushCb
SpiceFileTransferTask becomes agnostic on how channel-main flushes
the data.
The spice_file_transfer_task_flush_done() function is now introduced
to tell SpiceFileTransferTask that flushing is over and we can read
more data if no
By splitting file_xfer_send_start_msg_async we can separate in three
different steps the spice_main_file_copy_async function:
1-) Creating tasks with spice_file_transfer_task_create_tasks which
now returns a GList of SpiceFileTransferTask;
2-) Setting handlers before the SpiceFileTransferTask
In order to avoid sending the agent message on
file_xfer_info_async_cb, we can provide the "file-info" signal to
SpiceFileTransferTask.
In order to this signal be significant to applications, we request all
standard attributes to g_file_query_info_async.
This change is related to split SpiceFileT
---
tests/file-transfer.c | 34 ++
1 file changed, 34 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index 5ef11a7..1421f1e 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -144,6 +144,32 @@ test_simple_transfer(Fixture *f
This only includes a simple test for file-transfer with a small
summary of the possible situations of the test.
As the test is specifically for SpiceFileTransferTask, we don't create
a SpiceMainChannel. That could cause a simple crash on CHANNEL_DEBUG
which this patch addresses.
---
tests/Makefil
SpiceFileTransferTask has a callback to be called when operation
ended. Til this patch, we were setting the user callback which means
that in multiple file-transfers, we were calling the user callback
several times.
Following the same logic pointed from 113093dd00a1cf10f6d3c3589b7 this
is a SpiceM
This make possible to rename the function to
spice_file_transfer_task_handle_status as a handler for
VDAgentFileXferStatusMessage for a specific task.
This change is related to split SpiceFileTransferTask from
channel-main.
Acked-by: Pavel Grunt
---
src/channel-main.c | 25 ++---
No need to inform of a problem under
spice_file_transfer_task_completed() as the task will be finalized and
we can send the error to the agent there.
This change is related to split SpiceFileTransferTask from
channel-main.
---
src/channel-main.c | 19 +--
1 file changed, 9 inserti
---
tests/file-transfer.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index d8dcf6c..be4d585 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -211,6 +211,47 @@ test_cancel_on_f
---
src/spice-channel-priv.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/spice-channel-priv.h b/src/spice-channel-priv.h
index 50aca5c..dcb5377 100644
--- a/src/spice-channel-priv.h
+++ b/src/spice-channel-priv.h
@@ -41,7 +41,9 @@ G_BEGIN_DECLS
#define MAX_SPICE_DAT
Previous six patches are related to this change. This patch moves:
* GObject boilerplate
* External API related to SpiceFileTransferTask
* Internal API needed by channel-main
* Helpers that belong to this object
---
src/Makefile.am | 2 +
src/channel-main.c |
Agent only can only send error or cancel from a transfer operation
after it was initialized. In the context of SpiceFileTransferTask, it
means that we need to test only after file-info was emitted.
---
tests/file-transfer.c | 90 +++
1 file changed,
---
tests/file-transfer.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/file-transfer.c b/tests/file-transfer.c
index 1421f1e..d8dcf6c 100644
--- a/tests/file-transfer.c
+++ b/tests/file-transfer.c
@@ -170,6 +170,47 @@ test_cancel_on_s
>
> On Mon, May 23, 2016 at 05:57:52AM -0400, Frediano Ziglio wrote:
> > You didn't understand the problem, this is not enough
> > as a refactory of this would require a complete code scan
> > as currently is (was?) needed, you have to check for every
> > cast.
>
> You did not explicitly state th
Hi
- Original Message -
> On Mon, May 23, 2016 at 06:40:40AM -0400, Marc-André Lureau wrote:
> >
> >
> > - Original Message -
> > > Hi,
> > >
> > > On Fri, 2016-05-20 at 17:16 +0200, Marc-André Lureau wrote:
> > > > On X11, each widget has its own context. Make sure we are using
>
> ---
> src/channel-usbredir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c
> index ddd0d1b..a6cbfe0 100644
> --- a/src/channel-usbredir.c
> +++ b/src/channel-usbredir.c
> @@ -796,7 +796,7 @@ static void spice_usbredir
Hi,
Resuming to work on this after 2.6 freeze break ...
> I have done some more testing and sent a series for spice-gtk fixing
> display with gl scanout-only case. And a minor patch to spice server
> to solve a cursor initialization when there is no canvas. Your series
> works ok with that, onl
Hi
On Mon, May 23, 2016 at 3:52 PM, Gerd Hoffmann wrote:
> Hi,
>
> Resuming to work on this after 2.6 freeze break ...
>
>> I have done some more testing and sent a series for spice-gtk fixing
>> display with gl scanout-only case. And a minor patch to spice server
>> to solve a cursor initializ
On Mon, 2016-05-23 at 13:01 +0200, Marc-André Lureau wrote:
> The egl context is from Gtk on Wayland. Destroy it only on X11.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Pavel Grunt
> ---
> src/spice-widget-egl.c | 28 +---
> 1 file changed, 17 insertions(+), 11 delet
On Mon, 2016-05-23 at 13:01 +0200, Marc-André Lureau wrote:
> On X11, each widget has its own context. Make sure we are using the
> widget associated context when using gl.
>
> With gtk 3.16, glEGLImageTargetTexture2DOES() can be called during
> update scanout, since we can call gtk_gl_area_make_c
Thanks for adding all the comments,
ack from me
Pavel
On Mon, 2016-05-23 at 13:01 +0200, Marc-André Lureau wrote:
> This is global to the display connection: all egl resources will be
> released, including those from other widgets or from the application.
>
> Fix spice/virgl display being rende
On Mon, May 23, 2016 at 07:54:03AM -0400, Frediano Ziglio wrote:
> Other part. You can find code where the parent is NOT the first
> field (for different reasons), I did some improvements on this.
> You can also find places were a class is "inherited" just to
> reuse some feature, so it's really li
On Mon, May 23, 2016 at 05:28:21PM +0200, Pavel Grunt wrote:
> Thanks for adding all the comments,
>
> ack from me
Acked-by: Victor Toso
and series.
Thanks!
>
> Pavel
>
> On Mon, 2016-05-23 at 13:01 +0200, Marc-André Lureau wrote:
> > This is global to the display connection: all egl resourc
Signed-off-by: Marc-André Lureau
---
Hi,
It would be nice to release spice-gtk 0.32 with all the fixes for
virgl. Is there any known regression left or something good enough to
include before a release?
thanks
NEWS | 26 ++
1 file changed, 26 insertions(+)
diff --git a
Acked-by: Jonathon Jongsma
On Thu, 2016-05-19 at 11:20 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/spice_style.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 957e017..b024b6b 100644
> --- a/do
Acked-by: Jonathon Jongsma
On Thu, 2016-05-19 at 11:21 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-replay-qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c
> index 281bc7a..60e4
I guess this is just my patch with the erroneous const changes removed? I guess
it can be considered ACKed then.
On Mon, 2016-05-23 at 11:46 +0100, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Preparation for converting to GObject
>
> Acked-by: Frediano Ziglio
> ---
> server/Makefile.
Typo in commit summary (CHANNELL -> CHANNEL)
Also: do we really need an unsafe version of the loop? why not just have a
single version that's always safe?
On Mon, 2016-05-23 at 12:42 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-channel.c | 44 ++
>
> I guess this is just my patch with the erroneous const changes removed? I
> guess
> it can be considered ACKed then.
>
Both yes!
>
> On Mon, 2016-05-23 at 11:46 +0100, Frediano Ziglio wrote:
> > From: Jonathon Jongsma
> >
> > Preparation for converting to GObject
> >
> > Acked-by: Fredi
On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
> > /* FIXME: move back to display-channel.h (once structs are private) */
> > typedef struct Drawable Drawable;
> > -typedef struct DisplayChannelClient DisplayChannelClient;
> >
>
> We definitively should consider using struct Xxxx i
>
> Typo in commit summary (CHANNELL -> CHANNEL)
>
> Also: do we really need an unsafe version of the loop? why not just have a
> single version that's always safe?
>
That's fine for me, just in the code you respected the safe/unsafe
behavior.
Actually I think can be rewritten to
#define FORE
>
> >
> > Typo in commit summary (CHANNELL -> CHANNEL)
> >
> > Also: do we really need an unsafe version of the loop? why not just have a
> > single version that's always safe?
> >
>
> That's fine for me, just in the code you respected the safe/unsafe
> behavior.
>
> Actually I think can be r
On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
> On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
>
> > > /* FIXME: move back to display-channel.h (once structs are private) */
> > > typedef struct Drawable Drawable;
> > > -typedef struct DisplayChannelClient DisplayChannelC
Hi,
On Mon, 2016-05-23 at 16:19 -0500, Jonathon Jongsma wrote:
> On Mon, 2016-05-23 at 15:17 -0500, Jonathon Jongsma wrote:
> > On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:
> >
> > > > /* FIXME: move back to display-channel.h (once structs are private) */
> > > > typedef struct Dra
75 matches
Mail list logo
