Hi,
it works. But do we need a new public symbol ? It is an internal stuff
for channel-main.
Pavel
On Wed, 2016-12-21 at 18:55 +0100, Victor Toso wrote:
> From: Victor Toso
>
> During file transfer, we can have error and cancellation in client,
> host or guest side.
>
> If error happens in th
Hi,
On Thu, Dec 22, 2016 at 11:35:13AM +0100, Pavel Grunt wrote:
> Hi,
>
> it works. But do we need a new public symbol ? It is an internal stuff
> for channel-main.
>
> Pavel
Yeah, I was also thinking if this is really necessary.
Application can track SpiceFileTransferTask "finished" signal too
Let me know if this one needs more tweaks!
On Mon, Dec 19, 2016 at 06:50:02PM +0100, Victor Toso wrote:
> From: Victor Toso
>
> As we have UsbDk integration now which is well maintained upstream.
>
> Signed-off-by: Victor Toso
> ---
> doc/reference/Makefile.am| 2 -
> src/Makefile.am
Hi,
lgtm
considering that you tested and it works - Ack
Pavel
On Thu, 2016-12-22 at 14:18 +0100, Victor Toso wrote:
> Let me know if this one needs more tweaks!
>
> On Mon, Dec 19, 2016 at 06:50:02PM +0100, Victor Toso wrote:
> > From: Victor Toso
> >
> > As we have UsbDk integration now which
---
vdservice/vdservice.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
index 1892b72..dc49ec5 100644
--- a/vdservice/vdservice.cpp
+++ b/vdservice/vdservice.cpp
@@ -25,7 +25,7 @@
//#define DEBUG_VDSERVICE
-#define VD_S
From: Sebastian Andrzej Siewior
This commit changes to an actual new BIO method rather than reusing an
existing BIO method, and overriding only the fields that we need.
The approach before this commit would be causing issues with OpenSSL
1.1.0 as some of the fields we access have become opaque.
-
Hey,
Sebastian sent these patches privately a while ago, I've run some tests on them
and helped split them. They add support for OpenSSL 1.1.0 which makes some of
the
structures we were directly accessing private. This also keeps support with
older
OpenSSL releases by adding some compat helpers.
From: Sebastian Andrzej Siewior
OpenSSL 1.1.0 does not seem to provide API to do that anymore.
There is no need to create a custom lookup to begin with. This method
here has no callbacks implemented and is doing nothing. The way I
understand it, it is used to retrieve a `lookup' object which pro
From: Sebastian Andrzej Siewior
In OpenSSL 1.1.0, the struct fields are private so we can no longer
directly access them.
The accessors are not available in previous OpenSSL releases, so we need
to add compat helpers.
---
src/bio-gio.c | 103 ---
Hi,
On Thu, Dec 22, 2016 at 06:02:00PM +0200, Uri Lublin wrote:
> ---
> vdservice/vdservice.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
> index 1892b72..dc49ec5 100644
> --- a/vdservice/vdservice.cpp
> +++ b/vdser
I'd like additional comments in the commit log explaining why we can do
this (because we refactored the sound stuff to use the RedChannelClient
infrastructure, etc)
The code looks fine though
Acked-by: Jonathon Jongsma
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> Signed-off-by:
Good, but I think the commit log is a little bit misleading. After
reading the summary, I thought you were fixing a leak. But you're
actually just moving the freeing of these variables to finalize instead
of doing it in detach. I'd prefer something more like:
-
sound: free SndChannel data in f
OK, I don't see any downsides here.
Acked-by: Jonathon Jongsma
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 19 ---
> 1 file changed, 19 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> in
Acked-by: Jonathon Jongsma
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> Almost identical beside the type.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 53 +++-
> ---
> 1 file changed, 16 insertions(+), 37 deletions(-)
>
OK, seems fine.
Acked-by: Jonathon Jongsma
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> We support only a single client so don't waste code just
> to check this.
> The worst stuff can happen is that we'll migrate multiple
> connections.
>
> Signed-off-by: Frediano Ziglio
> ---
Acked-by: Jonathon Jongsma
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 51 +---
> ---
> 1 file changed, 21 insertions(+), 30 deletions(-)
>
> diff --git a/server/sound.c b/serv
Acked-by: Jonathon Jongsma
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index 33d0e96..351cd8d 100644
On Tue, 2016-12-20 at 17:44 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/sound.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/server/sound.c b/server/sound.c
> index 351cd8d..836a525 100644
> --- a/server/sound.c
> +++ b/server/s
On Thu, 2016-12-22 at 14:17 +0100, Victor Toso wrote:
> Hi,
>
> On Thu, Dec 22, 2016 at 11:35:13AM +0100, Pavel Grunt wrote:
> > Hi,
> >
> > it works. But do we need a new public symbol ? It is an internal
> > stuff
> > for channel-main.
> >
> > Pavel
>
> Yeah, I was also thinking if this is
On Thu, 2016-12-22 at 11:23 -0600, Jonathon Jongsma wrote:
>
>
> On Thu, 2016-12-22 at 14:17 +0100, Victor Toso wrote:
> > Hi,
> >
> > On Thu, Dec 22, 2016 at 11:35:13AM +0100, Pavel Grunt wrote:
> > > Hi,
> > >
> > > it works. But do we need a new public symbol ? It is an internal
> > > stuff
20 matches
Mail list logo
