Re: [Spice-devel] [PATCH v3 1/2] Do endian swapping.

On Fri, 13 Jan 2017 06:52:17 -0500 (EST) Frediano Ziglio wrote: > > case VD_AGENT_FILE_XFER_STATUS: > > case VD_AGENT_FILE_XFER_DATA: > > +if (message_header->size < > > sizeof(VDAgentFileXferStartMessage)) > > +goto size_error; > > +*id

[Spice-devel] R: virt-viewer 5.0 binary for windows error in win 8.1

Hi, It is strange, now works again (no change made in windows). If the problem return I try to do a dump although I do not know if in windows it is possible. Best regards, Gianpietro. _ Da: Frediano Ziglio [mailto:fzig...@redhat.com] Inviato: venerdì 13 gennaio 2017 13.44 A: gianpietro

Re: [Spice-devel] [PATCH spice-gtk] widget: Set cursor in constructor

Hi, On Fri, 2017-01-13 at 09:01 -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > In a multimonitor environment can easily happen that a cursor is > > set > > before some of the SpiceDisplays are created. IOW the first > > created > > SpiceDisplay has the cursor but

Re: [Spice-devel] [PATCH spice-gtk] widget: Set cursor in constructor

Hi - Original Message - > Hi, > > On Fri, 2017-01-13 at 09:01 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > In a multimonitor environment can easily happen that a cursor is > > > set > > > before some of the SpiceDisplays are created. IOW the first >

Re: [Spice-devel] [PATCH spice-gtk] widget: Set cursor in constructor

On Fri, 2017-01-13 at 09:17 -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi, > > > > On Fri, 2017-01-13 at 09:01 -0500, Marc-André Lureau wrote: > > > Hi > > > > > > - Original Message - > > > > In a multimonitor environment can easily happen that a cursor >

Re: [Spice-devel] [PATCH spice-gtk] widget: Set cursor in constructor

Hi - Original Message - > On Fri, 2017-01-13 at 09:17 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > Hi, > > > > > > On Fri, 2017-01-13 at 09:01 -0500, Marc-André Lureau wrote: > > > > Hi > > > > > > > > - Original Message - > > > > > In a

Re: [Spice-devel] [PATCH spice-gtk] widget: Set cursor in constructor

Hi - Original Message - > In a multimonitor environment can easily happen that a cursor is set > before some of the SpiceDisplays are created. IOW the first created > SpiceDisplay has the cursor but others don't. > > To avoid the issue cache the information about the last set cursor in >

[Spice-devel] [PATCH spice 2/2] Include compat header for g_clear_pointer

--- server/reds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/reds.c b/server/reds.c index e061e4d1..29485a8b 100644 --- a/server/reds.c +++ b/server/reds.c @@ -75,6 +75,7 @@ #include "red-channel-client.h" #include "main-channel-client.h" #include "red-client.h" +#include

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

On Wed, Jan 11, 2017 at 09:43:48AM -0500, Frediano Ziglio wrote: > > > > snd_set_command()/snd_send() are higher level methods which take care of > > scheduling calls to the corresponding snd_*_send_*() methods when > > appropriate. This commit switches a few direct snd_*_send_*() calls to > >

[Spice-devel] [PATCH spice 1/2] build-sys: Warn on usage of unavailable glib functions

It works only with glib2 >= 2.32 --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index a78b4ece..50135b5e 100644 --- a/configure.ac +++ b/configure.ac @@ -147,7 +147,10 @@ PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=

Re: [Spice-devel] [spice-server 11/17] sound: Prefer snd_set_command() over snd_*_send_*()

> > On Wed, Jan 11, 2017 at 09:43:48AM -0500, Frediano Ziglio wrote: > > > > > > snd_set_command()/snd_send() are higher level methods which take care of > > > scheduling calls to the corresponding snd_*_send_*() methods when > > > appropriate. This commit switches a few direct snd_*_send_*()

Re: [Spice-devel] [PATCH spice 1/2] build-sys: Warn on usage of unavailable glib functions

> > It works only with glib2 >= 2.32 > --- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index a78b4ece..50135b5e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -147,7 +147,10 @@ PKG_CHECK_MODULES([SPICE_PROTOCOL],

Re: [Spice-devel] [PATCH spice 2/2] Include compat header for g_clear_pointer

> > --- > server/reds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/reds.c b/server/reds.c > index e061e4d1..29485a8b 100644 > --- a/server/reds.c > +++ b/server/reds.c > @@ -75,6 +75,7 @@ > #include "red-channel-client.h" > #include "main-channel-client.h" > #include

Re: [Spice-devel] [PATCH v3 1/2] Do endian swapping.

> > This allows running big endian and little endian guest side by side using > cut & paste between them. > > There is a general design idea that swapping should come as close to > virtio_read/virtio_write as possible. In particular, the protocol > between vdagent and vdagentd is guest-specific

Re: [Spice-devel] [PATCH spice 1/2] build-sys: Warn on usage of unavailable glib functions

On Fri, 2017-01-13 at 06:09 -0500, Frediano Ziglio wrote: > > > > It works only with glib2 >= 2.32 > > --- > >  configure.ac | 3 +++ > >  1 file changed, 3 insertions(+) > > > > diff --git a/configure.ac b/configure.ac > > index a78b4ece..50135b5e 100644 > > --- a/configure.ac > > +++

Re: [Spice-devel] [PATCH spice] Avoid a 'missing braces around initializer' warning.

> > Signed-off-by: Jeremy White > --- > server/tests/replay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/tests/replay.c b/server/tests/replay.c > index 8ec65d6..1f3ebb1 100644 > --- a/server/tests/replay.c > +++

[Spice-devel] [spice-common] ssl: Use ASN1_STRING_get0_data instead of ASN1_STRING_data

From: Sebastian Andrzej Siewior The latter is deprecated, so might be removed at some point in the future. This also adds a compatibility wrapper for OpenSSL < 1.1.0. Signed-off-by: Sebastian Andrzej Siewior --- common/ssl_verify.c | 20

Re: [Spice-devel] virt-viewer 5.0 binary for windows error in win 8.1

> Hi, > a month ago I installed virt-viewer binary for win 8.1 system: > https://virt-manager.org/download/sources/virt-viewer/virt-viewer-x64-5.0.msi > it worked up to a week ago . > Then I did an stardard update of system (the automatic microsoft periodic > update). > Now the program does

Re: [Spice-devel] [spice-server 08/17] sound: Implement snd_channel_config_socket

On Wed, Jan 11, 2017 at 06:28:06AM -0500, Frediano Ziglio wrote: > > @@ -1004,24 +964,68 @@ static SndChannelClient *__new_channel(SndChannel > > *channel, int size, uint32_t c > > client->cleanup = cleanup; > > > > client->channel_client = > > -

[Spice-devel] [PATCH spice v2 1/2] build-sys: Warn on usage of unavailable glib functions

Warnings are printed when glib2 >= 2.32 is present --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index a78b4ece..50135b5e 100644 --- a/configure.ac +++ b/configure.ac @@ -147,7 +147,10 @@ PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=

[Spice-devel] [PATCH spice-gtk] widget: Set cursor in constructor

In a multimonitor environment can easily happen that a cursor is set before some of the SpiceDisplays are created. IOW the first created SpiceDisplay has the cursor but others don't. To avoid the issue cache the information about the last set cursor in the SpiceGtkSession and set the cursor shape

Re: [Spice-devel] [PATCH spice] Avoid a 'missing braces around initializer' warning.

On 01/13/2017 04:48 AM, Frediano Ziglio wrote: >> >> Signed-off-by: Jeremy White >> --- >> server/tests/replay.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/server/tests/replay.c b/server/tests/replay.c >> index 8ec65d6..1f3ebb1 100644 >>

Re: [Spice-devel] [PATCH spice v2 1/2] build-sys: Warn on usage of unavailable glib functions

> > Warnings are printed when glib2 >= 2.32 is present > --- > configure.ac | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/configure.ac b/configure.ac > index a78b4ece..50135b5e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -147,7 +147,10 @@